[INFO] crate piston-editor 0.3.0 is already in cache
[INFO] extracting crate piston-editor 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/piston-editor/0.3.0
[INFO] extracting crate piston-editor 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-editor/0.3.0
[INFO] validating manifest of piston-editor-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of piston-editor-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing piston-editor-0.3.0
[INFO] finished frobbing piston-editor-0.3.0
[INFO] frobbed toml for piston-editor-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/piston-editor/0.3.0/Cargo.toml
[INFO] started frobbing piston-editor-0.3.0
[INFO] finished frobbing piston-editor-0.3.0
[INFO] frobbed toml for piston-editor-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-editor/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting piston-editor-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston-editor/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2feb5439b61d3a5be28a6af81f6a00e0077c741124dfb4aa5ec3f6460f8f7f24
[INFO] running `"docker" "start" "-a" "2feb5439b61d3a5be28a6af81f6a00e0077c741124dfb4aa5ec3f6460f8f7f24"`
[INFO] [stderr]     Checking piston-editor v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:94:19
[INFO] [stderr]    |
[INFO] [stderr] 94 |         None => { return Err(()); }
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     fn get<'a>(&'a self, ty: Type, obj: Object) -> Result<&'a Any, ()>;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:76:8
[INFO] [stderr]    |
[INFO] [stderr] 76 |     if items.len() == 0 { return Err(()); }
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:103:22
[INFO] [stderr]     |
[INFO] [stderr] 103 | pub fn all<T>(items: &Vec<T>) -> Vec<Object> {
[INFO] [stderr]     |                      ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:104:26
[INFO] [stderr]     |
[INFO] [stderr] 104 |     (0..items.len()).map(|i| Object(i)).collect()
[INFO] [stderr]     |                          ^^^^^^^^^^^^^ help: remove closure as shown: `Object`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:108:27
[INFO] [stderr]     |
[INFO] [stderr] 108 | pub fn get<T: Any>(items: &Vec<T>, obj: Object) -> Result<&Any, ()> {
[INFO] [stderr]     |                           ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:94:19
[INFO] [stderr]    |
[INFO] [stderr] 94 |         None => { return Err(()); }
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     fn get<'a>(&'a self, ty: Type, obj: Object) -> Result<&'a Any, ()>;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:76:8
[INFO] [stderr]    |
[INFO] [stderr] 76 |     if items.len() == 0 { return Err(()); }
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:103:22
[INFO] [stderr]     |
[INFO] [stderr] 103 | pub fn all<T>(items: &Vec<T>) -> Vec<Object> {
[INFO] [stderr]     |                      ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:104:26
[INFO] [stderr]     |
[INFO] [stderr] 104 |     (0..items.len()).map(|i| Object(i)).collect()
[INFO] [stderr]     |                          ^^^^^^^^^^^^^ help: remove closure as shown: `Object`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:108:27
[INFO] [stderr]     |
[INFO] [stderr] 108 | pub fn get<T: Any>(items: &Vec<T>, obj: Object) -> Result<&Any, ()> {
[INFO] [stderr]     |                           ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.41s
[INFO] running `"docker" "inspect" "2feb5439b61d3a5be28a6af81f6a00e0077c741124dfb4aa5ec3f6460f8f7f24"`
[INFO] running `"docker" "rm" "-f" "2feb5439b61d3a5be28a6af81f6a00e0077c741124dfb4aa5ec3f6460f8f7f24"`
[INFO] [stdout] 2feb5439b61d3a5be28a6af81f6a00e0077c741124dfb4aa5ec3f6460f8f7f24