[INFO] crate pircolate 0.2.1 is already in cache [INFO] extracting crate pircolate 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/pircolate/0.2.1 [INFO] extracting crate pircolate 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pircolate/0.2.1 [INFO] validating manifest of pircolate-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pircolate-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pircolate-0.2.1 [INFO] finished frobbing pircolate-0.2.1 [INFO] frobbed toml for pircolate-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/pircolate/0.2.1/Cargo.toml [INFO] started frobbing pircolate-0.2.1 [INFO] finished frobbing pircolate-0.2.1 [INFO] frobbed toml for pircolate-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pircolate/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pircolate-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pircolate/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e7593d1b3a493610da1024e33b7ed23a1b670a6eacb7dfcdead19eaefaed60d4 [INFO] running `"docker" "start" "-a" "e7593d1b3a493610da1024e33b7ed23a1b670a6eacb7dfcdead19eaefaed60d4"` [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking pircolate v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/parser.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/parser.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/parser.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | prefix: prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/parser.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/parser.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/parser.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/parser.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | prefix: prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/parser.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/message/parser.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / let mut user_range = None; [INFO] [stderr] 127 | | if input[position] == b'!' { [INFO] [stderr] 128 | | position = move_next(position, len)?; [INFO] [stderr] 129 | | let user_start = position; [INFO] [stderr] ... | [INFO] [stderr] 135 | | user_range = Some(user_start..position); [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let user_range = if input[position] == b'!' { ..; Some(user_start..position) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/message/parser.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / let mut host_range = None; [INFO] [stderr] 139 | | if input[position] == b'@' { [INFO] [stderr] 140 | | position = move_next(position, len)?; [INFO] [stderr] 141 | | let host_start = position; [INFO] [stderr] ... | [INFO] [stderr] 147 | | host_range = Some(host_start..position); [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let host_range = if input[position] == b'@' { ..; Some(host_start..position) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/message/parser.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / let mut user_range = None; [INFO] [stderr] 127 | | if input[position] == b'!' { [INFO] [stderr] 128 | | position = move_next(position, len)?; [INFO] [stderr] 129 | | let user_start = position; [INFO] [stderr] ... | [INFO] [stderr] 135 | | user_range = Some(user_start..position); [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let user_range = if input[position] == b'!' { ..; Some(user_start..position) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/message/parser.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / let mut host_range = None; [INFO] [stderr] 139 | | if input[position] == b'@' { [INFO] [stderr] 140 | | position = move_next(position, len)?; [INFO] [stderr] 141 | | let host_start = position; [INFO] [stderr] ... | [INFO] [stderr] 147 | | host_range = Some(host_start..position); [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let host_range = if input[position] == b'@' { ..; Some(host_start..position) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.28s [INFO] running `"docker" "inspect" "e7593d1b3a493610da1024e33b7ed23a1b670a6eacb7dfcdead19eaefaed60d4"` [INFO] running `"docker" "rm" "-f" "e7593d1b3a493610da1024e33b7ed23a1b670a6eacb7dfcdead19eaefaed60d4"` [INFO] [stdout] e7593d1b3a493610da1024e33b7ed23a1b670a6eacb7dfcdead19eaefaed60d4