[INFO] crate pipecolor 0.4.0 is already in cache
[INFO] extracting crate pipecolor 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/pipecolor/0.4.0
[INFO] extracting crate pipecolor 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pipecolor/0.4.0
[INFO] validating manifest of pipecolor-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pipecolor-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pipecolor-0.4.0
[INFO] finished frobbing pipecolor-0.4.0
[INFO] frobbed toml for pipecolor-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/pipecolor/0.4.0/Cargo.toml
[INFO] started frobbing pipecolor-0.4.0
[INFO] finished frobbing pipecolor-0.4.0
[INFO] frobbed toml for pipecolor-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pipecolor/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pipecolor-0.4.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pipecolor/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b08e942a8ce3b076970221ed14643d465b018c25c1bf34f12daf33dadb517f55
[INFO] running `"docker" "start" "-a" "b08e942a8ce3b076970221ed14643d465b018c25c1bf34f12daf33dadb517f55"`
[INFO] [stderr]     Checking timeout-readwrite v0.1.0
[INFO] [stderr]    Compiling proc-reader v0.4.0
[INFO] [stderr]     Checking pipecolor v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/main.rs:13:1
[INFO] [stderr]    |
[INFO] [stderr] 13 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | use std::env::home_dir;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/main.rs:137:33
[INFO] [stderr]     |
[INFO] [stderr] 137 |     } else if let Some(mut p) = home_dir() {
[INFO] [stderr]     |                                 ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/main.rs:13:1
[INFO] [stderr]    |
[INFO] [stderr] 13 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | use std::env::home_dir;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/main.rs:137:33
[INFO] [stderr]     |
[INFO] [stderr] 137 |     } else if let Some(mut p) = home_dir() {
[INFO] [stderr]     |                                 ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/colorize.rs:123:18
[INFO] [stderr]     |
[INFO] [stderr] 123 | fn conv_color(s: &Option<&String>) -> Result<Box<Color>> {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&String>`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/colorize.rs:124:27
[INFO] [stderr]     |
[INFO] [stderr] 124 |       let ret: Box<Color> = if let &Some(ref s) = s {
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 125 | |         match s.as_ref() {
[INFO] [stderr] 126 | |             "Black" => Box::new(color::Black),
[INFO] [stderr] 127 | |             "Blue" => Box::new(color::Blue),
[INFO] [stderr] ...   |
[INFO] [stderr] 148 | |         Box::new(color::Reset)
[INFO] [stderr] 149 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 124 |     let ret: Box<Color> = if let Some(ref s) = *s {
[INFO] [stderr]     |                                  ^^^^^^^^^^^   ^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/read_timeout.rs:34:54
[INFO] [stderr]    |
[INFO] [stderr] 34 |                     buf.extend_from_slice(&available[..i + 1]);
[INFO] [stderr]    |                                                      ^^^^^^^ help: use: `..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:223:9
[INFO] [stderr]     |
[INFO] [stderr] 223 |         let _ = output(&mut *reader, writer.get_mut(), use_color, &config, &opt)?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 |         let _ = output(&mut *reader, writer.get_mut(), use_color, &config, &opt)?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:230:13
[INFO] [stderr]     |
[INFO] [stderr] 230 |             let _ = output(&mut *reader, writer.get_mut(), use_color, &config, &opt)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/colorize.rs:123:18
[INFO] [stderr]     |
[INFO] [stderr] 123 | fn conv_color(s: &Option<&String>) -> Result<Box<Color>> {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&String>`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/colorize.rs:124:27
[INFO] [stderr]     |
[INFO] [stderr] 124 |       let ret: Box<Color> = if let &Some(ref s) = s {
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 125 | |         match s.as_ref() {
[INFO] [stderr] 126 | |             "Black" => Box::new(color::Black),
[INFO] [stderr] 127 | |             "Blue" => Box::new(color::Blue),
[INFO] [stderr] ...   |
[INFO] [stderr] 148 | |         Box::new(color::Reset)
[INFO] [stderr] 149 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 124 |     let ret: Box<Color> = if let Some(ref s) = *s {
[INFO] [stderr]     |                                  ^^^^^^^^^^^   ^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/read_timeout.rs:34:54
[INFO] [stderr]    |
[INFO] [stderr] 34 |                     buf.extend_from_slice(&available[..i + 1]);
[INFO] [stderr]    |                                                      ^^^^^^^ help: use: `..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:223:9
[INFO] [stderr]     |
[INFO] [stderr] 223 |         let _ = output(&mut *reader, writer.get_mut(), use_color, &config, &opt)?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 |         let _ = output(&mut *reader, writer.get_mut(), use_color, &config, &opt)?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:230:13
[INFO] [stderr]     |
[INFO] [stderr] 230 |             let _ = output(&mut *reader, writer.get_mut(), use_color, &config, &opt)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.66s
[INFO] running `"docker" "inspect" "b08e942a8ce3b076970221ed14643d465b018c25c1bf34f12daf33dadb517f55"`
[INFO] running `"docker" "rm" "-f" "b08e942a8ce3b076970221ed14643d465b018c25c1bf34f12daf33dadb517f55"`
[INFO] [stdout] b08e942a8ce3b076970221ed14643d465b018c25c1bf34f12daf33dadb517f55