[INFO] crate pipe-logger-lib 1.1.5 is already in cache [INFO] extracting crate pipe-logger-lib 1.1.5 into work/ex/clippy-test-run/sources/stable/reg/pipe-logger-lib/1.1.5 [INFO] extracting crate pipe-logger-lib 1.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pipe-logger-lib/1.1.5 [INFO] validating manifest of pipe-logger-lib-1.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pipe-logger-lib-1.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pipe-logger-lib-1.1.5 [INFO] finished frobbing pipe-logger-lib-1.1.5 [INFO] frobbed toml for pipe-logger-lib-1.1.5 written to work/ex/clippy-test-run/sources/stable/reg/pipe-logger-lib/1.1.5/Cargo.toml [INFO] started frobbing pipe-logger-lib-1.1.5 [INFO] finished frobbing pipe-logger-lib-1.1.5 [INFO] frobbed toml for pipe-logger-lib-1.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pipe-logger-lib/1.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pipe-logger-lib-1.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pipe-logger-lib/1.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d361b1c81c25ddfbdbe867a611b16cfa3b8e9d481cdcddb1a6fd12d61631dd9b [INFO] running `"docker" "start" "-a" "d361b1c81c25ddfbdbe867a611b16cfa3b8e9d481cdcddb1a6fd12d61631dd9b"` [INFO] [stderr] Checking pipe-logger-lib v1.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:205:69 [INFO] [stderr] | [INFO] [stderr] 205 | let file_path = self.log_path.as_ref().absolutize().map_err(|err| PipeLoggerBuilderError::IOError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PipeLoggerBuilderError::IOError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:269:59 [INFO] [stderr] | [INFO] [stderr] 269 | let file_name_point_index = match file_name.rfind(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:298:91 [INFO] [stderr] | [INFO] [stderr] 298 | let rotated_log_file_name_point_index = match rotated_log_file_name.rfind(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:335:39 [INFO] [stderr] | [INFO] [stderr] 335 | .open(&file_path).map_err(|err| PipeLoggerBuilderError::IOError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PipeLoggerBuilderError::IOError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:489:72 [INFO] [stderr] | [INFO] [stderr] 489 | if let Err(_) = fs::remove_file(&rotated_log_file) {} [INFO] [stderr] | -------^^^^^^---------------------------------------- help: try this: `if fs::remove_file(&rotated_log_file).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:507:68 [INFO] [stderr] | [INFO] [stderr] 507 | if let Err(_) = fs::remove_file(&rotated_log_file_compressed) {} [INFO] [stderr] | -------^^^^^^--------------------------------------------------- help: try this: `if fs::remove_file(&rotated_log_file_compressed).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:519:56 [INFO] [stderr] | [INFO] [stderr] 519 | if let Err(_) = fs::remove_file(&rotated_log_file_compressed) {} [INFO] [stderr] | -------^^^^^^--------------------------------------------------- help: try this: `if fs::remove_file(&rotated_log_file_compressed).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:538:40 [INFO] [stderr] | [INFO] [stderr] 538 | if let Err(_) = fs::remove_file(Path::join(&self.folder_path, Path::new(&rotated_log_file_name))) {} [INFO] [stderr] | -------^^^^^^--------------------------------------------------------------------------------------- help: try this: `if fs::remove_file(Path::join(&self.folder_path, Path::new(&rotated_log_file_name))).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:547:40 [INFO] [stderr] | [INFO] [stderr] 547 | if let Err(_) = fs::remove_file(&p_compressed) {} [INFO] [stderr] | -------^^^^^^------------------------------------ help: try this: `if fs::remove_file(&p_compressed).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:205:69 [INFO] [stderr] | [INFO] [stderr] 205 | let file_path = self.log_path.as_ref().absolutize().map_err(|err| PipeLoggerBuilderError::IOError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PipeLoggerBuilderError::IOError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:269:59 [INFO] [stderr] | [INFO] [stderr] 269 | let file_name_point_index = match file_name.rfind(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:298:91 [INFO] [stderr] | [INFO] [stderr] 298 | let rotated_log_file_name_point_index = match rotated_log_file_name.rfind(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:335:39 [INFO] [stderr] | [INFO] [stderr] 335 | .open(&file_path).map_err(|err| PipeLoggerBuilderError::IOError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PipeLoggerBuilderError::IOError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:489:72 [INFO] [stderr] | [INFO] [stderr] 489 | if let Err(_) = fs::remove_file(&rotated_log_file) {} [INFO] [stderr] | -------^^^^^^---------------------------------------- help: try this: `if fs::remove_file(&rotated_log_file).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:507:68 [INFO] [stderr] | [INFO] [stderr] 507 | if let Err(_) = fs::remove_file(&rotated_log_file_compressed) {} [INFO] [stderr] | -------^^^^^^--------------------------------------------------- help: try this: `if fs::remove_file(&rotated_log_file_compressed).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:519:56 [INFO] [stderr] | [INFO] [stderr] 519 | if let Err(_) = fs::remove_file(&rotated_log_file_compressed) {} [INFO] [stderr] | -------^^^^^^--------------------------------------------------- help: try this: `if fs::remove_file(&rotated_log_file_compressed).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:538:40 [INFO] [stderr] | [INFO] [stderr] 538 | if let Err(_) = fs::remove_file(Path::join(&self.folder_path, Path::new(&rotated_log_file_name))) {} [INFO] [stderr] | -------^^^^^^--------------------------------------------------------------------------------------- help: try this: `if fs::remove_file(Path::join(&self.folder_path, Path::new(&rotated_log_file_name))).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:547:40 [INFO] [stderr] | [INFO] [stderr] 547 | if let Err(_) = fs::remove_file(&p_compressed) {} [INFO] [stderr] | -------^^^^^^------------------------------------ help: try this: `if fs::remove_file(&p_compressed).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.83s [INFO] running `"docker" "inspect" "d361b1c81c25ddfbdbe867a611b16cfa3b8e9d481cdcddb1a6fd12d61631dd9b"` [INFO] running `"docker" "rm" "-f" "d361b1c81c25ddfbdbe867a611b16cfa3b8e9d481cdcddb1a6fd12d61631dd9b"` [INFO] [stdout] d361b1c81c25ddfbdbe867a611b16cfa3b8e9d481cdcddb1a6fd12d61631dd9b