[INFO] crate pipe-channel 1.2.2 is already in cache [INFO] extracting crate pipe-channel 1.2.2 into work/ex/clippy-test-run/sources/stable/reg/pipe-channel/1.2.2 [INFO] extracting crate pipe-channel 1.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pipe-channel/1.2.2 [INFO] validating manifest of pipe-channel-1.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pipe-channel-1.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pipe-channel-1.2.2 [INFO] finished frobbing pipe-channel-1.2.2 [INFO] frobbed toml for pipe-channel-1.2.2 written to work/ex/clippy-test-run/sources/stable/reg/pipe-channel/1.2.2/Cargo.toml [INFO] started frobbing pipe-channel-1.2.2 [INFO] finished frobbing pipe-channel-1.2.2 [INFO] frobbed toml for pipe-channel-1.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pipe-channel/1.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pipe-channel-1.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pipe-channel/1.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d24e0e70708d2331604a4d0655dab3472e80641c54de6057127e547651940b8e [INFO] running `"docker" "start" "-a" "d24e0e70708d2331604a4d0655dab3472e80641c54de6057127e547651940b8e"` [INFO] [stderr] Checking pipe-channel v1.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | / let mut s: &[u8] = &[0]; [INFO] [stderr] 217 | | if mem::size_of::() > 0 { [INFO] [stderr] 218 | | // TODO: once constexpr is stable, change this to [INFO] [stderr] 219 | | // let mut s: [u8; mem::size_of::()] = mem::transmute(t); [INFO] [stderr] ... | [INFO] [stderr] 222 | | }; [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 216 | let s = if mem::size_of::() > 0 { unsafe { [INFO] [stderr] 217 | slice::from_raw_parts(&t as *const T as *const u8, mem::size_of::()) [INFO] [stderr] 218 | } } else { &[0] }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | / let mut s: &[u8] = &[0]; [INFO] [stderr] 217 | | if mem::size_of::() > 0 { [INFO] [stderr] 218 | | // TODO: once constexpr is stable, change this to [INFO] [stderr] 219 | | // let mut s: [u8; mem::size_of::()] = mem::transmute(t); [INFO] [stderr] ... | [INFO] [stderr] 222 | | }; [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 216 | let s = if mem::size_of::() > 0 { unsafe { [INFO] [stderr] 217 | slice::from_raw_parts(&t as *const T as *const u8, mem::size_of::()) [INFO] [stderr] 218 | } } else { &[0] }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `res` [INFO] [stderr] --> src/lib.rs:502:26 [INFO] [stderr] | [INFO] [stderr] 502 | for i in 0..(res.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 502 | for (i, ) in res.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.89s [INFO] running `"docker" "inspect" "d24e0e70708d2331604a4d0655dab3472e80641c54de6057127e547651940b8e"` [INFO] running `"docker" "rm" "-f" "d24e0e70708d2331604a4d0655dab3472e80641c54de6057127e547651940b8e"` [INFO] [stdout] d24e0e70708d2331604a4d0655dab3472e80641c54de6057127e547651940b8e