[INFO] crate pidlock 0.1.2 is already in cache [INFO] extracting crate pidlock 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/pidlock/0.1.2 [INFO] extracting crate pidlock 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pidlock/0.1.2 [INFO] validating manifest of pidlock-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pidlock-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pidlock-0.1.2 [INFO] finished frobbing pidlock-0.1.2 [INFO] frobbed toml for pidlock-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/pidlock/0.1.2/Cargo.toml [INFO] started frobbing pidlock-0.1.2 [INFO] finished frobbing pidlock-0.1.2 [INFO] frobbed toml for pidlock-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pidlock/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pidlock-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pidlock/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0ad41f2858f224d688d5e6d44d49791445b268da7b4c9f6dca298ab917dc12f [INFO] running `"docker" "start" "-a" "f0ad41f2858f224d688d5e6d44d49791445b268da7b4c9f6dca298ab917dc12f"` [INFO] [stderr] Checking pidlock v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match fs::OpenOptions::new().read(true).open(self.path.clone()) { [INFO] [stderr] 54 | | Ok(mut file) => { [INFO] [stderr] 55 | | let mut contents = String::new(); [INFO] [stderr] 56 | | file.read_to_string(&mut contents).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 68 | | Err(_) => {} [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | if let Ok(mut file) = fs::OpenOptions::new().read(true).open(self.path.clone()) { [INFO] [stderr] 54 | let mut contents = String::new(); [INFO] [stderr] 55 | file.read_to_string(&mut contents).unwrap(); [INFO] [stderr] 56 | [INFO] [stderr] 57 | match contents.trim().parse::() { [INFO] [stderr] 58 | Ok(pid) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match fs::OpenOptions::new().read(true).open(self.path.clone()) { [INFO] [stderr] 54 | | Ok(mut file) => { [INFO] [stderr] 55 | | let mut contents = String::new(); [INFO] [stderr] 56 | | file.read_to_string(&mut contents).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 68 | | Err(_) => {} [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | if let Ok(mut file) = fs::OpenOptions::new().read(true).open(self.path.clone()) { [INFO] [stderr] 54 | let mut contents = String::new(); [INFO] [stderr] 55 | file.read_to_string(&mut contents).unwrap(); [INFO] [stderr] 56 | [INFO] [stderr] 57 | match contents.trim().parse::() { [INFO] [stderr] 58 | Ok(pid) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "f0ad41f2858f224d688d5e6d44d49791445b268da7b4c9f6dca298ab917dc12f"` [INFO] running `"docker" "rm" "-f" "f0ad41f2858f224d688d5e6d44d49791445b268da7b4c9f6dca298ab917dc12f"` [INFO] [stdout] f0ad41f2858f224d688d5e6d44d49791445b268da7b4c9f6dca298ab917dc12f