[INFO] crate pidgin 0.2.0 is already in cache
[INFO] extracting crate pidgin 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/pidgin/0.2.0
[INFO] extracting crate pidgin 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pidgin/0.2.0
[INFO] validating manifest of pidgin-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pidgin-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pidgin-0.2.0
[INFO] finished frobbing pidgin-0.2.0
[INFO] frobbed toml for pidgin-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/pidgin/0.2.0/Cargo.toml
[INFO] started frobbing pidgin-0.2.0
[INFO] finished frobbing pidgin-0.2.0
[INFO] frobbed toml for pidgin-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pidgin/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pidgin-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pidgin/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 77e13442c584a3b2a65574213d06b662c7e31ed04da9a2d5ce5563cda765f388
[INFO] running `"docker" "start" "-a" "77e13442c584a3b2a65574213d06b662c7e31ed04da9a2d5ce5563cda765f388"`
[INFO] [stderr]     Checking pidgin v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pidgin.rs:606:13
[INFO] [stderr]     |
[INFO] [stderr] 606 |             return v;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pidgin.rs:608:13
[INFO] [stderr]     |
[INFO] [stderr] 608 |             return phrases;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: remove `return` as shown: `phrases`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pidgin.rs:606:13
[INFO] [stderr]     |
[INFO] [stderr] 606 |             return v;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pidgin.rs:608:13
[INFO] [stderr]     |
[INFO] [stderr] 608 |             return phrases;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: remove `return` as shown: `phrases`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/grammar.rs:75:30
[INFO] [stderr]    |
[INFO] [stderr] 75 |                 upper_limit: self.upper_limit.clone(),
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.upper_limit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/grammar.rs:99:34
[INFO] [stderr]    |
[INFO] [stderr] 99 |                     lower_limit: self.lower_limit.clone(),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lower_limit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/grammar.rs:189:9
[INFO] [stderr]     |
[INFO] [stderr] 189 | /         loop {
[INFO] [stderr] 190 | |             if let Some(e) = expressions.pop_front() {
[INFO] [stderr] 191 | |                 match e {
[INFO] [stderr] 192 | |                     Expression::Grammar(ref g, _) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 212 | |             }
[INFO] [stderr] 213 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(e) = expressions.pop_front() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/grammar.rs:284:26
[INFO] [stderr]     |
[INFO] [stderr] 284 |             upper_limit: self.upper_limit.clone(),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.upper_limit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/grammar.rs:285:26
[INFO] [stderr]     |
[INFO] [stderr] 285 |             lower_limit: self.lower_limit.clone(),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lower_limit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/grammar.rs:348:12
[INFO] [stderr]     |
[INFO] [stderr] 348 |         if flags_on.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!flags_on.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/grammar.rs:351:12
[INFO] [stderr]     |
[INFO] [stderr] 351 |         if flags_off.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!flags_off.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/grammar.rs:365:13
[INFO] [stderr]     |
[INFO] [stderr] 365 |             s = s + format!("(?{}:", self.flags(context)).as_str();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s += format!("(?{}:", self.flags(context)).as_str()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/grammar.rs:371:13
[INFO] [stderr]     |
[INFO] [stderr] 371 |             s = s + ")"
[INFO] [stderr]     |             ^^^^^^^^^^^ help: replace it with: `s += ")"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/grammar.rs:374:13
[INFO] [stderr]     |
[INFO] [stderr] 374 |             s = s + ")"
[INFO] [stderr]     |             ^^^^^^^^^^^ help: replace it with: `s += ")"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/macros.rs:801:37
[INFO] [stderr]     |
[INFO] [stderr] 801 |                         let mut g = compiled.get(g).unwrap().clone();
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&compiled[g]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/macros.rs:833:56
[INFO] [stderr]     |
[INFO] [stderr] 833 |                         let mut g = pidgin.clone().add(&vec![s.as_str()]).compile_bounded(
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[s.as_str()]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/macros.rs:881:11
[INFO] [stderr]     |
[INFO] [stderr] 881 |     while rules.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rules.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/macros.rs:900:12
[INFO] [stderr]     |
[INFO] [stderr] 900 |         if added.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `added.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]     --> src/macros.rs:1007:25
[INFO] [stderr]      |
[INFO] [stderr] 1007 |         for (s, dir) in vec![(on, true), (off, false)] {
[INFO] [stderr]      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[(on, true), (off, false)]`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]     --> src/macros.rs:1123:17
[INFO] [stderr]      |
[INFO] [stderr] 1123 |             (if off_parts.len() > 0 { "-" } else { "" }),
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!off_parts.is_empty()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/matching.rs:81:18
[INFO] [stderr]    |
[INFO] [stderr] 81 |     fn sort_tree<'t>(&self, m: &mut Match) {
[INFO] [stderr]    |                  ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/matching.rs:142:32
[INFO] [stderr]     |
[INFO] [stderr] 142 |                     let name = self.translation.get(c).unwrap();
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.translation[c]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/matching.rs:151:51
[INFO] [stderr]     |
[INFO] [stderr] 151 |                     m.children.get_or_insert_with(|| Vec::new()).push(child);
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/matching.rs:160:35
[INFO] [stderr]     |
[INFO] [stderr] 160 |         let root = g.name.clone().unwrap_or(String::from("0"));
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("0"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/matching.rs:207:41
[INFO] [stderr]     |
[INFO] [stderr] 207 |                         .or_insert_with(|| Vec::new())
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/matching.rs:214:25
[INFO] [stderr]     |
[INFO] [stderr] 214 |                     for ref mut e in &mut g.sequence {
[INFO] [stderr]     |                         ^^^^^^^^^    --------------- help: try: `let e = &mut &mut g.sequence;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:169:20
[INFO] [stderr]     |
[INFO] [stderr] 169 |                 if phrase.len() > 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!phrase.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:189:20
[INFO] [stderr]     |
[INFO] [stderr] 189 |                 if phrase.len() > 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!phrase.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:246:44
[INFO] [stderr]     |
[INFO] [stderr] 246 |                                         if s.len() > 0 {
[INFO] [stderr]     |                                            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:285:23
[INFO] [stderr]     |
[INFO] [stderr] 285 |                 while nv.len() > 0 {
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!nv.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:436:12
[INFO] [stderr]     |
[INFO] [stderr] 436 |         if phrases.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `phrases.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:449:16
[INFO] [stderr]     |
[INFO] [stderr] 449 |             if phrase.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `phrase.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pidgin.rs:453:37
[INFO] [stderr]     |
[INFO] [stderr] 453 |                     .or_insert_with(|| Vec::new())
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/pidgin.rs:476:20
[INFO] [stderr]     |
[INFO] [stderr] 476 |     fn vec_sort(a: &Vec<Expression>, b: &Vec<Expression>) -> Ordering {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: change this to: `&[Expression]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/pidgin.rs:476:41
[INFO] [stderr]     |
[INFO] [stderr] 476 |     fn vec_sort(a: &Vec<Expression>, b: &Vec<Expression>) -> Ordering {
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^ help: change this to: `&[Expression]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `phrases`.
[INFO] [stderr]    --> src/pidgin.rs:521:22
[INFO] [stderr]     |
[INFO] [stderr] 521 |             for i in 0..phrases.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 521 |             for <item> in &mut phrases {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:528:16
[INFO] [stderr]     |
[INFO] [stderr] 528 |             if phrases[0].len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `phrases[0].is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/pidgin.rs:529:21
[INFO] [stderr]     |
[INFO] [stderr] 529 |                 for ref mut v in phrases {
[INFO] [stderr]     |                     ^^^^^^^^^    ------- help: try: `let v = &mut phrases;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/pidgin.rs:541:17
[INFO] [stderr]     |
[INFO] [stderr] 541 |                 &phrases[0].len() - i - 1
[INFO] [stderr]     |                 -----------------^^^^
[INFO] [stderr]     |                 |
[INFO] [stderr]     |                 help: use the left value directly: `phrases[0].len()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `phrases`.
[INFO] [stderr]    --> src/pidgin.rs:566:22
[INFO] [stderr]     |
[INFO] [stderr] 566 |             for i in 0..phrases.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 566 |             for <item> in &mut phrases {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/util.rs:225:35
[INFO] [stderr]     |
[INFO] [stderr] 225 |               &Symbol::S(ref s1) => match other {
[INFO] [stderr]     |  ___________________________________^
[INFO] [stderr] 226 | |                 &Symbol::S(ref s2) => {
[INFO] [stderr] 227 | |                     let o = s2.len().cmp(&s1.len());
[INFO] [stderr] 228 | |                     if o != Ordering::Equal {
[INFO] [stderr] ...   |
[INFO] [stderr] 234 | |                 _ => Ordering::Less,
[INFO] [stderr] 235 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 225 |             &Symbol::S(ref s1) => match *other {
[INFO] [stderr] 226 |                 Symbol::S(ref s2) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/util.rs:406:42
[INFO] [stderr]     |
[INFO] [stderr] 406 |               &Expression::Char(c1, b1) => match other {
[INFO] [stderr]     |  __________________________________________^
[INFO] [stderr] 407 | |                 &Expression::Char(c2, b2) => match c1.cmp(&c2) {
[INFO] [stderr] 408 | |                     Ordering::Less => Ordering::Less,
[INFO] [stderr] 409 | |                     Ordering::Greater => Ordering::Greater,
[INFO] [stderr] ...   |
[INFO] [stderr] 412 | |                 _ => Ordering::Less,
[INFO] [stderr] 413 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 406 |             &Expression::Char(c1, b1) => match *other {
[INFO] [stderr] 407 |                 Expression::Char(c2, b2) => match c1.cmp(&c2) {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/grammar.rs:75:30
[INFO] [stderr]    |
[INFO] [stderr] 75 |                 upper_limit: self.upper_limit.clone(),
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.upper_limit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/grammar.rs:99:34
[INFO] [stderr]    |
[INFO] [stderr] 99 |                     lower_limit: self.lower_limit.clone(),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lower_limit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/grammar.rs:189:9
[INFO] [stderr]     |
[INFO] [stderr] 189 | /         loop {
[INFO] [stderr] 190 | |             if let Some(e) = expressions.pop_front() {
[INFO] [stderr] 191 | |                 match e {
[INFO] [stderr] 192 | |                     Expression::Grammar(ref g, _) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 212 | |             }
[INFO] [stderr] 213 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(e) = expressions.pop_front() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/grammar.rs:284:26
[INFO] [stderr]     |
[INFO] [stderr] 284 |             upper_limit: self.upper_limit.clone(),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.upper_limit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/grammar.rs:285:26
[INFO] [stderr]     |
[INFO] [stderr] 285 |             lower_limit: self.lower_limit.clone(),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lower_limit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/grammar.rs:348:12
[INFO] [stderr]     |
[INFO] [stderr] 348 |         if flags_on.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!flags_on.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/grammar.rs:351:12
[INFO] [stderr]     |
[INFO] [stderr] 351 |         if flags_off.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!flags_off.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/grammar.rs:365:13
[INFO] [stderr]     |
[INFO] [stderr] 365 |             s = s + format!("(?{}:", self.flags(context)).as_str();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s += format!("(?{}:", self.flags(context)).as_str()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/grammar.rs:371:13
[INFO] [stderr]     |
[INFO] [stderr] 371 |             s = s + ")"
[INFO] [stderr]     |             ^^^^^^^^^^^ help: replace it with: `s += ")"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/grammar.rs:374:13
[INFO] [stderr]     |
[INFO] [stderr] 374 |             s = s + ")"
[INFO] [stderr]     |             ^^^^^^^^^^^ help: replace it with: `s += ")"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/macros.rs:801:37
[INFO] [stderr]     |
[INFO] [stderr] 801 |                         let mut g = compiled.get(g).unwrap().clone();
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&compiled[g]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/macros.rs:833:56
[INFO] [stderr]     |
[INFO] [stderr] 833 |                         let mut g = pidgin.clone().add(&vec![s.as_str()]).compile_bounded(
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[s.as_str()]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/macros.rs:881:11
[INFO] [stderr]     |
[INFO] [stderr] 881 |     while rules.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rules.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/macros.rs:900:12
[INFO] [stderr]     |
[INFO] [stderr] 900 |         if added.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `added.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]     --> src/macros.rs:1007:25
[INFO] [stderr]      |
[INFO] [stderr] 1007 |         for (s, dir) in vec![(on, true), (off, false)] {
[INFO] [stderr]      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[(on, true), (off, false)]`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]     --> src/macros.rs:1123:17
[INFO] [stderr]      |
[INFO] [stderr] 1123 |             (if off_parts.len() > 0 { "-" } else { "" }),
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!off_parts.is_empty()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/matching.rs:81:18
[INFO] [stderr]    |
[INFO] [stderr] 81 |     fn sort_tree<'t>(&self, m: &mut Match) {
[INFO] [stderr]    |                  ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/matching.rs:142:32
[INFO] [stderr]     |
[INFO] [stderr] 142 |                     let name = self.translation.get(c).unwrap();
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.translation[c]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/matching.rs:151:51
[INFO] [stderr]     |
[INFO] [stderr] 151 |                     m.children.get_or_insert_with(|| Vec::new()).push(child);
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/matching.rs:160:35
[INFO] [stderr]     |
[INFO] [stderr] 160 |         let root = g.name.clone().unwrap_or(String::from("0"));
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("0"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/matching.rs:207:41
[INFO] [stderr]     |
[INFO] [stderr] 207 |                         .or_insert_with(|| Vec::new())
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/matching.rs:214:25
[INFO] [stderr]     |
[INFO] [stderr] 214 |                     for ref mut e in &mut g.sequence {
[INFO] [stderr]     |                         ^^^^^^^^^    --------------- help: try: `let e = &mut &mut g.sequence;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:169:20
[INFO] [stderr]     |
[INFO] [stderr] 169 |                 if phrase.len() > 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!phrase.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:189:20
[INFO] [stderr]     |
[INFO] [stderr] 189 |                 if phrase.len() > 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!phrase.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:246:44
[INFO] [stderr]     |
[INFO] [stderr] 246 |                                         if s.len() > 0 {
[INFO] [stderr]     |                                            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:285:23
[INFO] [stderr]     |
[INFO] [stderr] 285 |                 while nv.len() > 0 {
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!nv.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:436:12
[INFO] [stderr]     |
[INFO] [stderr] 436 |         if phrases.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `phrases.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:449:16
[INFO] [stderr]     |
[INFO] [stderr] 449 |             if phrase.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `phrase.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pidgin.rs:453:37
[INFO] [stderr]     |
[INFO] [stderr] 453 |                     .or_insert_with(|| Vec::new())
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/pidgin.rs:476:20
[INFO] [stderr]     |
[INFO] [stderr] 476 |     fn vec_sort(a: &Vec<Expression>, b: &Vec<Expression>) -> Ordering {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: change this to: `&[Expression]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/pidgin.rs:476:41
[INFO] [stderr]     |
[INFO] [stderr] 476 |     fn vec_sort(a: &Vec<Expression>, b: &Vec<Expression>) -> Ordering {
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^ help: change this to: `&[Expression]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `phrases`.
[INFO] [stderr]    --> src/pidgin.rs:521:22
[INFO] [stderr]     |
[INFO] [stderr] 521 |             for i in 0..phrases.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 521 |             for <item> in &mut phrases {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pidgin.rs:528:16
[INFO] [stderr]     |
[INFO] [stderr] 528 |             if phrases[0].len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `phrases[0].is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/pidgin.rs:529:21
[INFO] [stderr]     |
[INFO] [stderr] 529 |                 for ref mut v in phrases {
[INFO] [stderr]     |                     ^^^^^^^^^    ------- help: try: `let v = &mut phrases;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/pidgin.rs:541:17
[INFO] [stderr]     |
[INFO] [stderr] 541 |                 &phrases[0].len() - i - 1
[INFO] [stderr]     |                 -----------------^^^^
[INFO] [stderr]     |                 |
[INFO] [stderr]     |                 help: use the left value directly: `phrases[0].len()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `phrases`.
[INFO] [stderr]    --> src/pidgin.rs:566:22
[INFO] [stderr]     |
[INFO] [stderr] 566 |             for i in 0..phrases.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 566 |             for <item> in &mut phrases {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/util.rs:225:35
[INFO] [stderr]     |
[INFO] [stderr] 225 |               &Symbol::S(ref s1) => match other {
[INFO] [stderr]     |  ___________________________________^
[INFO] [stderr] 226 | |                 &Symbol::S(ref s2) => {
[INFO] [stderr] 227 | |                     let o = s2.len().cmp(&s1.len());
[INFO] [stderr] 228 | |                     if o != Ordering::Equal {
[INFO] [stderr] ...   |
[INFO] [stderr] 234 | |                 _ => Ordering::Less,
[INFO] [stderr] 235 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 225 |             &Symbol::S(ref s1) => match *other {
[INFO] [stderr] 226 |                 Symbol::S(ref s2) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/util.rs:406:42
[INFO] [stderr]     |
[INFO] [stderr] 406 |               &Expression::Char(c1, b1) => match other {
[INFO] [stderr]     |  __________________________________________^
[INFO] [stderr] 407 | |                 &Expression::Char(c2, b2) => match c1.cmp(&c2) {
[INFO] [stderr] 408 | |                     Ordering::Less => Ordering::Less,
[INFO] [stderr] 409 | |                     Ordering::Greater => Ordering::Greater,
[INFO] [stderr] ...   |
[INFO] [stderr] 412 | |                 _ => Ordering::Less,
[INFO] [stderr] 413 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 406 |             &Expression::Char(c1, b1) => match *other {
[INFO] [stderr] 407 |                 Expression::Char(c2, b2) => match c1.cmp(&c2) {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel
[INFO] [stderr]  --> tests/macro.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![feature(test)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] For more information about this error, try `rustc --explain E0554`.
[INFO] [stderr] error: Could not compile `pidgin`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> benches/regex_comparison.rs:61:42
[INFO] [stderr]    |
[INFO] [stderr] 61 |       static ref PIDGIN_RX_BOUNDED: Regex =grammar!{
[INFO] [stderr]    |  __________________________________________^
[INFO] [stderr] 62 | |         TOP => r(r"\A") [&GOOD] r(r"\z")
[INFO] [stderr] 63 | |     }.rx().unwrap();
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> benches/regex_comparison.rs:72:45
[INFO] [stderr]    |
[INFO] [stderr] 72 |       static ref PIDGIN_RX_UNBOUNDED: Regex = grammar!{
[INFO] [stderr]    |  _____________________________________________^
[INFO] [stderr] 73 | |         TOP => [&GOOD]
[INFO] [stderr] 74 | |     }.rx().unwrap();
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> benches/regex_comparison.rs:80:17
[INFO] [stderr]    |
[INFO] [stderr] 80 |             for ref w in GOOD.iter() {
[INFO] [stderr]    |                 ^^^^^    ----------- help: try: `let w = &GOOD.iter();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> benches/regex_comparison.rs:87:17
[INFO] [stderr]    |
[INFO] [stderr] 87 |             for ref w in GOOD.iter() {
[INFO] [stderr]    |                 ^^^^^    ----------- help: try: `let w = &GOOD.iter();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> benches/regex_comparison.rs:94:17
[INFO] [stderr]    |
[INFO] [stderr] 94 |             for ref w in BAD.iter() {
[INFO] [stderr]    |                 ^^^^^    ---------- help: try: `let w = &BAD.iter();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> benches/regex_comparison.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |             for ref w in BAD.iter() {
[INFO] [stderr]     |                 ^^^^^    ---------- help: try: `let w = &BAD.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> benches/regex_comparison.rs:108:17
[INFO] [stderr]     |
[INFO] [stderr] 108 |             for ref w in GOOD.iter() {
[INFO] [stderr]     |                 ^^^^^    ----------- help: try: `let w = &GOOD.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> benches/regex_comparison.rs:115:17
[INFO] [stderr]     |
[INFO] [stderr] 115 |             for ref w in GOOD.iter() {
[INFO] [stderr]     |                 ^^^^^    ----------- help: try: `let w = &GOOD.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> benches/regex_comparison.rs:122:17
[INFO] [stderr]     |
[INFO] [stderr] 122 |             for ref w in BAD.iter() {
[INFO] [stderr]     |                 ^^^^^    ---------- help: try: `let w = &BAD.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> benches/regex_comparison.rs:129:17
[INFO] [stderr]     |
[INFO] [stderr] 129 |             for ref w in BAD.iter() {
[INFO] [stderr]     |                 ^^^^^    ---------- help: try: `let w = &BAD.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "77e13442c584a3b2a65574213d06b662c7e31ed04da9a2d5ce5563cda765f388"`
[INFO] running `"docker" "rm" "-f" "77e13442c584a3b2a65574213d06b662c7e31ed04da9a2d5ce5563cda765f388"`
[INFO] [stdout] 77e13442c584a3b2a65574213d06b662c7e31ed04da9a2d5ce5563cda765f388