[INFO] crate pictors 0.1.1 is already in cache [INFO] extracting crate pictors 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/pictors/0.1.1 [INFO] extracting crate pictors 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pictors/0.1.1 [INFO] validating manifest of pictors-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pictors-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pictors-0.1.1 [INFO] finished frobbing pictors-0.1.1 [INFO] frobbed toml for pictors-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/pictors/0.1.1/Cargo.toml [INFO] started frobbing pictors-0.1.1 [INFO] finished frobbing pictors-0.1.1 [INFO] frobbed toml for pictors-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pictors/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pictors-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pictors/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69ac7658d7c2a4e3500bc83323e23f1994537864fbc380171cc2779f3f448895 [INFO] running `"docker" "start" "-a" "69ac7658d7c2a4e3500bc83323e23f1994537864fbc380171cc2779f3f448895"` [INFO] [stderr] Checking pictors v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | fstream [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | let fstream = match std::fs::OpenOptions::new() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 75 | | .create(true) [INFO] [stderr] 76 | | .write(true) [INFO] [stderr] 77 | | .open(output_file) [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | fstream [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | let fstream = match std::fs::OpenOptions::new() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 75 | | .create(true) [INFO] [stderr] 76 | | .write(true) [INFO] [stderr] 77 | | .open(output_file) [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | / match $x { [INFO] [stderr] 9 | | Ok(x) => x, [INFO] [stderr] 10 | | Err(e) => { [INFO] [stderr] 11 | | eprintln!("Error: {}", e); [INFO] [stderr] 12 | | std::process::exit(1); [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 110 | check_and_exit!(ofstream.write(next_formatted.as_bytes())); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pictors`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | / match $x { [INFO] [stderr] 9 | | Ok(x) => x, [INFO] [stderr] 10 | | Err(e) => { [INFO] [stderr] 11 | | eprintln!("Error: {}", e); [INFO] [stderr] 12 | | std::process::exit(1); [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 110 | check_and_exit!(ofstream.write(next_formatted.as_bytes())); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pictors`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "69ac7658d7c2a4e3500bc83323e23f1994537864fbc380171cc2779f3f448895"` [INFO] running `"docker" "rm" "-f" "69ac7658d7c2a4e3500bc83323e23f1994537864fbc380171cc2779f3f448895"` [INFO] [stdout] 69ac7658d7c2a4e3500bc83323e23f1994537864fbc380171cc2779f3f448895