[INFO] crate picto 0.4.3 is already in cache [INFO] extracting crate picto 0.4.3 into work/ex/clippy-test-run/sources/stable/reg/picto/0.4.3 [INFO] extracting crate picto 0.4.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/picto/0.4.3 [INFO] validating manifest of picto-0.4.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of picto-0.4.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing picto-0.4.3 [INFO] finished frobbing picto-0.4.3 [INFO] frobbed toml for picto-0.4.3 written to work/ex/clippy-test-run/sources/stable/reg/picto/0.4.3/Cargo.toml [INFO] started frobbing picto-0.4.3 [INFO] finished frobbing picto-0.4.3 [INFO] frobbed toml for picto-0.4.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/picto/0.4.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting picto-0.4.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/picto/0.4.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5b0c7ee8f60131f5ad61dd7c453bd45c8eb6b4a504a6a1e8be5e22622731785 [INFO] running `"docker" "start" "-a" "d5b0c7ee8f60131f5ad61dd7c453bd45c8eb6b4a504a6a1e8be5e22622731785"` [INFO] [stderr] Checking exoquant v0.2.0 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking imagefmt v4.0.0 [INFO] [stderr] Checking xyz v0.2.1 [INFO] [stderr] Compiling palette v0.2.1 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking picto v0.4.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:38:4 [INFO] [stderr] | [INFO] [stderr] 38 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:104:4 [INFO] [stderr] | [INFO] [stderr] 104 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:105:4 [INFO] [stderr] | [INFO] [stderr] 105 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:107:4 [INFO] [stderr] | [INFO] [stderr] 107 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:108:4 [INFO] [stderr] | [INFO] [stderr] 108 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/buffer.rs:223:4 [INFO] [stderr] | [INFO] [stderr] 223 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/view.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/view.rs:57:4 [INFO] [stderr] | [INFO] [stderr] 57 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/view.rs:59:4 [INFO] [stderr] | [INFO] [stderr] 59 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/view.rs:60:4 [INFO] [stderr] | [INFO] [stderr] 60 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/read.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/read.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/read.rs:58:4 [INFO] [stderr] | [INFO] [stderr] 58 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/read.rs:59:4 [INFO] [stderr] | [INFO] [stderr] 59 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/write.rs:50:4 [INFO] [stderr] | [INFO] [stderr] 50 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/write.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/write.rs:53:4 [INFO] [stderr] | [INFO] [stderr] 53 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/write.rs:54:4 [INFO] [stderr] | [INFO] [stderr] 54 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/coordinates.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/immutable.rs:45:4 [INFO] [stderr] | [INFO] [stderr] 45 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/immutable.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/immutable.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/immutable.rs:77:4 [INFO] [stderr] | [INFO] [stderr] 77 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/mutable.rs:46:4 [INFO] [stderr] | [INFO] [stderr] 46 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/mutable.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/mutable.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/mutable.rs:78:4 [INFO] [stderr] | [INFO] [stderr] 78 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/processing/sampler/cubic.rs:34:6 [INFO] [stderr] | [INFO] [stderr] 34 | let k = if a < one!() { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | let (r, g, b, a, Y) = sample(input, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | let (r, g, b, a, Y) = sample(input, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:116:15 [INFO] [stderr] | [INFO] [stderr] 116 | let (r, g, b, a, Y) = sample(&output.readable(Default::default()), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | let (r, g, b, a, Y) = sample(&output.readable(Default::default()), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | let (x, y) = func(sx, sy); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:200:12 [INFO] [stderr] | [INFO] [stderr] 200 | let (x, y) = func(sx, sy); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:201:8 [INFO] [stderr] | [INFO] [stderr] 201 | let p = input.get_clamped(x, y).into(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/decoder/jpeg.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | let r = (1.0 - c) * 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/decoder/jpeg.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let g = (1.0 - m) * 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/decoder/jpeg.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | let b = (1.0 - y) * 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:38:4 [INFO] [stderr] | [INFO] [stderr] 38 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:104:4 [INFO] [stderr] | [INFO] [stderr] 104 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:105:4 [INFO] [stderr] | [INFO] [stderr] 105 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:107:4 [INFO] [stderr] | [INFO] [stderr] 107 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/region.rs:108:4 [INFO] [stderr] | [INFO] [stderr] 108 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/buffer.rs:223:4 [INFO] [stderr] | [INFO] [stderr] 223 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/view.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/view.rs:57:4 [INFO] [stderr] | [INFO] [stderr] 57 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/view.rs:59:4 [INFO] [stderr] | [INFO] [stderr] 59 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/view.rs:60:4 [INFO] [stderr] | [INFO] [stderr] 60 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/read.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/read.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/read.rs:58:4 [INFO] [stderr] | [INFO] [stderr] 58 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/read.rs:59:4 [INFO] [stderr] | [INFO] [stderr] 59 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/write.rs:50:4 [INFO] [stderr] | [INFO] [stderr] 50 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/write.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/write.rs:53:4 [INFO] [stderr] | [INFO] [stderr] 53 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/view/write.rs:54:4 [INFO] [stderr] | [INFO] [stderr] 54 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/coordinates.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/immutable.rs:45:4 [INFO] [stderr] | [INFO] [stderr] 45 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/immutable.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/immutable.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/immutable.rs:77:4 [INFO] [stderr] | [INFO] [stderr] 77 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/mutable.rs:46:4 [INFO] [stderr] | [INFO] [stderr] 46 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/mutable.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/mutable.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/pixel/mutable.rs:78:4 [INFO] [stderr] | [INFO] [stderr] 78 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/processing/sampler/cubic.rs:34:6 [INFO] [stderr] | [INFO] [stderr] 34 | let k = if a < one!() { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | let (r, g, b, a, Y) = sample(input, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | let (r, g, b, a, Y) = sample(input, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:116:15 [INFO] [stderr] | [INFO] [stderr] 116 | let (r, g, b, a, Y) = sample(&output.readable(Default::default()), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | let (r, g, b, a, Y) = sample(&output.readable(Default::default()), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | let (x, y) = func(sx, sy); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:200:12 [INFO] [stderr] | [INFO] [stderr] 200 | let (x, y) = func(sx, sy); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:201:8 [INFO] [stderr] | [INFO] [stderr] 201 | let p = input.get_clamped(x, y).into(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/decoder/jpeg.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | let r = (1.0 - c) * 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/decoder/jpeg.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let g = (1.0 - m) * 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/decoder/jpeg.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | let b = (1.0 - y) * 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/buffer/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | mod buffer; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/view/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | mod view; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:63:23 [INFO] [stderr] | [INFO] [stderr] 63 | const WEIGHT1: f32 = 0.129633; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.129_633` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | const WEIGHT2: f32 = 0.175068; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.175_068` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | const MAGIC: &'static [(&'static [u8], Format)] = &[ [INFO] [stderr] | -^^^^^^^-------------------------- help: consider removing `'static`: `&[(&'static [u8], Format)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | const MAGIC: &'static [(&'static [u8], Format)] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:88:59 [INFO] [stderr] | [INFO] [stderr] 88 | let byte = try!(return input.read_u32::()) & 0xfff7ffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfff7_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | if byte == 0x01010000 || byte == 0x00020000 || byte == 0x00030000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0101_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:90:36 [INFO] [stderr] | [INFO] [stderr] 90 | if byte == 0x01010000 || byte == 0x00020000 || byte == 0x00030000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:90:58 [INFO] [stderr] | [INFO] [stderr] 90 | if byte == 0x01010000 || byte == 0x00020000 || byte == 0x00030000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/buffer/buffer.rs:514:10 [INFO] [stderr] | [INFO] [stderr] 514 | fn from(mut value: &'a mut Buffer) -> view::Write<'a, P, C> { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/buffer/buffer.rs:525:10 [INFO] [stderr] | [INFO] [stderr] 525 | fn from(mut value: &'a mut Buffer) -> View<'a, P, C> { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `owner` [INFO] [stderr] --> src/iter/pixel/immutable.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | owner: Region, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `owner` [INFO] [stderr] --> src/iter/pixel/mutable.rs:28:2 [INFO] [stderr] | [INFO] [stderr] 28 | owner: Region, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/util/clamped.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | let width = view.width() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(view.width())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/util/clamped.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | let height = view.height() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(view.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/util/clamped.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | let width = view.width() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(view.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/util/clamped.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | let height = view.height() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(view.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/region.rs:29:2 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new() -> Builder { [INFO] [stderr] | _____^ [INFO] [stderr] 30 | | Default::default() [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/orientation.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn rev(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/buffer/palette.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | o.set(&i.get().mix(&other.get_clamped(x as i64, y as i64), factor)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/buffer/palette.rs:51:52 [INFO] [stderr] | [INFO] [stderr] 51 | o.set(&i.get().mix(&other.get_clamped(x as i64, y as i64), factor)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/buffer/palette.rs:108:74 [INFO] [stderr] | [INFO] [stderr] 108 | o.set(&i.get().component_wise(&other.get_clamped(x as i64, y as i64), |a, b| f(a, b))); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/buffer/palette.rs:108:53 [INFO] [stderr] | [INFO] [stderr] 108 | o.set(&i.get().component_wise(&other.get_clamped(x as i64, y as i64), |a, b| f(a, b))); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/buffer/palette.rs:108:63 [INFO] [stderr] | [INFO] [stderr] 108 | o.set(&i.get().component_wise(&other.get_clamped(x as i64, y as i64), |a, b| f(a, b))); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/buffer/palette.rs:121:39 [INFO] [stderr] | [INFO] [stderr] 121 | o.set(&i.get().component_wise_self(|x| f(x))); [INFO] [stderr] | ^^^^^^^^ help: remove closure as shown: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/view/view.rs:234:20 [INFO] [stderr] | [INFO] [stderr] 234 | pub fn into_owned(&self) -> Buffer> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | debug_assert!(x_factor != y_factor || x_factor.fract() != 0.0 || (factor & (factor - 1)) != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(x_factor - y_factor).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | debug_assert!(x_factor != y_factor || x_factor.fract() != 0.0 || (factor & (factor - 1)) != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let cx = x as i64; [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | let cy = y as i64; [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | 1, -1 .. 3, |sx, sy| (sx + sy + x as i64, sx - sy + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:117:57 [INFO] [stderr] | [INFO] [stderr] 117 | 1, -1 .. 3, |sx, sy| (sx + sy + x as i64, sx - sy + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:137:41 [INFO] [stderr] | [INFO] [stderr] 137 | 1, -1 .. 3, |sx, sy| (sx + sy - 1 + x as i64, sx - sy + 1 + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:137:65 [INFO] [stderr] | [INFO] [stderr] 137 | 1, -1 .. 3, |sx, sy| (sx + sy - 1 + x as i64, sx - sy + 1 + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | 2, -2 .. 2, |sx, sy| (sx + x as i64, sy + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:157:47 [INFO] [stderr] | [INFO] [stderr] 157 | 2, -2 .. 2, |sx, sy| (sx + x as i64, sy + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:16 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:18 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:43 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:45 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:70 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:72 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/processing/scale.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | A::scale(&input.into(), width, height) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/sample.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | for x in 0 .. input.width() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/processing/sample.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | for i in left .. right + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/sample.rs:217:16 [INFO] [stderr] | [INFO] [stderr] 217 | for y in 0 .. input.height() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/processing/sample.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | for i in left .. right + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let c = buffer[cmyk ] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(buffer[cmyk ])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let m = buffer[cmyk + 1] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(buffer[cmyk + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let y = buffer[cmyk + 2] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(buffer[cmyk + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let k = buffer[cmyk + 3] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(buffer[cmyk + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | try!(self.metadata()).width as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).width)` [INFO] [stderr] ... [INFO] [stderr] 102 | buffer!(u8, color::Luma), [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | try!(self.metadata()).height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).height)` [INFO] [stderr] ... [INFO] [stderr] 102 | buffer!(u8, color::Luma), [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | try!(self.metadata()).width as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).width)` [INFO] [stderr] ... [INFO] [stderr] 105 | buffer!(u8, color::Rgb), [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | try!(self.metadata()).height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).height)` [INFO] [stderr] ... [INFO] [stderr] 105 | buffer!(u8, color::Rgb), [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | try!(self.metadata()).width as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).width)` [INFO] [stderr] ... [INFO] [stderr] 109 | buffer!(u8, color::Rgb) [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | try!(self.metadata()).height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).height)` [INFO] [stderr] ... [INFO] [stderr] 109 | buffer!(u8, color::Rgb) [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/decoder/gif.rs:77:64 [INFO] [stderr] | [INFO] [stderr] 77 | let frame = try!(try!(try!(self.reader()).read_next_frame()).ok_or(Error::Format("no frames".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Format("no frames".into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/gif.rs:80:4 [INFO] [stderr] | [INFO] [stderr] 80 | frame.width as u32, frame.height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(frame.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/gif.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | frame.width as u32, frame.height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(frame.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/xyz.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | image.width as u32, image.height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(image.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/xyz.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | image.width as u32, image.height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(image.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/read.rs:44:50 [INFO] [stderr] | [INFO] [stderr] 44 | let format = try!(format::guess(input.by_ref()).ok_or(Error::Format("unsupported image format".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Format("unsupported image format".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `picto`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/buffer/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | mod buffer; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/view/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | mod view; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:63:23 [INFO] [stderr] | [INFO] [stderr] 63 | const WEIGHT1: f32 = 0.129633; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.129_633` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | const WEIGHT2: f32 = 0.175068; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.175_068` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | const MAGIC: &'static [(&'static [u8], Format)] = &[ [INFO] [stderr] | -^^^^^^^-------------------------- help: consider removing `'static`: `&[(&'static [u8], Format)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | const MAGIC: &'static [(&'static [u8], Format)] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:88:59 [INFO] [stderr] | [INFO] [stderr] 88 | let byte = try!(return input.read_u32::()) & 0xfff7ffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfff7_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | if byte == 0x01010000 || byte == 0x00020000 || byte == 0x00030000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0101_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:90:36 [INFO] [stderr] | [INFO] [stderr] 90 | if byte == 0x01010000 || byte == 0x00020000 || byte == 0x00030000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:90:58 [INFO] [stderr] | [INFO] [stderr] 90 | if byte == 0x01010000 || byte == 0x00020000 || byte == 0x00030000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/buffer/buffer.rs:514:10 [INFO] [stderr] | [INFO] [stderr] 514 | fn from(mut value: &'a mut Buffer) -> view::Write<'a, P, C> { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/buffer/buffer.rs:525:10 [INFO] [stderr] | [INFO] [stderr] 525 | fn from(mut value: &'a mut Buffer) -> View<'a, P, C> { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `owner` [INFO] [stderr] --> src/iter/pixel/immutable.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | owner: Region, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `owner` [INFO] [stderr] --> src/iter/pixel/mutable.rs:28:2 [INFO] [stderr] | [INFO] [stderr] 28 | owner: Region, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/util/clamped.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | let width = view.width() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(view.width())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/util/clamped.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | let height = view.height() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(view.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/util/clamped.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | let width = view.width() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(view.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/util/clamped.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | let height = view.height() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(view.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/region.rs:29:2 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new() -> Builder { [INFO] [stderr] | _____^ [INFO] [stderr] 30 | | Default::default() [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/orientation.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn rev(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/buffer/palette.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | o.set(&i.get().mix(&other.get_clamped(x as i64, y as i64), factor)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/buffer/palette.rs:51:52 [INFO] [stderr] | [INFO] [stderr] 51 | o.set(&i.get().mix(&other.get_clamped(x as i64, y as i64), factor)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/buffer/palette.rs:108:74 [INFO] [stderr] | [INFO] [stderr] 108 | o.set(&i.get().component_wise(&other.get_clamped(x as i64, y as i64), |a, b| f(a, b))); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/buffer/palette.rs:108:53 [INFO] [stderr] | [INFO] [stderr] 108 | o.set(&i.get().component_wise(&other.get_clamped(x as i64, y as i64), |a, b| f(a, b))); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/buffer/palette.rs:108:63 [INFO] [stderr] | [INFO] [stderr] 108 | o.set(&i.get().component_wise(&other.get_clamped(x as i64, y as i64), |a, b| f(a, b))); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/buffer/palette.rs:121:39 [INFO] [stderr] | [INFO] [stderr] 121 | o.set(&i.get().component_wise_self(|x| f(x))); [INFO] [stderr] | ^^^^^^^^ help: remove closure as shown: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/view/view.rs:234:20 [INFO] [stderr] | [INFO] [stderr] 234 | pub fn into_owned(&self) -> Buffer> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | debug_assert!(x_factor != y_factor || x_factor.fract() != 0.0 || (factor & (factor - 1)) != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(x_factor - y_factor).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | debug_assert!(x_factor != y_factor || x_factor.fract() != 0.0 || (factor & (factor - 1)) != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let cx = x as i64; [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | let cy = y as i64; [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | 1, -1 .. 3, |sx, sy| (sx + sy + x as i64, sx - sy + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:117:57 [INFO] [stderr] | [INFO] [stderr] 117 | 1, -1 .. 3, |sx, sy| (sx + sy + x as i64, sx - sy + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:137:41 [INFO] [stderr] | [INFO] [stderr] 137 | 1, -1 .. 3, |sx, sy| (sx + sy - 1 + x as i64, sx - sy + 1 + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:137:65 [INFO] [stderr] | [INFO] [stderr] 137 | 1, -1 .. 3, |sx, sy| (sx + sy - 1 + x as i64, sx - sy + 1 + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | 2, -2 .. 2, |sx, sy| (sx + x as i64, sy + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/scaler/xbr/zuper.rs:157:47 [INFO] [stderr] | [INFO] [stderr] 157 | 2, -2 .. 2, |sx, sy| (sx + x as i64, sy + y as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:16 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:18 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:43 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:45 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:70 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/processing/ditherer/palette.rs:748:72 [INFO] [stderr] | [INFO] [stderr] 748 | Color { r: ( 0 * 255 / 100) as u8, g: ( 0 * 255 / 100) as u8, b: ( 0 * 255 / 100) as u8, a: 0xff }]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/processing/scale.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | A::scale(&input.into(), width, height) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/sample.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | for x in 0 .. input.width() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/processing/sample.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | for i in left .. right + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/processing/sample.rs:217:16 [INFO] [stderr] | [INFO] [stderr] 217 | for y in 0 .. input.height() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/processing/sample.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | for i in left .. right + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let c = buffer[cmyk ] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(buffer[cmyk ])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let m = buffer[cmyk + 1] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(buffer[cmyk + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let y = buffer[cmyk + 2] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(buffer[cmyk + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let k = buffer[cmyk + 3] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(buffer[cmyk + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | try!(self.metadata()).width as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).width)` [INFO] [stderr] ... [INFO] [stderr] 102 | buffer!(u8, color::Luma), [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | try!(self.metadata()).height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).height)` [INFO] [stderr] ... [INFO] [stderr] 102 | buffer!(u8, color::Luma), [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | try!(self.metadata()).width as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).width)` [INFO] [stderr] ... [INFO] [stderr] 105 | buffer!(u8, color::Rgb), [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | try!(self.metadata()).height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).height)` [INFO] [stderr] ... [INFO] [stderr] 105 | buffer!(u8, color::Rgb), [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | try!(self.metadata()).width as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).width)` [INFO] [stderr] ... [INFO] [stderr] 109 | buffer!(u8, color::Rgb) [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/jpeg.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | try!(self.metadata()).height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(try!(self.metadata()).height)` [INFO] [stderr] ... [INFO] [stderr] 109 | buffer!(u8, color::Rgb) [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/decoder/gif.rs:77:64 [INFO] [stderr] | [INFO] [stderr] 77 | let frame = try!(try!(try!(self.reader()).read_next_frame()).ok_or(Error::Format("no frames".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Format("no frames".into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/gif.rs:80:4 [INFO] [stderr] | [INFO] [stderr] 80 | frame.width as u32, frame.height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(frame.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/gif.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | frame.width as u32, frame.height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(frame.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/xyz.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | image.width as u32, image.height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(image.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder/xyz.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | image.width as u32, image.height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(image.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/read.rs:44:50 [INFO] [stderr] | [INFO] [stderr] 44 | let format = try!(format::guess(input.by_ref()).ok_or(Error::Format("unsupported image format".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Format("unsupported image format".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `picto`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d5b0c7ee8f60131f5ad61dd7c453bd45c8eb6b4a504a6a1e8be5e22622731785"` [INFO] running `"docker" "rm" "-f" "d5b0c7ee8f60131f5ad61dd7c453bd45c8eb6b4a504a6a1e8be5e22622731785"` [INFO] [stdout] d5b0c7ee8f60131f5ad61dd7c453bd45c8eb6b4a504a6a1e8be5e22622731785