[INFO] crate phonenumber 0.2.1+8.9.0 is already in cache [INFO] extracting crate phonenumber 0.2.1+8.9.0 into work/ex/clippy-test-run/sources/stable/reg/phonenumber/0.2.1+8.9.0 [INFO] extracting crate phonenumber 0.2.1+8.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/phonenumber/0.2.1+8.9.0 [INFO] validating manifest of phonenumber-0.2.1+8.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phonenumber-0.2.1+8.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phonenumber-0.2.1+8.9.0 [INFO] finished frobbing phonenumber-0.2.1+8.9.0 [INFO] frobbed toml for phonenumber-0.2.1+8.9.0 written to work/ex/clippy-test-run/sources/stable/reg/phonenumber/0.2.1+8.9.0/Cargo.toml [INFO] started frobbing phonenumber-0.2.1+8.9.0 [INFO] finished frobbing phonenumber-0.2.1+8.9.0 [INFO] frobbed toml for phonenumber-0.2.1+8.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/phonenumber/0.2.1+8.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phonenumber-0.2.1+8.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/phonenumber/0.2.1+8.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 219d81571ab244283eacd7898e34b007f08544e41fe8c78fabe95edb48d6c449 [INFO] running `"docker" "start" "-a" "219d81571ab244283eacd7898e34b007f08544e41fe8c78fabe95edb48d6c449"` [INFO] [stderr] Checking oncemutex v0.1.1 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Compiling bincode v1.0.1 [INFO] [stderr] Checking regex-cache v0.2.0 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Compiling aho-corasick v0.6.9 [INFO] [stderr] Compiling failure v0.1.5 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Compiling quick-xml v0.12.4 [INFO] [stderr] Compiling phonenumber v0.2.1+8.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: variant is never constructed: `MissingValue` [INFO] [stderr] --> src/error.rs:28:2 [INFO] [stderr] | [INFO] [stderr] 28 | MissingValue { [INFO] [stderr] | _____^ [INFO] [stderr] 29 | | phase: String, [INFO] [stderr] 30 | | name: String, [INFO] [stderr] 31 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NoNumber` [INFO] [stderr] --> src/error.rs:62:2 [INFO] [stderr] | [INFO] [stderr] 62 | NoNumber, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `InvalidCountryCode` [INFO] [stderr] --> src/error.rs:67:2 [INFO] [stderr] | [INFO] [stderr] 67 | InvalidCountryCode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TooShortAfterIdd` [INFO] [stderr] --> src/error.rs:73:2 [INFO] [stderr] | [INFO] [stderr] 73 | TooShortAfterIdd, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TooShortNsn` [INFO] [stderr] --> src/error.rs:78:2 [INFO] [stderr] | [INFO] [stderr] 78 | TooShortNsn, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TooLong` [INFO] [stderr] --> src/error.rs:83:2 [INFO] [stderr] | [INFO] [stderr] 83 | TooLong, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/database.rs:201:4 [INFO] [stderr] | [INFO] [stderr] 201 | by_id: by_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `by_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/database.rs:202:4 [INFO] [stderr] | [INFO] [stderr] 202 | by_code: by_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `by_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/database.rs:203:4 [INFO] [stderr] | [INFO] [stderr] 203 | regions: regions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `regions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:78:3 [INFO] [stderr] | [INFO] [stderr] 78 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/database.rs:201:4 [INFO] [stderr] | [INFO] [stderr] 201 | by_id: by_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `by_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/database.rs:202:4 [INFO] [stderr] | [INFO] [stderr] 202 | by_code: by_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `by_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/database.rs:203:4 [INFO] [stderr] | [INFO] [stderr] 203 | regions: regions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `regions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:78:3 [INFO] [stderr] | [INFO] [stderr] 78 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/metadata/mod.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | mod metadata; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/formatter.rs:186:3 [INFO] [stderr] | [INFO] [stderr] 186 | if leading.is_empty() || leading.last().unwrap().find(&number).map(|m| m.start() == 0).unwrap_or(false) { [INFO] [stderr] | _________^ [INFO] [stderr] 187 | | if format.pattern().find(&number).map(|m| m.start() == 0 && m.end() == number.len()).unwrap_or(false) { [INFO] [stderr] 188 | | return Some(format); [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 186 | if (leading.is_empty() || leading.last().unwrap().find(&number).map(|m| m.start() == 0).unwrap_or(false)) && format.pattern().find(&number).map(|m| m.start() == 0 && m.end() == number.len()).unwrap_or(false) { [INFO] [stderr] 187 | return Some(format); [INFO] [stderr] 188 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/metadata/mod.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | mod metadata; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/mod.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | value: 33316005, [INFO] [stderr] | ^^^^^^^^ help: consider: `33_316_005` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/mod.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | value: 64123456, [INFO] [stderr] | ^^^^^^^^ help: consider: `64_123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/mod.rs:164:12 [INFO] [stderr] | [INFO] [stderr] 164 | value: 30123456, [INFO] [stderr] | ^^^^^^^^ help: consider: `30_123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/mod.rs:209:12 [INFO] [stderr] | [INFO] [stderr] 209 | value: 3121286979, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_121_286_979` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/formatter.rs:186:3 [INFO] [stderr] | [INFO] [stderr] 186 | if leading.is_empty() || leading.last().unwrap().find(&number).map(|m| m.start() == 0).unwrap_or(false) { [INFO] [stderr] | _________^ [INFO] [stderr] 187 | | if format.pattern().find(&number).map(|m| m.start() == 0 && m.end() == number.len()).unwrap_or(false) { [INFO] [stderr] 188 | | return Some(format); [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 186 | if (leading.is_empty() || leading.last().unwrap().find(&number).map(|m| m.start() == 0).unwrap_or(false)) && format.pattern().find(&number).map(|m| m.start() == 0 && m.end() == number.len()).unwrap_or(false) { [INFO] [stderr] 187 | return Some(format); [INFO] [stderr] 188 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/metadata/loader.rs:336:15 [INFO] [stderr] | [INFO] [stderr] 336 | for i in start .. end + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/country.rs:62:15 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn value(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/country.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn source(&self) -> Source { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/metadata/loader.rs:336:15 [INFO] [stderr] | [INFO] [stderr] 336 | for i in start .. end + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser/helper.rs:125:16 [INFO] [stderr] | [INFO] [stderr] 125 | for len in 1 .. consts::MAX_LENGTH_FOR_COUNTRY_CODE + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=consts::MAX_LENGTH_FOR_COUNTRY_CODE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/country.rs:62:15 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn value(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/country.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn source(&self) -> Source { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/rfc3966.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | / named!(prefix(&str) -> &str, [INFO] [stderr] 45 | | do_parse!( [INFO] [stderr] 46 | | char!('+') >> [INFO] [stderr] 47 | | prefix: take_till1_s!(separator) >> [INFO] [stderr] 48 | | [INFO] [stderr] 49 | | (prefix))); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validator.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn is_possible(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validator.rs:65:20 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn is_invalid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validator.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn is_invalid_length(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser/helper.rs:125:16 [INFO] [stderr] | [INFO] [stderr] 125 | for len in 1 .. consts::MAX_LENGTH_FOR_COUNTRY_CODE + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=consts::MAX_LENGTH_FOR_COUNTRY_CODE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/rfc3966.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | / named!(prefix(&str) -> &str, [INFO] [stderr] 45 | | do_parse!( [INFO] [stderr] 46 | | char!('+') >> [INFO] [stderr] 47 | | prefix: take_till1_s!(separator) >> [INFO] [stderr] 48 | | [INFO] [stderr] 49 | | (prefix))); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validator.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn is_possible(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validator.rs:65:20 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn is_invalid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validator.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn is_invalid_length(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> examples/test.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | if args.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.74s [INFO] running `"docker" "inspect" "219d81571ab244283eacd7898e34b007f08544e41fe8c78fabe95edb48d6c449"` [INFO] running `"docker" "rm" "-f" "219d81571ab244283eacd7898e34b007f08544e41fe8c78fabe95edb48d6c449"` [INFO] [stdout] 219d81571ab244283eacd7898e34b007f08544e41fe8c78fabe95edb48d6c449