[INFO] crate phoenix-rs 0.1.1 is already in cache [INFO] extracting crate phoenix-rs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/phoenix-rs/0.1.1 [INFO] extracting crate phoenix-rs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/phoenix-rs/0.1.1 [INFO] validating manifest of phoenix-rs-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phoenix-rs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phoenix-rs-0.1.1 [INFO] finished frobbing phoenix-rs-0.1.1 [INFO] frobbed toml for phoenix-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/phoenix-rs/0.1.1/Cargo.toml [INFO] started frobbing phoenix-rs-0.1.1 [INFO] finished frobbing phoenix-rs-0.1.1 [INFO] frobbed toml for phoenix-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/phoenix-rs/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phoenix-rs-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/phoenix-rs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c0b1128849f65c295ab14a84dcc20ee826971e6fafe93dce01580a07b73e3e00 [INFO] running `"docker" "start" "-a" "c0b1128849f65c295ab14a84dcc20ee826971e6fafe93dce01580a07b73e3e00"` [INFO] [stderr] warning: file found to be present in multiple build targets: /opt/crater/workdir/examples/basic.rs [INFO] [stderr] Checking websocket v0.20.4 [INFO] [stderr] Checking phoenix-rs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chan.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chan.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/socket.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channels_1` [INFO] [stderr] --> src/socket.rs:65:7 [INFO] [stderr] | [INFO] [stderr] 65 | let channels_1 = channels.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_channels_1` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/socket.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | match message { [INFO] [stderr] | _________________^ [INFO] [stderr] 45 | | OwnedMessage::Close(_) => { [INFO] [stderr] 46 | | let _ = sender.send_message(&message); [INFO] [stderr] 47 | | // If it's a close message, just send it and then return. [INFO] [stderr] ... | [INFO] [stderr] 50 | | _ => (), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let OwnedMessage::Close(_) = message { [INFO] [stderr] 45 | let _ = sender.send_message(&message); [INFO] [stderr] 46 | // If it's a close message, just send it and then return. [INFO] [stderr] 47 | return; [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/socket.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | send.send(v); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/socket.rs:121:3 [INFO] [stderr] | [INFO] [stderr] 121 | self.count = self.count+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/socket.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `channels_1` [INFO] [stderr] --> src/socket.rs:65:7 [INFO] [stderr] | [INFO] [stderr] 65 | let channels_1 = channels.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_channels_1` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/socket.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | match message { [INFO] [stderr] | _________________^ [INFO] [stderr] 45 | | OwnedMessage::Close(_) => { [INFO] [stderr] 46 | | let _ = sender.send_message(&message); [INFO] [stderr] 47 | | // If it's a close message, just send it and then return. [INFO] [stderr] ... | [INFO] [stderr] 50 | | _ => (), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let OwnedMessage::Close(_) = message { [INFO] [stderr] 45 | let _ = sender.send_message(&message); [INFO] [stderr] 46 | // If it's a close message, just send it and then return. [INFO] [stderr] 47 | return; [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/socket.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | send.send(v); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/socket.rs:121:3 [INFO] [stderr] | [INFO] [stderr] 121 | self.count = self.count+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.50s [INFO] running `"docker" "inspect" "c0b1128849f65c295ab14a84dcc20ee826971e6fafe93dce01580a07b73e3e00"` [INFO] running `"docker" "rm" "-f" "c0b1128849f65c295ab14a84dcc20ee826971e6fafe93dce01580a07b73e3e00"` [INFO] [stdout] c0b1128849f65c295ab14a84dcc20ee826971e6fafe93dce01580a07b73e3e00