[INFO] crate phoenix 0.1.2 is already in cache [INFO] extracting crate phoenix 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/phoenix/0.1.2 [INFO] extracting crate phoenix 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/phoenix/0.1.2 [INFO] validating manifest of phoenix-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phoenix-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phoenix-0.1.2 [INFO] finished frobbing phoenix-0.1.2 [INFO] frobbed toml for phoenix-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/phoenix/0.1.2/Cargo.toml [INFO] started frobbing phoenix-0.1.2 [INFO] finished frobbing phoenix-0.1.2 [INFO] frobbed toml for phoenix-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/phoenix/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phoenix-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/phoenix/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3154f2b18081e9479e95c81ae3f187a24eebbb99ae1159a1c0871d38e6a0caed [INFO] running `"docker" "start" "-a" "3154f2b18081e9479e95c81ae3f187a24eebbb99ae1159a1c0871d38e6a0caed"` [INFO] [stderr] warning: file found to be present in multiple build targets: /opt/crater/workdir/examples/basic.rs [INFO] [stderr] Checking websocket v0.20.4 [INFO] [stderr] Checking phoenix v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/event.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde_json` [INFO] [stderr] --> src/event.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use serde_json; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/socket.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | match message { [INFO] [stderr] | _________________^ [INFO] [stderr] 47 | | OwnedMessage::Close(_) => { [INFO] [stderr] 48 | | debug!("Received a close message"); [INFO] [stderr] 49 | | let _ = sender.send_message(&message); [INFO] [stderr] ... | [INFO] [stderr] 53 | | _ => (), [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | if let OwnedMessage::Close(_) = message { [INFO] [stderr] 47 | debug!("Received a close message"); [INFO] [stderr] 48 | let _ = sender.send_message(&message); [INFO] [stderr] 49 | // If it's a close message, just send it and then return. [INFO] [stderr] 50 | return; [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/socket.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | send.send(v); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/socket.rs:143:3 [INFO] [stderr] | [INFO] [stderr] 143 | self.count = self.count+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/event.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/socket.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | match message { [INFO] [stderr] | _________________^ [INFO] [stderr] 47 | | OwnedMessage::Close(_) => { [INFO] [stderr] 48 | | debug!("Received a close message"); [INFO] [stderr] 49 | | let _ = sender.send_message(&message); [INFO] [stderr] ... | [INFO] [stderr] 53 | | _ => (), [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | if let OwnedMessage::Close(_) = message { [INFO] [stderr] 47 | debug!("Received a close message"); [INFO] [stderr] 48 | let _ = sender.send_message(&message); [INFO] [stderr] 49 | // If it's a close message, just send it and then return. [INFO] [stderr] 50 | return; [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/socket.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | send.send(v); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/socket.rs:143:3 [INFO] [stderr] | [INFO] [stderr] 143 | self.count = self.count+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/basic.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/basic.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/basic.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.91s [INFO] running `"docker" "inspect" "3154f2b18081e9479e95c81ae3f187a24eebbb99ae1159a1c0871d38e6a0caed"` [INFO] running `"docker" "rm" "-f" "3154f2b18081e9479e95c81ae3f187a24eebbb99ae1159a1c0871d38e6a0caed"` [INFO] [stdout] 3154f2b18081e9479e95c81ae3f187a24eebbb99ae1159a1c0871d38e6a0caed