[INFO] crate pgp 0.1.0 is already in cache [INFO] extracting crate pgp 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/pgp/0.1.0 [INFO] extracting crate pgp 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pgp/0.1.0 [INFO] validating manifest of pgp-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pgp-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pgp-0.1.0 [INFO] finished frobbing pgp-0.1.0 [INFO] frobbed toml for pgp-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/pgp/0.1.0/Cargo.toml [INFO] started frobbing pgp-0.1.0 [INFO] finished frobbing pgp-0.1.0 [INFO] frobbed toml for pgp-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pgp/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pgp-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pgp/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 391754f746e42bc0f784e4ab5db09bcc755eee228d669b5c8ccf768af7650317 [INFO] running `"docker" "start" "-a" "391754f746e42bc0f784e4ab5db09bcc755eee228d669b5c8ccf768af7650317"` [INFO] [stderr] Compiling crc24 v0.1.6 [INFO] [stderr] Checking pgp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pgp.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pgp.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pgp.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | packets: packets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `packets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pgp.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pgp.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pgp.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | packets: packets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `packets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/pgp.rs:165:8 [INFO] [stderr] | [INFO] [stderr] 165 | ), |v| v.iter().map(|p| *p).collect())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `v.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `ParseResult` [INFO] [stderr] --> src/types.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub type ParseResult<'a> = IResult<&'a [u8], Headers>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_name_token` [INFO] [stderr] --> src/header.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn is_name_token(chr: u8) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_body_token` [INFO] [stderr] --> src/header.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | fn is_body_token(chr: char) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `body_token` [INFO] [stderr] --> src/header.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / fn body_token(input: T) -> IResult [INFO] [stderr] 26 | | where [INFO] [stderr] 27 | | T: nom::Slice> + nom::Slice> + nom::Slice>, [INFO] [stderr] 28 | | T: nom::InputIter + nom::InputLength, [INFO] [stderr] ... | [INFO] [stderr] 46 | | IResult::Done(input.slice(input_length..), input) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse` [INFO] [stderr] --> src/header.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn parse(msg: &[u8]) -> ParseResult { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse` [INFO] [stderr] --> src/email.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn parse(msg: &[u8]) -> IResult<&[u8], Email> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pgp.rs:197:1 [INFO] [stderr] | [INFO] [stderr] 197 | / named!(public_key_body>, bits!(do_parse!( [INFO] [stderr] 198 | | key_ver: take_bits!(u8, 8) >> [INFO] [stderr] 199 | | details: switch!( [INFO] [stderr] 200 | | value!(key_ver), [INFO] [stderr] ... | [INFO] [stderr] 231 | | ({ Some(key_ver) }) [INFO] [stderr] 232 | | ))); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/pgp.rs:197:1 [INFO] [stderr] | [INFO] [stderr] 197 | / named!(public_key_body>, bits!(do_parse!( [INFO] [stderr] 198 | | key_ver: take_bits!(u8, 8) >> [INFO] [stderr] 199 | | details: switch!( [INFO] [stderr] 200 | | value!(key_ver), [INFO] [stderr] ... | [INFO] [stderr] 231 | | ({ Some(key_ver) }) [INFO] [stderr] 232 | | ))); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pgp.rs:197:1 [INFO] [stderr] | [INFO] [stderr] 197 | / named!(public_key_body>, bits!(do_parse!( [INFO] [stderr] 198 | | key_ver: take_bits!(u8, 8) >> [INFO] [stderr] 199 | | details: switch!( [INFO] [stderr] 200 | | value!(key_ver), [INFO] [stderr] ... | [INFO] [stderr] 231 | | ({ Some(key_ver) }) [INFO] [stderr] 232 | | ))); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pgp.rs:234:1 [INFO] [stderr] | [INFO] [stderr] 234 | / named_args!( [INFO] [stderr] 235 | | packet_body_parser(tag: u8) >, [INFO] [stderr] 236 | | switch!(value!(tag), [INFO] [stderr] 237 | | // Public Key [INFO] [stderr] 238 | | 6 => call!(public_key_body) | [INFO] [stderr] 239 | | _ => value!(None) [INFO] [stderr] 240 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pgp.rs:242:1 [INFO] [stderr] | [INFO] [stderr] 242 | / named!(old_packet_header((&[u8], usize)) -> (u8, u8, usize), do_parse!( [INFO] [stderr] 243 | | // Version [INFO] [stderr] 244 | | tag_bits!(u8, 1, 0) >> [INFO] [stderr] 245 | | // Packet Tag [INFO] [stderr] ... | [INFO] [stderr] 256 | | ((0, tag, len)) [INFO] [stderr] 257 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pgp.rs:259:1 [INFO] [stderr] | [INFO] [stderr] 259 | / named!(new_packet_header((&[u8], usize)) -> (u8, u8, usize), do_parse!( [INFO] [stderr] 260 | | // Version [INFO] [stderr] 261 | | tag_bits!(u8, 1, 1) >> [INFO] [stderr] 262 | | // Packet Tag [INFO] [stderr] ... | [INFO] [stderr] 278 | | ((1, tag, len)) [INFO] [stderr] 279 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/pgp.rs:165:8 [INFO] [stderr] | [INFO] [stderr] 165 | ), |v| v.iter().map(|p| *p).collect())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `v.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/pgp.rs:283:1 [INFO] [stderr] | [INFO] [stderr] 283 | / named!(packet_parser, bits!(do_parse!( [INFO] [stderr] 284 | | // Packet Header - First octet [INFO] [stderr] 285 | | tag_bits!(u8, 1, 1) >> [INFO] [stderr] 286 | | top: alt_complete!(new_packet_header | old_packet_header) >> [INFO] [stderr] ... | [INFO] [stderr] 294 | | }) [INFO] [stderr] 295 | | ))); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pgp.rs:197:1 [INFO] [stderr] | [INFO] [stderr] 197 | / named!(public_key_body>, bits!(do_parse!( [INFO] [stderr] 198 | | key_ver: take_bits!(u8, 8) >> [INFO] [stderr] 199 | | details: switch!( [INFO] [stderr] 200 | | value!(key_ver), [INFO] [stderr] ... | [INFO] [stderr] 231 | | ({ Some(key_ver) }) [INFO] [stderr] 232 | | ))); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/pgp.rs:197:1 [INFO] [stderr] | [INFO] [stderr] 197 | / named!(public_key_body>, bits!(do_parse!( [INFO] [stderr] 198 | | key_ver: take_bits!(u8, 8) >> [INFO] [stderr] 199 | | details: switch!( [INFO] [stderr] 200 | | value!(key_ver), [INFO] [stderr] ... | [INFO] [stderr] 231 | | ({ Some(key_ver) }) [INFO] [stderr] 232 | | ))); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pgp.rs:197:1 [INFO] [stderr] | [INFO] [stderr] 197 | / named!(public_key_body>, bits!(do_parse!( [INFO] [stderr] 198 | | key_ver: take_bits!(u8, 8) >> [INFO] [stderr] 199 | | details: switch!( [INFO] [stderr] 200 | | value!(key_ver), [INFO] [stderr] ... | [INFO] [stderr] 231 | | ({ Some(key_ver) }) [INFO] [stderr] 232 | | ))); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pgp.rs:234:1 [INFO] [stderr] | [INFO] [stderr] 234 | / named_args!( [INFO] [stderr] 235 | | packet_body_parser(tag: u8) >, [INFO] [stderr] 236 | | switch!(value!(tag), [INFO] [stderr] 237 | | // Public Key [INFO] [stderr] 238 | | 6 => call!(public_key_body) | [INFO] [stderr] 239 | | _ => value!(None) [INFO] [stderr] 240 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pgp.rs:242:1 [INFO] [stderr] | [INFO] [stderr] 242 | / named!(old_packet_header((&[u8], usize)) -> (u8, u8, usize), do_parse!( [INFO] [stderr] 243 | | // Version [INFO] [stderr] 244 | | tag_bits!(u8, 1, 0) >> [INFO] [stderr] 245 | | // Packet Tag [INFO] [stderr] ... | [INFO] [stderr] 256 | | ((0, tag, len)) [INFO] [stderr] 257 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pgp.rs:259:1 [INFO] [stderr] | [INFO] [stderr] 259 | / named!(new_packet_header((&[u8], usize)) -> (u8, u8, usize), do_parse!( [INFO] [stderr] 260 | | // Version [INFO] [stderr] 261 | | tag_bits!(u8, 1, 1) >> [INFO] [stderr] 262 | | // Packet Tag [INFO] [stderr] ... | [INFO] [stderr] 278 | | ((1, tag, len)) [INFO] [stderr] 279 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/pgp.rs:283:1 [INFO] [stderr] | [INFO] [stderr] 283 | / named!(packet_parser, bits!(do_parse!( [INFO] [stderr] 284 | | // Packet Header - First octet [INFO] [stderr] 285 | | tag_bits!(u8, 1, 1) >> [INFO] [stderr] 286 | | top: alt_complete!(new_packet_header | old_packet_header) >> [INFO] [stderr] ... | [INFO] [stderr] 294 | | }) [INFO] [stderr] 295 | | ))); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.35s [INFO] running `"docker" "inspect" "391754f746e42bc0f784e4ab5db09bcc755eee228d669b5c8ccf768af7650317"` [INFO] running `"docker" "rm" "-f" "391754f746e42bc0f784e4ab5db09bcc755eee228d669b5c8ccf768af7650317"` [INFO] [stdout] 391754f746e42bc0f784e4ab5db09bcc755eee228d669b5c8ccf768af7650317