[INFO] crate pgetopts 0.1.2 is already in cache [INFO] extracting crate pgetopts 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/pgetopts/0.1.2 [INFO] extracting crate pgetopts 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pgetopts/0.1.2 [INFO] validating manifest of pgetopts-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pgetopts-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pgetopts-0.1.2 [INFO] finished frobbing pgetopts-0.1.2 [INFO] frobbed toml for pgetopts-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/pgetopts/0.1.2/Cargo.toml [INFO] started frobbing pgetopts-0.1.2 [INFO] finished frobbing pgetopts-0.1.2 [INFO] frobbed toml for pgetopts-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pgetopts/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pgetopts-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pgetopts/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b2c9d35f41fa5f96384f26e531a2bdb0a500149c6cbaedfd8242562dd0f5f17 [INFO] running `"docker" "start" "-a" "4b2c9d35f41fa5f96384f26e531a2bdb0a500149c6cbaedfd8242562dd0f5f17"` [INFO] [stderr] Checking ansi_term v0.6.3 [INFO] [stderr] Checking pgetopts v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | hasarg: hasarg, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasarg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | occur: occur [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `occur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | opts: opts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | vals: vals, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | free: free [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `free` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:687:17 [INFO] [stderr] | [INFO] [stderr] 687 | hasarg: hasarg, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasarg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:688:17 [INFO] [stderr] | [INFO] [stderr] 688 | occur: occur, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `occur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:693:17 [INFO] [stderr] | [INFO] [stderr] 693 | hasarg: hasarg, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasarg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:694:17 [INFO] [stderr] | [INFO] [stderr] 694 | occur: occur, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `occur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | hasarg: hasarg, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasarg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:700:17 [INFO] [stderr] | [INFO] [stderr] 700 | occur: occur, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `occur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | hasarg: hasarg, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasarg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | occur: occur [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `occur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | opts: opts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | vals: vals, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | free: free [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `free` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:687:17 [INFO] [stderr] | [INFO] [stderr] 687 | hasarg: hasarg, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasarg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:688:17 [INFO] [stderr] | [INFO] [stderr] 688 | occur: occur, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `occur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:693:17 [INFO] [stderr] | [INFO] [stderr] 693 | hasarg: hasarg, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasarg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:694:17 [INFO] [stderr] | [INFO] [stderr] 694 | occur: occur, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `occur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | hasarg: hasarg, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hasarg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:700:17 [INFO] [stderr] | [INFO] [stderr] 700 | occur: occur, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `occur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:295:42 [INFO] [stderr] | [INFO] [stderr] 295 | fn f(_x: usize) -> Vec { return Vec::new(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:686:28 [INFO] [stderr] | [INFO] [stderr] 686 | name: Long((long_name)), [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:686:28 [INFO] [stderr] | [INFO] [stderr] 686 | name: Long((long_name)), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:698:28 [INFO] [stderr] | [INFO] [stderr] 698 | name: Long((long_name)), [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:698:28 [INFO] [stderr] | [INFO] [stderr] 698 | name: Long((long_name)), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:980:5 [INFO] [stderr] | [INFO] [stderr] 980 | return cont; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `cont` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/lib.rs:436:29 [INFO] [stderr] | [INFO] [stderr] 436 | .connect(" ")); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/lib.rs:520:37 [INFO] [stderr] | [INFO] [stderr] 520 | row.push_str(&desc_rows.connect(&desc_sep)); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/lib.rs:526:47 [INFO] [stderr] | [INFO] [stderr] 526 | rows.collect::>().connect("\n")) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Options` [INFO] [stderr] --> src/lib.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / pub fn new() -> Options { [INFO] [stderr] 123 | | Options { [INFO] [stderr] 124 | | grps: Vec::new(), [INFO] [stderr] 125 | | parsing_style: ParsingStyle::FloatingFrees [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | impl Default for Options { [INFO] [stderr] 121 | fn default() -> Self { [INFO] [stderr] 122 | Self::new() [INFO] [stderr] 123 | } [INFO] [stderr] 124 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:295:42 [INFO] [stderr] | [INFO] [stderr] 295 | fn f(_x: usize) -> Vec { return Vec::new(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:686:28 [INFO] [stderr] | [INFO] [stderr] 686 | name: Long((long_name)), [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:686:28 [INFO] [stderr] | [INFO] [stderr] 686 | name: Long((long_name)), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:698:28 [INFO] [stderr] | [INFO] [stderr] 698 | name: Long((long_name)), [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:698:28 [INFO] [stderr] | [INFO] [stderr] 698 | name: Long((long_name)), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:980:5 [INFO] [stderr] | [INFO] [stderr] 980 | return cont; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `cont` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:379:28 [INFO] [stderr] | [INFO] [stderr] 379 | if name_pos == names.len() && !i_arg.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `name_pos == names.len() && i_arg.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:385:28 [INFO] [stderr] | [INFO] [stderr] 385 | if !i_arg.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i_arg.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:398:28 [INFO] [stderr] | [INFO] [stderr] 398 | if !i_arg.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i_arg.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the variable `name_pos` is used as a loop counter. Consider using `for (name_pos, item) in names.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:371:27 [INFO] [stderr] | [INFO] [stderr] 371 | for nm in names.iter() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:460:24 [INFO] [stderr] | [INFO] [stderr] 460 | if long_name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!long_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:807:12 [INFO] [stderr] | [INFO] [stderr] 807 | if candidate.aliases.iter().position(|opt| opt.name == nm).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `position(|opt| opt.name == nm).is_some()` with `any(|opt| opt.name == nm)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:845:8 [INFO] [stderr] | [INFO] [stderr] 845 | if opt.short_name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!opt.short_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:934:43 [INFO] [stderr] | [INFO] [stderr] 934 | &ss[last_start..i + 1]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `last_start..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/lib.rs:436:29 [INFO] [stderr] | [INFO] [stderr] 436 | .connect(" ")); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/lib.rs:520:37 [INFO] [stderr] | [INFO] [stderr] 520 | row.push_str(&desc_rows.connect(&desc_sep)); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/lib.rs:526:47 [INFO] [stderr] | [INFO] [stderr] 526 | rows.collect::>().connect("\n")) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Options` [INFO] [stderr] --> src/lib.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / pub fn new() -> Options { [INFO] [stderr] 123 | | Options { [INFO] [stderr] 124 | | grps: Vec::new(), [INFO] [stderr] 125 | | parsing_style: ParsingStyle::FloatingFrees [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | impl Default for Options { [INFO] [stderr] 121 | fn default() -> Self { [INFO] [stderr] 122 | Self::new() [INFO] [stderr] 123 | } [INFO] [stderr] 124 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:379:28 [INFO] [stderr] | [INFO] [stderr] 379 | if name_pos == names.len() && !i_arg.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `name_pos == names.len() && i_arg.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:385:28 [INFO] [stderr] | [INFO] [stderr] 385 | if !i_arg.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i_arg.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:398:28 [INFO] [stderr] | [INFO] [stderr] 398 | if !i_arg.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i_arg.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the variable `name_pos` is used as a loop counter. Consider using `for (name_pos, item) in names.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:371:27 [INFO] [stderr] | [INFO] [stderr] 371 | for nm in names.iter() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:460:24 [INFO] [stderr] | [INFO] [stderr] 460 | if long_name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!long_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:807:12 [INFO] [stderr] | [INFO] [stderr] 807 | if candidate.aliases.iter().position(|opt| opt.name == nm).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `position(|opt| opt.name == nm).is_some()` with `any(|opt| opt.name == nm)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:845:8 [INFO] [stderr] | [INFO] [stderr] 845 | if opt.short_name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!opt.short_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:934:43 [INFO] [stderr] | [INFO] [stderr] 934 | &ss[last_start..i + 1]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `last_start..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:1514:11 [INFO] [stderr] | [INFO] [stderr] 1514 | Err(_) => panic!() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:1533:11 [INFO] [stderr] | [INFO] [stderr] 1533 | Err(_) => panic!() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:1559:11 [INFO] [stderr] | [INFO] [stderr] 1559 | Err(_) => panic!() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:1598:13 [INFO] [stderr] | [INFO] [stderr] 1598 | let ref verbose = opts.grps[0]; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let verbose = &opts.grps[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.42s [INFO] running `"docker" "inspect" "4b2c9d35f41fa5f96384f26e531a2bdb0a500149c6cbaedfd8242562dd0f5f17"` [INFO] running `"docker" "rm" "-f" "4b2c9d35f41fa5f96384f26e531a2bdb0a500149c6cbaedfd8242562dd0f5f17"` [INFO] [stdout] 4b2c9d35f41fa5f96384f26e531a2bdb0a500149c6cbaedfd8242562dd0f5f17