[INFO] crate periodic_table 0.1.1 is already in cache [INFO] extracting crate periodic_table 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/periodic_table/0.1.1 [INFO] extracting crate periodic_table 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/periodic_table/0.1.1 [INFO] validating manifest of periodic_table-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of periodic_table-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing periodic_table-0.1.1 [INFO] finished frobbing periodic_table-0.1.1 [INFO] frobbed toml for periodic_table-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/periodic_table/0.1.1/Cargo.toml [INFO] started frobbing periodic_table-0.1.1 [INFO] finished frobbing periodic_table-0.1.1 [INFO] frobbed toml for periodic_table-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/periodic_table/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting periodic_table-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/periodic_table/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9b38e08fc15a21c8a48a78700c27b770b1fd64f3debea05624752aff200f5bb5 [INFO] running `"docker" "start" "-a" "9b38e08fc15a21c8a48a78700c27b770b1fd64f3debea05624752aff200f5bb5"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking periodic_table v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | density: Some(0.0000899_f32), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_089_9_f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | density: Some(0.0001785_f32), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_178_5_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | density: Some(0.001251_f32), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.001_251_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | density: Some(0.001429_f32), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.001_429_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | density: Some(0.001696_f32), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.001_696_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:382:17 [INFO] [stderr] | [INFO] [stderr] 382 | density: Some(0.003214_f32), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.003_214_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:404:17 [INFO] [stderr] | [INFO] [stderr] 404 | density: Some(0.001784_f32), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.001_784_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | density: Some(0.0000899_f32), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_089_9_f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | density: Some(0.0001785_f32), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_178_5_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | density: Some(0.001251_f32), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.001_251_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | density: Some(0.001429_f32), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.001_429_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | density: Some(0.001696_f32), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.001_696_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:382:17 [INFO] [stderr] | [INFO] [stderr] 382 | density: Some(0.003214_f32), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.003_214_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:404:17 [INFO] [stderr] | [INFO] [stderr] 404 | density: Some(0.001784_f32), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.001_784_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test/mod.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | assert!(elements.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | items[6] = if items[6].len() == 0 { String::from("None") } else { format!("Some({}_f32)", items[6]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[6].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | items[7] = if items[7].len() == 0 { String::from("None") } else { format!("Some({})", items[7]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[7].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | items[8] = if items[8].len() == 0 { String::from("None") } else { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[8].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | items[9] = if items[9].len() == 0 { String::from("None") } else { format!("Some({})", items[9]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[9].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | items[10] = if items[10].len() == 0 { String::from("None") } else { format!("Some({})", items[10]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[10].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | items[11] = if items[11].len() == 0 { String::from("None") } else { format!("Some({})", items[11]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[11].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | items[13] = if items[13].len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!items[13].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | items[15] = if items[15].len() == 0 { String::from("None") } else { format!("Some({})", items[15]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[15].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | items[16] = if items[16].len() == 0 { String::from("None") } else { format!("Some({})", items[16]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[16].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | items[17] = if items[17].len() == 0 { String::from("None") } else { format!("Some({}_f32)", items[17]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[17].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | items[6] = if items[6].len() == 0 { String::from("None") } else { format!("Some({}_f32)", items[6]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[6].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | items[7] = if items[7].len() == 0 { String::from("None") } else { format!("Some({})", items[7]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[7].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | items[8] = if items[8].len() == 0 { String::from("None") } else { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[8].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | items[9] = if items[9].len() == 0 { String::from("None") } else { format!("Some({})", items[9]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[9].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | items[10] = if items[10].len() == 0 { String::from("None") } else { format!("Some({})", items[10]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[10].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | items[11] = if items[11].len() == 0 { String::from("None") } else { format!("Some({})", items[11]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[11].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | items[13] = if items[13].len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!items[13].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | items[15] = if items[15].len() == 0 { String::from("None") } else { format!("Some({})", items[15]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[15].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | items[16] = if items[16].len() == 0 { String::from("None") } else { format!("Some({})", items[16]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[16].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | items[17] = if items[17].len() == 0 { String::from("None") } else { format!("Some({}_f32)", items[17]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items[17].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.50s [INFO] running `"docker" "inspect" "9b38e08fc15a21c8a48a78700c27b770b1fd64f3debea05624752aff200f5bb5"` [INFO] running `"docker" "rm" "-f" "9b38e08fc15a21c8a48a78700c27b770b1fd64f3debea05624752aff200f5bb5"` [INFO] [stdout] 9b38e08fc15a21c8a48a78700c27b770b1fd64f3debea05624752aff200f5bb5