[INFO] crate perf 0.0.1 is already in cache [INFO] extracting crate perf 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/perf/0.0.1 [INFO] extracting crate perf 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/perf/0.0.1 [INFO] validating manifest of perf-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of perf-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing perf-0.0.1 [INFO] finished frobbing perf-0.0.1 [INFO] frobbed toml for perf-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/perf/0.0.1/Cargo.toml [INFO] started frobbing perf-0.0.1 [INFO] finished frobbing perf-0.0.1 [INFO] frobbed toml for perf-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/perf/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting perf-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/perf/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d973336360ced943933be9ce737e41101753b7eeb62dbfe43ab3b90782465602 [INFO] running `"docker" "start" "-a" "d973336360ced943933be9ce737e41101753b7eeb62dbfe43ab3b90782465602"` [INFO] [stderr] Checking perf v0.0.1 (/opt/crater/workdir) [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut ffi::perf_event_mmap_page`) [INFO] [stderr] --> src/map.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | header: (header as *mut perf_event_mmap_page).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/map.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | base: header.offset(pagesize as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `header.add(pagesize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/map.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub unsafe fn next(&mut self) -> Option { [INFO] [stderr] 72 | | if self.next == self.end { [INFO] [stderr] 73 | | return None; [INFO] [stderr] 74 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const ffi::perf_record_sample`) [INFO] [stderr] --> src/map.rs:76:27 [INFO] [stderr] | [INFO] [stderr] 76 | let mut event = &*(self.next as *const perf_record_sample); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const ffi::perf_record_sample`) [INFO] [stderr] --> src/map.rs:91:23 [INFO] [stderr] | [INFO] [stderr] 91 | event = &*(self.extra as *const perf_record_sample); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | PERF_SAMPLE_IP = 1 << 0, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: casting from `*const ffi::perf_record_sample` to a more-strictly-aligned pointer (`*const ffi::perf_record_lost`) [INFO] [stderr] --> src/ffi.rs:235:15 [INFO] [stderr] | [INFO] [stderr] 235 | &*(e as *const _ as *const perf_record_lost) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/sys.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | match syscall(SYS_perf_event_open, attr, pid, cpu, group_fd, flags) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `perf`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut ffi::perf_event_mmap_page`) [INFO] [stderr] --> src/map.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | header: (header as *mut perf_event_mmap_page).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/map.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | base: header.offset(pagesize as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `header.add(pagesize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/map.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub unsafe fn next(&mut self) -> Option { [INFO] [stderr] 72 | | if self.next == self.end { [INFO] [stderr] 73 | | return None; [INFO] [stderr] 74 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const ffi::perf_record_sample`) [INFO] [stderr] --> src/map.rs:76:27 [INFO] [stderr] | [INFO] [stderr] 76 | let mut event = &*(self.next as *const perf_record_sample); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const ffi::perf_record_sample`) [INFO] [stderr] --> src/map.rs:91:23 [INFO] [stderr] | [INFO] [stderr] 91 | event = &*(self.extra as *const perf_record_sample); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | PERF_SAMPLE_IP = 1 << 0, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: casting from `*const ffi::perf_record_sample` to a more-strictly-aligned pointer (`*const ffi::perf_record_lost`) [INFO] [stderr] --> src/ffi.rs:235:15 [INFO] [stderr] | [INFO] [stderr] 235 | &*(e as *const _ as *const perf_record_lost) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/sys.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | match syscall(SYS_perf_event_open, attr, pid, cpu, group_fd, flags) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `perf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d973336360ced943933be9ce737e41101753b7eeb62dbfe43ab3b90782465602"` [INFO] running `"docker" "rm" "-f" "d973336360ced943933be9ce737e41101753b7eeb62dbfe43ab3b90782465602"` [INFO] [stdout] d973336360ced943933be9ce737e41101753b7eeb62dbfe43ab3b90782465602