[INFO] crate peresil 0.4.0-alpha.0 is already in cache [INFO] extracting crate peresil 0.4.0-alpha.0 into work/ex/clippy-test-run/sources/stable/reg/peresil/0.4.0-alpha.0 [INFO] extracting crate peresil 0.4.0-alpha.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/peresil/0.4.0-alpha.0 [INFO] validating manifest of peresil-0.4.0-alpha.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of peresil-0.4.0-alpha.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing peresil-0.4.0-alpha.0 [INFO] finished frobbing peresil-0.4.0-alpha.0 [INFO] frobbed toml for peresil-0.4.0-alpha.0 written to work/ex/clippy-test-run/sources/stable/reg/peresil/0.4.0-alpha.0/Cargo.toml [INFO] started frobbing peresil-0.4.0-alpha.0 [INFO] finished frobbing peresil-0.4.0-alpha.0 [INFO] frobbed toml for peresil-0.4.0-alpha.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/peresil/0.4.0-alpha.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting peresil-0.4.0-alpha.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/peresil/0.4.0-alpha.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e8eb3498e926782be046a6bf5bd728586046add0cb2e7815461b2ef66d427e8 [INFO] running `"docker" "start" "-a" "5e8eb3498e926782be046a6bf5bd728586046add0cb2e7815461b2ef66d427e8"` [INFO] [stderr] Checking peresil v0.4.0-alpha.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:192:20 [INFO] [stderr] | [INFO] [stderr] 192 | Progress { point: point, status: Status::Success(val) } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:196:20 [INFO] [stderr] | [INFO] [stderr] 196 | Progress { point: point, status: Status::Failure(val) } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:277:57 [INFO] [stderr] | [INFO] [stderr] 277 | Progress { status: Status::Failure(()), point: point } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:340:71 [INFO] [stderr] | [INFO] [stderr] 340 | return Progress { status: Status::Failure(f), point: point }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:453:23 [INFO] [stderr] | [INFO] [stderr] 453 | StringPoint { s: s, offset: 0 } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:192:20 [INFO] [stderr] | [INFO] [stderr] 192 | Progress { point: point, status: Status::Success(val) } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:196:20 [INFO] [stderr] | [INFO] [stderr] 196 | Progress { point: point, status: Status::Failure(val) } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:277:57 [INFO] [stderr] | [INFO] [stderr] 277 | Progress { status: Status::Failure(()), point: point } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:340:71 [INFO] [stderr] | [INFO] [stderr] 340 | return Progress { status: Status::Failure(f), point: point }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:453:23 [INFO] [stderr] | [INFO] [stderr] 453 | StringPoint { s: s, offset: 0 } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ParseMaster` [INFO] [stderr] --> src/lib.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | / pub fn new() -> ParseMaster { [INFO] [stderr] 253 | | ParseMaster::with_state(()) [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 248 | impl Default for ParseMaster { [INFO] [stderr] 249 | fn default() -> Self { [INFO] [stderr] 250 | Self::new() [INFO] [stderr] 251 | } [INFO] [stderr] 252 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | / pub fn alternate<'pm, T>(&'pm mut self, pt: P) -> Alternate<'pm, P, T, E, S> { [INFO] [stderr] 309 | | Alternate { [INFO] [stderr] 310 | | master: self, [INFO] [stderr] 311 | | current: None, [INFO] [stderr] 312 | | point: pt, [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/ingredient_list.rs:131:43 [INFO] [stderr] | [INFO] [stderr] 131 | let i = Ingredient { amount: Amount { size: size, unit: unit }, name: name.to_owned() }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/ingredient_list.rs:131:55 [INFO] [stderr] | [INFO] [stderr] 131 | let i = Ingredient { amount: Amount { size: size, unit: unit }, name: name.to_owned() }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ParseMaster` [INFO] [stderr] --> src/lib.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | / pub fn new() -> ParseMaster { [INFO] [stderr] 253 | | ParseMaster::with_state(()) [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 248 | impl Default for ParseMaster { [INFO] [stderr] 249 | fn default() -> Self { [INFO] [stderr] 250 | Self::new() [INFO] [stderr] 251 | } [INFO] [stderr] 252 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | / pub fn alternate<'pm, T>(&'pm mut self, pt: P) -> Alternate<'pm, P, T, E, S> { [INFO] [stderr] 309 | | Alternate { [INFO] [stderr] 310 | | master: self, [INFO] [stderr] 311 | | current: None, [INFO] [stderr] 312 | | point: pt, [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:897:9 [INFO] [stderr] | [INFO] [stderr] 897 | / fn all<'a>(pt: StringPoint<'a>) -> StringProgress<'a, (&'a str, &'a str, &'a str)> { [INFO] [stderr] 898 | | let (pt, a) = try_parse!(pt.consume_literal("a").map_err(|_| AnError(1))); [INFO] [stderr] 899 | | let (pt, b) = try_parse!(pt.consume_literal("b").map_err(|_| AnError(2))); [INFO] [stderr] 900 | | let (pt, c) = try_parse!(pt.consume_literal("c").map_err(|_| AnError(3))); [INFO] [stderr] 901 | | [INFO] [stderr] 902 | | Progress { point: pt, status: Status::Success((a,b,c)) } [INFO] [stderr] 903 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> tests/calculator.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | Num(v) => v as i32, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.77s [INFO] running `"docker" "inspect" "5e8eb3498e926782be046a6bf5bd728586046add0cb2e7815461b2ef66d427e8"` [INFO] running `"docker" "rm" "-f" "5e8eb3498e926782be046a6bf5bd728586046add0cb2e7815461b2ef66d427e8"` [INFO] [stdout] 5e8eb3498e926782be046a6bf5bd728586046add0cb2e7815461b2ef66d427e8