[INFO] crate pemmican 0.4.0 is already in cache [INFO] extracting crate pemmican 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/pemmican/0.4.0 [INFO] extracting crate pemmican 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pemmican/0.4.0 [INFO] validating manifest of pemmican-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pemmican-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pemmican-0.4.0 [INFO] finished frobbing pemmican-0.4.0 [INFO] frobbed toml for pemmican-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/pemmican/0.4.0/Cargo.toml [INFO] started frobbing pemmican-0.4.0 [INFO] finished frobbing pemmican-0.4.0 [INFO] frobbed toml for pemmican-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pemmican/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pemmican-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pemmican/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 77e6603c1f57ffa9d5b073fc42502065037add176dfb2072e607312e0c169f1f [INFO] running `"docker" "start" "-a" "77e6603c1f57ffa9d5b073fc42502065037add176dfb2072e607312e0c169f1f"` [INFO] [stderr] Checking parking_lot v0.3.8 [INFO] [stderr] Checking textnonce v0.6.4 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking chashmap v2.2.0 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking pemmican v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shared.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/htdocs.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/session.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | cookie_name: cookie_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cookie_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/session.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | secure: secure, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/session.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | http_only: http_only, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_only` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | plugins: plugins, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `plugins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shared.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/htdocs.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/session.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | cookie_name: cookie_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cookie_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/session.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | secure: secure, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/session.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | http_only: http_only, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_only` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | plugins: plugins, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `plugins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/plugins/good_citizen.rs:43:63 [INFO] [stderr] | [INFO] [stderr] 43 | StrictTransportSecurity::including_subdomains(31536000u64)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `31_536_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/plugins/good_citizen.rs:43:63 [INFO] [stderr] | [INFO] [stderr] 43 | StrictTransportSecurity::including_subdomains(31536000u64)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `31_536_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plugins::router::Router` [INFO] [stderr] --> src/plugins/router.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Router { [INFO] [stderr] 17 | | Router { [INFO] [stderr] 18 | | routes: CHashMap::new() [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plugins::page_visits::PageVisits` [INFO] [stderr] --> src/plugins/page_visits.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> PageVisits { [INFO] [stderr] 16 | | PageVisits { [INFO] [stderr] 17 | | counts: CHashMap::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/plugins/page_visits.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | self.counts.get(&url_path).map(|guard| *guard) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.counts.get(&url_path).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/htdocs.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match data.request.method() { [INFO] [stderr] 45 | | &Method::Get | &Method::Head => { }, [INFO] [stderr] 46 | | _ => return Box::new(::futures::future::ok(data)), [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | match *data.request.method() { [INFO] [stderr] 45 | Method::Get | Method::Head => { }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/plugins/htdocs.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | / match component { [INFO] [stderr] 56 | | Component::Normal(osstr) => output.push(osstr), [INFO] [stderr] 57 | | _ => {}, [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Component::Normal(osstr) = component { output.push(osstr) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plugins::router::Router` [INFO] [stderr] --> src/plugins/router.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Router { [INFO] [stderr] 17 | | Router { [INFO] [stderr] 18 | | routes: CHashMap::new() [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plugins::page_visits::PageVisits` [INFO] [stderr] --> src/plugins/page_visits.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> PageVisits { [INFO] [stderr] 16 | | PageVisits { [INFO] [stderr] 17 | | counts: CHashMap::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/plugins/page_visits.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | self.counts.get(&url_path).map(|guard| *guard) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.counts.get(&url_path).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/htdocs.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match data.request.method() { [INFO] [stderr] 45 | | &Method::Get | &Method::Head => { }, [INFO] [stderr] 46 | | _ => return Box::new(::futures::future::ok(data)), [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | match *data.request.method() { [INFO] [stderr] 45 | Method::Get | Method::Head => { }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/plugins/htdocs.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | / match component { [INFO] [stderr] 56 | | Component::Normal(osstr) => output.push(osstr), [INFO] [stderr] 57 | | _ => {}, [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Component::Normal(osstr) = component { output.push(osstr) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/dynamic.rs:17:28 [INFO] [stderr] | [INFO] [stderr] 17 | data.response.set_body(format!("Hello World!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello World!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/basic.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | data.response.set_body(format!("Hello World!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello World!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/plugin.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | format!("We dont know how many times this page has been accessed.\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"We dont know how many times this page has been accessed.\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/htdocs.rs:17:28 [INFO] [stderr] | [INFO] [stderr] 17 | data.response.set_body(format!("Hello World!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello World!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.60s [INFO] running `"docker" "inspect" "77e6603c1f57ffa9d5b073fc42502065037add176dfb2072e607312e0c169f1f"` [INFO] running `"docker" "rm" "-f" "77e6603c1f57ffa9d5b073fc42502065037add176dfb2072e607312e0c169f1f"` [INFO] [stdout] 77e6603c1f57ffa9d5b073fc42502065037add176dfb2072e607312e0c169f1f