[INFO] crate pem 0.5.1 is already in cache [INFO] extracting crate pem 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/pem/0.5.1 [INFO] extracting crate pem 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pem/0.5.1 [INFO] validating manifest of pem-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pem-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pem-0.5.1 [INFO] finished frobbing pem-0.5.1 [INFO] frobbed toml for pem-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/pem/0.5.1/Cargo.toml [INFO] started frobbing pem-0.5.1 [INFO] finished frobbing pem-0.5.1 [INFO] frobbed toml for pem-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pem/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pem-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pem/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd87e7d8d70a86ff6d79b47357348820899f02ecee59b36bb7ee19a2b751ae65 [INFO] running `"docker" "start" "-a" "dd87e7d8d70a86ff6d79b47357348820899f02ecee59b36bb7ee19a2b751ae65"` [INFO] [stderr] Checking pem v0.5.1 (/opt/crater/workdir) [INFO] [stderr] Checking criterion v0.2.9 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:163:16 [INFO] [stderr] | [INFO] [stderr] 163 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:114:19 [INFO] [stderr] | [INFO] [stderr] 114 | const REGEX_STR: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | / let contents; [INFO] [stderr] 309 | | [INFO] [stderr] 310 | | if pem.contents.is_empty() { [INFO] [stderr] 311 | | contents = String::from(""); [INFO] [stderr] ... | [INFO] [stderr] 318 | | )); [INFO] [stderr] 319 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 308 | let contents = if pem.contents.is_empty() { String::from("") } else { base64::encode_config(&pem.contents, base64::Config::new( [INFO] [stderr] 309 | base64::CharacterSet::Standard, [INFO] [stderr] 310 | true, [INFO] [stderr] 311 | true, [INFO] [stderr] 312 | base64::LineWrap::Wrap(64, base64::LineEnding::CRLF) [INFO] [stderr] 313 | )) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:163:16 [INFO] [stderr] | [INFO] [stderr] 163 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:114:19 [INFO] [stderr] | [INFO] [stderr] 114 | const REGEX_STR: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | const SAMPLE: &'static str = "-----BEGIN RSA PRIVATE KEY-----\r [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | / let contents; [INFO] [stderr] 309 | | [INFO] [stderr] 310 | | if pem.contents.is_empty() { [INFO] [stderr] 311 | | contents = String::from(""); [INFO] [stderr] ... | [INFO] [stderr] 318 | | )); [INFO] [stderr] 319 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 308 | let contents = if pem.contents.is_empty() { String::from("") } else { base64::encode_config(&pem.contents, base64::Config::new( [INFO] [stderr] 309 | base64::CharacterSet::Standard, [INFO] [stderr] 310 | true, [INFO] [stderr] 311 | true, [INFO] [stderr] 312 | base64::LineWrap::Wrap(64, base64::LineEnding::CRLF) [INFO] [stderr] 313 | )) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> benches/pem_benchmark.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const SAMPLE: &'static str = "-----BEGIN RSA PRIVATE KEY-----\r [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> benches/pem_benchmark.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | fn pem_encode_many(pems: &std::vec::Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[pem::Pem]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/pem_benchmark.rs:48:47 [INFO] [stderr] | [INFO] [stderr] 48 | c.bench_function("pem::parse", |b| b.iter(|| pem_parse())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `pem_parse` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/pem_benchmark.rs:49:52 [INFO] [stderr] | [INFO] [stderr] 49 | c.bench_function("pem::parse_many", |b| b.iter(|| pem_parse_many())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `pem_parse_many` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.84s [INFO] running `"docker" "inspect" "dd87e7d8d70a86ff6d79b47357348820899f02ecee59b36bb7ee19a2b751ae65"` [INFO] running `"docker" "rm" "-f" "dd87e7d8d70a86ff6d79b47357348820899f02ecee59b36bb7ee19a2b751ae65"` [INFO] [stdout] dd87e7d8d70a86ff6d79b47357348820899f02ecee59b36bb7ee19a2b751ae65