[INFO] crate pdfutil 0.2.0 is already in cache [INFO] extracting crate pdfutil 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/pdfutil/0.2.0 [INFO] extracting crate pdfutil 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdfutil/0.2.0 [INFO] validating manifest of pdfutil-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pdfutil-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pdfutil-0.2.0 [INFO] finished frobbing pdfutil-0.2.0 [INFO] frobbed toml for pdfutil-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/pdfutil/0.2.0/Cargo.toml [INFO] started frobbing pdfutil-0.2.0 [INFO] finished frobbing pdfutil-0.2.0 [INFO] frobbed toml for pdfutil-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdfutil/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pdfutil-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pdfutil/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6eb6750ade585dabd0e74c4cb453c9cd10856889fb554f26f6f85d918f25b56a [INFO] running `"docker" "start" "-a" "6eb6750ade585dabd0e74c4cb453c9cd10856889fb554f26f6f85d918f25b56a"` [INFO] [stderr] Checking lopdf v0.13.0 [INFO] [stderr] Checking pdfutil v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:111:7 [INFO] [stderr] | [INFO] [stderr] 111 | match *object { [INFO] [stderr] | _________________________^ [INFO] [stderr] 112 | | Object::Stream(ref stream) => println!("{:?}", stream.dict), [INFO] [stderr] 113 | | _ => () [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let Object::Stream(ref stream) = *object { println!("{:?}", stream.dict) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the `operation @ _` pattern can be written as just `operation` [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | operation @ _ => { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:142:8 [INFO] [stderr] | [INFO] [stderr] 142 | if streams.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!streams.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:156:35 [INFO] [stderr] | [INFO] [stderr] 156 | 2 => page_numbers.append(&mut (nums[0]..nums[1]+1).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(nums[0]..=nums[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:165:15 [INFO] [stderr] | [INFO] [stderr] 165 | for page in 1..(total + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:111:7 [INFO] [stderr] | [INFO] [stderr] 111 | match *object { [INFO] [stderr] | _________________________^ [INFO] [stderr] 112 | | Object::Stream(ref stream) => println!("{:?}", stream.dict), [INFO] [stderr] 113 | | _ => () [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let Object::Stream(ref stream) = *object { println!("{:?}", stream.dict) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the `operation @ _` pattern can be written as just `operation` [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | operation @ _ => { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:142:8 [INFO] [stderr] | [INFO] [stderr] 142 | if streams.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!streams.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:156:35 [INFO] [stderr] | [INFO] [stderr] 156 | 2 => page_numbers.append(&mut (nums[0]..nums[1]+1).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(nums[0]..=nums[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:165:15 [INFO] [stderr] | [INFO] [stderr] 165 | for page in 1..(total + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.93s [INFO] running `"docker" "inspect" "6eb6750ade585dabd0e74c4cb453c9cd10856889fb554f26f6f85d918f25b56a"` [INFO] running `"docker" "rm" "-f" "6eb6750ade585dabd0e74c4cb453c9cd10856889fb554f26f6f85d918f25b56a"` [INFO] [stdout] 6eb6750ade585dabd0e74c4cb453c9cd10856889fb554f26f6f85d918f25b56a