[INFO] crate pdf_form 0.2.0 is already in cache
[INFO] extracting crate pdf_form 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/pdf_form/0.2.0
[INFO] extracting crate pdf_form 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdf_form/0.2.0
[INFO] validating manifest of pdf_form-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pdf_form-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pdf_form-0.2.0
[INFO] finished frobbing pdf_form-0.2.0
[INFO] frobbed toml for pdf_form-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/pdf_form/0.2.0/Cargo.toml
[INFO] started frobbing pdf_form-0.2.0
[INFO] finished frobbing pdf_form-0.2.0
[INFO] frobbed toml for pdf_form-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdf_form/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pdf_form-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pdf_form/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8976e36939184c2d31ebae09d0d42170bb272ff6bc070698da4fb0317401465e
[INFO] running `"docker" "start" "-a" "8976e36939184c2d31ebae09d0d42170bb272ff6bc070698da4fb0317401465e"`
[INFO] [stderr]     Checking png v0.12.0
[INFO] [stderr]     Checking image v0.19.0
[INFO] [stderr]     Checking lopdf v0.15.3
[INFO] [stderr]     Checking pdf_form v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:19:35
[INFO] [stderr]    |
[INFO] [stderr] 19 |         const RADIO_IN_UNISON   = 0x4000000;
[INFO] [stderr]    |                                   ^^^^^^^^^ help: consider: `0x0400_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:28:35
[INFO] [stderr]    |
[INFO] [stderr] 28 |         const SORT              = 0x100000;
[INFO] [stderr]    |                                   ^^^^^^^^ help: consider: `0x0010_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:29:35
[INFO] [stderr]    |
[INFO] [stderr] 29 |         const MULTISELECT       = 0x400000;
[INFO] [stderr]    |                                   ^^^^^^^^ help: consider: `0x0040_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:30:35
[INFO] [stderr]    |
[INFO] [stderr] 30 |         const DO_NOT_SPELLCHECK = 0x800000;
[INFO] [stderr]    |                                   ^^^^^^^^ help: consider: `0x0080_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:31:35
[INFO] [stderr]    |
[INFO] [stderr] 31 |         const COMMIT_ON_CHANGE  = 0x8000000;
[INFO] [stderr]    |                                   ^^^^^^^^^ help: consider: `0x0800_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:391:33
[INFO] [stderr]     |
[INFO] [stderr] 391 |             FieldState::Radio { selected: _,  options } => if options.contains(&choice) {
[INFO] [stderr]     |                                 ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Radio { options, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:410:35
[INFO] [stderr]     |
[INFO] [stderr] 410 |             FieldState::ListBox { selected: _, options, multiselect } | FieldState::ComboBox { selected: _, options, multiselect } => if choices.iter().fold(true, |a,h| options.contains(h) && a) {
[INFO] [stderr]     |                                   ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `ListBox { options, multiselect, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:410:96
[INFO] [stderr]     |
[INFO] [stderr] 410 |             FieldState::ListBox { selected: _, options, multiselect } | FieldState::ComboBox { selected: _, options, multiselect } => if choices.iter().fold(true, |a,h| options.contains(h) && a) {
[INFO] [stderr]     |                                                                                                ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `ComboBox { options, multiselect, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 | /         match self {
[INFO] [stderr] 107 | |             &Object::Reference(oid) => doc.objects.get(&oid).ok_or(LoadError::NoSuchReference(oid)),
[INFO] [stderr] 108 | |             _ => Err(LoadError::NotAReference)
[INFO] [stderr] 109 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 106 |         match *self {
[INFO] [stderr] 107 |             Object::Reference(oid) => doc.objects.get(&oid).ok_or(LoadError::NoSuchReference(oid)),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:107:62
[INFO] [stderr]     |
[INFO] [stderr] 107 |             &Object::Reference(oid) => doc.objects.get(&oid).ok_or(LoadError::NoSuchReference(oid)),
[INFO] [stderr]     |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| LoadError::NoSuchReference(oid))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: item `Form` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:113:1
[INFO] [stderr]     |
[INFO] [stderr] 113 | / impl Form {
[INFO] [stderr] 114 | |
[INFO] [stderr] 115 | |     /// Takes a reader containing a PDF with a fillable form, analyzes the content, and attempts to
[INFO] [stderr] 116 | |     /// identify all of the fields the form has.
[INFO] [stderr] ...   |
[INFO] [stderr] 437 | |     }
[INFO] [stderr] 438 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:152:17
[INFO] [stderr]     |
[INFO] [stderr] 152 | /                 if let &Object::Dictionary(ref dict) = obj {
[INFO] [stderr] 153 | |                     // If the field has FT, it actually takes input.  Save this
[INFO] [stderr] 154 | |                     if let Some(_) = dict.get("FT") {
[INFO] [stderr] 155 | |                         form_ids.push(objref.as_reference().unwrap());
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |                     }
[INFO] [stderr] 161 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 152 |                 if let Object::Dictionary(ref dict) = *obj {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/lib.rs:154:28
[INFO] [stderr]     |
[INFO] [stderr] 154 |                       if let Some(_) = dict.get("FT") {
[INFO] [stderr]     |  _____________________-      ^^^^^^^
[INFO] [stderr] 155 | |                         form_ids.push(objref.as_reference().unwrap());
[INFO] [stderr] 156 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if dict.get("FT").is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:178:21
[INFO] [stderr]     |
[INFO] [stderr] 178 |         let field = self.doc.objects.get(&self.form_ids[n]).unwrap().as_dict().unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.doc.objects[&self.form_ids[n]]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:216:21
[INFO] [stderr]     |
[INFO] [stderr] 216 |         let field = self.doc.objects.get(&self.form_ids[n]).unwrap().as_dict().unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.doc.objects[&self.form_ids[n]]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:231:35
[INFO] [stderr]     |
[INFO] [stderr] 231 |                     Some(name) => if name.as_name_str().unwrap() == "Yes" { true } else { false },
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `name.as_name_str().unwrap() == "Yes"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:233:39
[INFO] [stderr]     |
[INFO] [stderr] 233 |                         Some(name) => if name.as_name_str().unwrap() == "Yes" { true } else { false },
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `name.as_name_str().unwrap() == "Yes"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:242:40
[INFO] [stderr]     |
[INFO] [stderr] 242 |                       Some(selection) => match selection {
[INFO] [stderr]     |  ________________________________________^
[INFO] [stderr] 243 | |                         &Object::String(ref s,StringFormat::Literal) => vec![str::from_utf8(&s).unwrap().to_owned()],
[INFO] [stderr] 244 | |                         &Object::Array(ref chosen) => {
[INFO] [stderr] 245 | |                             let mut res = Vec::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 253 | |                         _ => Vec::new()
[INFO] [stderr] 254 | |                     },
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 242 |                     Some(selection) => match *selection {
[INFO] [stderr] 243 |                         Object::String(ref s,StringFormat::Literal) => vec![str::from_utf8(&s).unwrap().to_owned()],
[INFO] [stderr] 244 |                         Object::Array(ref chosen) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:247:33
[INFO] [stderr]     |
[INFO] [stderr] 247 | /                                 if let &Object::String(ref s,StringFormat::Literal) = obj {
[INFO] [stderr] 248 | |                                     res.push(str::from_utf8(&s).unwrap().to_owned());
[INFO] [stderr] 249 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 247 |                                 if let Object::String(ref s,StringFormat::Literal) = *obj {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:261:25
[INFO] [stderr]     |
[INFO] [stderr] 261 | /                         match x {
[INFO] [stderr] 262 | |                             &Object::String(ref s,StringFormat::Literal) => str::from_utf8(&s).unwrap().to_owned(),
[INFO] [stderr] 263 | |                             &Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr] 264 | |                                 str::from_utf8(&s).unwrap().to_owned()
[INFO] [stderr] ...   |
[INFO] [stderr] 268 | |                             _ => String::new()
[INFO] [stderr] 269 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 261 |                         match *x {
[INFO] [stderr] 262 |                             Object::String(ref s,StringFormat::Literal) => str::from_utf8(&s).unwrap().to_owned(),
[INFO] [stderr] 263 |                             Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:263:56
[INFO] [stderr]     |
[INFO] [stderr] 263 |                               &Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr]     |  ________________________________________________________^
[INFO] [stderr] 264 | |                                 str::from_utf8(&s).unwrap().to_owned()
[INFO] [stderr] 265 | |                             } else {
[INFO] [stderr] 266 | |                                 String::new()
[INFO] [stderr] 267 | |                             },
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 263 |                             &Object::Array(ref arr) => if let Object::String(ref s,StringFormat::Literal) = arr[1] {
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:270:35
[INFO] [stderr]     |
[INFO] [stderr] 270 |                     }).filter(|x| x.len() > 0).collect(),
[INFO] [stderr]     |                                   ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:283:40
[INFO] [stderr]     |
[INFO] [stderr] 283 |                       Some(selection) => match selection {
[INFO] [stderr]     |  ________________________________________^
[INFO] [stderr] 284 | |                         &Object::String(ref s,StringFormat::Literal) => vec![str::from_utf8(&s).unwrap().to_owned()],
[INFO] [stderr] 285 | |                         &Object::Array(ref chosen) => {
[INFO] [stderr] 286 | |                             let mut res = Vec::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 294 | |                         _ => Vec::new()
[INFO] [stderr] 295 | |                     },
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 283 |                     Some(selection) => match *selection {
[INFO] [stderr] 284 |                         Object::String(ref s,StringFormat::Literal) => vec![str::from_utf8(&s).unwrap().to_owned()],
[INFO] [stderr] 285 |                         Object::Array(ref chosen) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:288:33
[INFO] [stderr]     |
[INFO] [stderr] 288 | /                                 if let &Object::String(ref s,StringFormat::Literal) = obj {
[INFO] [stderr] 289 | |                                     res.push(str::from_utf8(&s).unwrap().to_owned());
[INFO] [stderr] 290 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 288 |                                 if let Object::String(ref s,StringFormat::Literal) = *obj {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:302:25
[INFO] [stderr]     |
[INFO] [stderr] 302 | /                         match x {
[INFO] [stderr] 303 | |                             &Object::String(ref s,StringFormat::Literal) => str::from_utf8(&s).unwrap().to_owned(),
[INFO] [stderr] 304 | |                             &Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr] 305 | |                                 str::from_utf8(&s).unwrap().to_owned()
[INFO] [stderr] ...   |
[INFO] [stderr] 309 | |                             _ => String::new()
[INFO] [stderr] 310 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 302 |                         match *x {
[INFO] [stderr] 303 |                             Object::String(ref s,StringFormat::Literal) => str::from_utf8(&s).unwrap().to_owned(),
[INFO] [stderr] 304 |                             Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:304:56
[INFO] [stderr]     |
[INFO] [stderr] 304 |                               &Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr]     |  ________________________________________________________^
[INFO] [stderr] 305 | |                                 str::from_utf8(&s).unwrap().to_owned()
[INFO] [stderr] 306 | |                             } else {
[INFO] [stderr] 307 | |                                 String::new()
[INFO] [stderr] 308 | |                             },
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 304 |                             &Object::Array(ref arr) => if let Object::String(ref s,StringFormat::Literal) = arr[1] {
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:311:35
[INFO] [stderr]     |
[INFO] [stderr] 311 |                     }).filter(|x| x.len() > 0).collect(),
[INFO] [stderr]     |                                   ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:352:24
[INFO] [stderr]     |
[INFO] [stderr] 352 |         let kids_obj = self.doc.objects.get(&oid).unwrap().as_dict().unwrap().get("Kids");
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.doc.objects[&oid]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:19:35
[INFO] [stderr]    |
[INFO] [stderr] 19 |         const RADIO_IN_UNISON   = 0x4000000;
[INFO] [stderr]    |                                   ^^^^^^^^^ help: consider: `0x0400_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:28:35
[INFO] [stderr]    |
[INFO] [stderr] 28 |         const SORT              = 0x100000;
[INFO] [stderr]    |                                   ^^^^^^^^ help: consider: `0x0010_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:29:35
[INFO] [stderr]    |
[INFO] [stderr] 29 |         const MULTISELECT       = 0x400000;
[INFO] [stderr]    |                                   ^^^^^^^^ help: consider: `0x0040_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:30:35
[INFO] [stderr]    |
[INFO] [stderr] 30 |         const DO_NOT_SPELLCHECK = 0x800000;
[INFO] [stderr]    |                                   ^^^^^^^^ help: consider: `0x0080_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:31:35
[INFO] [stderr]    |
[INFO] [stderr] 31 |         const COMMIT_ON_CHANGE  = 0x8000000;
[INFO] [stderr]    |                                   ^^^^^^^^^ help: consider: `0x0800_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:391:33
[INFO] [stderr]     |
[INFO] [stderr] 391 |             FieldState::Radio { selected: _,  options } => if options.contains(&choice) {
[INFO] [stderr]     |                                 ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Radio { options, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:410:35
[INFO] [stderr]     |
[INFO] [stderr] 410 |             FieldState::ListBox { selected: _, options, multiselect } | FieldState::ComboBox { selected: _, options, multiselect } => if choices.iter().fold(true, |a,h| options.contains(h) && a) {
[INFO] [stderr]     |                                   ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `ListBox { options, multiselect, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:410:96
[INFO] [stderr]     |
[INFO] [stderr] 410 |             FieldState::ListBox { selected: _, options, multiselect } | FieldState::ComboBox { selected: _, options, multiselect } => if choices.iter().fold(true, |a,h| options.contains(h) && a) {
[INFO] [stderr]     |                                                                                                ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `ComboBox { options, multiselect, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 | /         match self {
[INFO] [stderr] 107 | |             &Object::Reference(oid) => doc.objects.get(&oid).ok_or(LoadError::NoSuchReference(oid)),
[INFO] [stderr] 108 | |             _ => Err(LoadError::NotAReference)
[INFO] [stderr] 109 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 106 |         match *self {
[INFO] [stderr] 107 |             Object::Reference(oid) => doc.objects.get(&oid).ok_or(LoadError::NoSuchReference(oid)),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:107:62
[INFO] [stderr]     |
[INFO] [stderr] 107 |             &Object::Reference(oid) => doc.objects.get(&oid).ok_or(LoadError::NoSuchReference(oid)),
[INFO] [stderr]     |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| LoadError::NoSuchReference(oid))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: item `Form` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:113:1
[INFO] [stderr]     |
[INFO] [stderr] 113 | / impl Form {
[INFO] [stderr] 114 | |
[INFO] [stderr] 115 | |     /// Takes a reader containing a PDF with a fillable form, analyzes the content, and attempts to
[INFO] [stderr] 116 | |     /// identify all of the fields the form has.
[INFO] [stderr] ...   |
[INFO] [stderr] 437 | |     }
[INFO] [stderr] 438 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:152:17
[INFO] [stderr]     |
[INFO] [stderr] 152 | /                 if let &Object::Dictionary(ref dict) = obj {
[INFO] [stderr] 153 | |                     // If the field has FT, it actually takes input.  Save this
[INFO] [stderr] 154 | |                     if let Some(_) = dict.get("FT") {
[INFO] [stderr] 155 | |                         form_ids.push(objref.as_reference().unwrap());
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |                     }
[INFO] [stderr] 161 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 152 |                 if let Object::Dictionary(ref dict) = *obj {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/lib.rs:154:28
[INFO] [stderr]     |
[INFO] [stderr] 154 |                       if let Some(_) = dict.get("FT") {
[INFO] [stderr]     |  _____________________-      ^^^^^^^
[INFO] [stderr] 155 | |                         form_ids.push(objref.as_reference().unwrap());
[INFO] [stderr] 156 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if dict.get("FT").is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:178:21
[INFO] [stderr]     |
[INFO] [stderr] 178 |         let field = self.doc.objects.get(&self.form_ids[n]).unwrap().as_dict().unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.doc.objects[&self.form_ids[n]]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:216:21
[INFO] [stderr]     |
[INFO] [stderr] 216 |         let field = self.doc.objects.get(&self.form_ids[n]).unwrap().as_dict().unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.doc.objects[&self.form_ids[n]]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:231:35
[INFO] [stderr]     |
[INFO] [stderr] 231 |                     Some(name) => if name.as_name_str().unwrap() == "Yes" { true } else { false },
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `name.as_name_str().unwrap() == "Yes"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:233:39
[INFO] [stderr]     |
[INFO] [stderr] 233 |                         Some(name) => if name.as_name_str().unwrap() == "Yes" { true } else { false },
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `name.as_name_str().unwrap() == "Yes"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:242:40
[INFO] [stderr]     |
[INFO] [stderr] 242 |                       Some(selection) => match selection {
[INFO] [stderr]     |  ________________________________________^
[INFO] [stderr] 243 | |                         &Object::String(ref s,StringFormat::Literal) => vec![str::from_utf8(&s).unwrap().to_owned()],
[INFO] [stderr] 244 | |                         &Object::Array(ref chosen) => {
[INFO] [stderr] 245 | |                             let mut res = Vec::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 253 | |                         _ => Vec::new()
[INFO] [stderr] 254 | |                     },
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 242 |                     Some(selection) => match *selection {
[INFO] [stderr] 243 |                         Object::String(ref s,StringFormat::Literal) => vec![str::from_utf8(&s).unwrap().to_owned()],
[INFO] [stderr] 244 |                         Object::Array(ref chosen) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:247:33
[INFO] [stderr]     |
[INFO] [stderr] 247 | /                                 if let &Object::String(ref s,StringFormat::Literal) = obj {
[INFO] [stderr] 248 | |                                     res.push(str::from_utf8(&s).unwrap().to_owned());
[INFO] [stderr] 249 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 247 |                                 if let Object::String(ref s,StringFormat::Literal) = *obj {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:261:25
[INFO] [stderr]     |
[INFO] [stderr] 261 | /                         match x {
[INFO] [stderr] 262 | |                             &Object::String(ref s,StringFormat::Literal) => str::from_utf8(&s).unwrap().to_owned(),
[INFO] [stderr] 263 | |                             &Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr] 264 | |                                 str::from_utf8(&s).unwrap().to_owned()
[INFO] [stderr] ...   |
[INFO] [stderr] 268 | |                             _ => String::new()
[INFO] [stderr] 269 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 261 |                         match *x {
[INFO] [stderr] 262 |                             Object::String(ref s,StringFormat::Literal) => str::from_utf8(&s).unwrap().to_owned(),
[INFO] [stderr] 263 |                             Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:263:56
[INFO] [stderr]     |
[INFO] [stderr] 263 |                               &Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr]     |  ________________________________________________________^
[INFO] [stderr] 264 | |                                 str::from_utf8(&s).unwrap().to_owned()
[INFO] [stderr] 265 | |                             } else {
[INFO] [stderr] 266 | |                                 String::new()
[INFO] [stderr] 267 | |                             },
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 263 |                             &Object::Array(ref arr) => if let Object::String(ref s,StringFormat::Literal) = arr[1] {
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:270:35
[INFO] [stderr]     |
[INFO] [stderr] 270 |                     }).filter(|x| x.len() > 0).collect(),
[INFO] [stderr]     |                                   ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:283:40
[INFO] [stderr]     |
[INFO] [stderr] 283 |                       Some(selection) => match selection {
[INFO] [stderr]     |  ________________________________________^
[INFO] [stderr] 284 | |                         &Object::String(ref s,StringFormat::Literal) => vec![str::from_utf8(&s).unwrap().to_owned()],
[INFO] [stderr] 285 | |                         &Object::Array(ref chosen) => {
[INFO] [stderr] 286 | |                             let mut res = Vec::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 294 | |                         _ => Vec::new()
[INFO] [stderr] 295 | |                     },
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 283 |                     Some(selection) => match *selection {
[INFO] [stderr] 284 |                         Object::String(ref s,StringFormat::Literal) => vec![str::from_utf8(&s).unwrap().to_owned()],
[INFO] [stderr] 285 |                         Object::Array(ref chosen) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:288:33
[INFO] [stderr]     |
[INFO] [stderr] 288 | /                                 if let &Object::String(ref s,StringFormat::Literal) = obj {
[INFO] [stderr] 289 | |                                     res.push(str::from_utf8(&s).unwrap().to_owned());
[INFO] [stderr] 290 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 288 |                                 if let Object::String(ref s,StringFormat::Literal) = *obj {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:302:25
[INFO] [stderr]     |
[INFO] [stderr] 302 | /                         match x {
[INFO] [stderr] 303 | |                             &Object::String(ref s,StringFormat::Literal) => str::from_utf8(&s).unwrap().to_owned(),
[INFO] [stderr] 304 | |                             &Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr] 305 | |                                 str::from_utf8(&s).unwrap().to_owned()
[INFO] [stderr] ...   |
[INFO] [stderr] 309 | |                             _ => String::new()
[INFO] [stderr] 310 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 302 |                         match *x {
[INFO] [stderr] 303 |                             Object::String(ref s,StringFormat::Literal) => str::from_utf8(&s).unwrap().to_owned(),
[INFO] [stderr] 304 |                             Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:304:56
[INFO] [stderr]     |
[INFO] [stderr] 304 |                               &Object::Array(ref arr) => if let &Object::String(ref s,StringFormat::Literal) = &arr[1] {
[INFO] [stderr]     |  ________________________________________________________^
[INFO] [stderr] 305 | |                                 str::from_utf8(&s).unwrap().to_owned()
[INFO] [stderr] 306 | |                             } else {
[INFO] [stderr] 307 | |                                 String::new()
[INFO] [stderr] 308 | |                             },
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 304 |                             &Object::Array(ref arr) => if let Object::String(ref s,StringFormat::Literal) = arr[1] {
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:311:35
[INFO] [stderr]     |
[INFO] [stderr] 311 |                     }).filter(|x| x.len() > 0).collect(),
[INFO] [stderr]     |                                   ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:352:24
[INFO] [stderr]     |
[INFO] [stderr] 352 |         let kids_obj = self.doc.objects.get(&oid).unwrap().as_dict().unwrap().get("Kids");
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.doc.objects[&oid]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 18.51s
[INFO] running `"docker" "inspect" "8976e36939184c2d31ebae09d0d42170bb272ff6bc070698da4fb0317401465e"`
[INFO] running `"docker" "rm" "-f" "8976e36939184c2d31ebae09d0d42170bb272ff6bc070698da4fb0317401465e"`
[INFO] [stdout] 8976e36939184c2d31ebae09d0d42170bb272ff6bc070698da4fb0317401465e