[INFO] crate pdf_derive 0.1.16 is already in cache [INFO] extracting crate pdf_derive 0.1.16 into work/ex/clippy-test-run/sources/stable/reg/pdf_derive/0.1.16 [INFO] extracting crate pdf_derive 0.1.16 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdf_derive/0.1.16 [INFO] validating manifest of pdf_derive-0.1.16 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pdf_derive-0.1.16 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pdf_derive-0.1.16 [INFO] finished frobbing pdf_derive-0.1.16 [INFO] frobbed toml for pdf_derive-0.1.16 written to work/ex/clippy-test-run/sources/stable/reg/pdf_derive/0.1.16/Cargo.toml [INFO] started frobbing pdf_derive-0.1.16 [INFO] finished frobbing pdf_derive-0.1.16 [INFO] frobbed toml for pdf_derive-0.1.16 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdf_derive/0.1.16/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pdf_derive-0.1.16 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pdf_derive/0.1.16:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 818a9f9aa9976ff3a167b4e8184e38cbe8a651beb18267ab6cf438465a1bb654 [INFO] running `"docker" "start" "-a" "818a9f9aa9976ff3a167b4e8184e38cbe8a651beb18267ab6cf438465a1bb654"` [INFO] [stderr] Checking pdf_derive v0.1.16 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:156:23 [INFO] [stderr] | [INFO] [stderr] 156 | let key = match skip { [INFO] [stderr] | _______________________^ [INFO] [stderr] 157 | | true => String::from(""), [INFO] [stderr] 158 | | false => key.expect("attr `key` missing"), [INFO] [stderr] 159 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if skip { String::from("") } else { key.expect("attr `key` missing") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:244:54 [INFO] [stderr] | [INFO] [stderr] 244 | fn impl_object_for_enum(ast: &DeriveInput, variants: &Vec) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:272:53 [INFO] [stderr] | [INFO] [stderr] 272 | fn impl_from_name(ast: &syn::DeriveInput, variants: &Vec) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | let ref name = field.ident; [INFO] [stderr] | ----^^^^^^^^--------------- help: try: `let name = &field.ident;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | let ref name = field.ident; [INFO] [stderr] | ----^^^^^^^^--------------- help: try: `let name = &field.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:156:23 [INFO] [stderr] | [INFO] [stderr] 156 | let key = match skip { [INFO] [stderr] | _______________________^ [INFO] [stderr] 157 | | true => String::from(""), [INFO] [stderr] 158 | | false => key.expect("attr `key` missing"), [INFO] [stderr] 159 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if skip { String::from("") } else { key.expect("attr `key` missing") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:244:54 [INFO] [stderr] | [INFO] [stderr] 244 | fn impl_object_for_enum(ast: &DeriveInput, variants: &Vec) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:272:53 [INFO] [stderr] | [INFO] [stderr] 272 | fn impl_from_name(ast: &syn::DeriveInput, variants: &Vec) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | let ref name = field.ident; [INFO] [stderr] | ----^^^^^^^^--------------- help: try: `let name = &field.ident;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | let ref name = field.ident; [INFO] [stderr] | ----^^^^^^^^--------------- help: try: `let name = &field.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.41s [INFO] running `"docker" "inspect" "818a9f9aa9976ff3a167b4e8184e38cbe8a651beb18267ab6cf438465a1bb654"` [INFO] running `"docker" "rm" "-f" "818a9f9aa9976ff3a167b4e8184e38cbe8a651beb18267ab6cf438465a1bb654"` [INFO] [stdout] 818a9f9aa9976ff3a167b4e8184e38cbe8a651beb18267ab6cf438465a1bb654