[INFO] crate pdf-canvas 0.6.0 is already in cache [INFO] extracting crate pdf-canvas 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/pdf-canvas/0.6.0 [INFO] extracting crate pdf-canvas 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdf-canvas/0.6.0 [INFO] validating manifest of pdf-canvas-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pdf-canvas-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pdf-canvas-0.6.0 [INFO] finished frobbing pdf-canvas-0.6.0 [INFO] frobbed toml for pdf-canvas-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/pdf-canvas/0.6.0/Cargo.toml [INFO] started frobbing pdf-canvas-0.6.0 [INFO] finished frobbing pdf-canvas-0.6.0 [INFO] frobbed toml for pdf-canvas-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdf-canvas/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pdf-canvas-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pdf-canvas/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 21a20df04787b633c4ceb0a778667a060c225fbb58cd1054ada00ebe266c8477 [INFO] running `"docker" "start" "-a" "21a20df04787b633c4ceb0a778667a060c225fbb58cd1054ada00ebe266c8477"` [INFO] [stderr] Compiling pdf-canvas v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `excessive_precision` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/canvas.rs:155:52 [INFO] [stderr] | [INFO] [stderr] 155 | #[cfg_attr(feature = "cargo-clippy", allow(excessive_precision))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::excessive_precision` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `excessive_precision` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/canvas.rs:155:52 [INFO] [stderr] | [INFO] [stderr] 155 | #[cfg_attr(feature = "cargo-clippy", allow(excessive_precision))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::excessive_precision` [INFO] [stderr] [INFO] [stderr] warning: lint name `excessive_precision` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/canvas.rs:155:52 [INFO] [stderr] | [INFO] [stderr] 155 | #[cfg_attr(feature = "cargo-clippy", allow(excessive_precision))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::excessive_precision` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `excessive_precision` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/canvas.rs:155:52 [INFO] [stderr] | [INFO] [stderr] 155 | #[cfg_attr(feature = "cargo-clippy", allow(excessive_precision))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::excessive_precision` [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/encoding.rs:673:9 [INFO] [stderr] | [INFO] [stderr] 673 | let ref enc = WIN_ANSI_ENCODING; [INFO] [stderr] | ----^^^^^^^--------------------- help: try: `let enc = &WIN_ANSI_ENCODING;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/encoding.rs:674:21 [INFO] [stderr] | [INFO] [stderr] 674 | assert_eq!(Some('A' as u8), enc.get_code("A")); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/encoding.rs:675:21 [INFO] [stderr] | [INFO] [stderr] 675 | assert_eq!(Some('Z' as u8), enc.get_code("Z")); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'Z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/encoding.rs:676:21 [INFO] [stderr] | [INFO] [stderr] 676 | assert_eq!(Some('a' as u8), enc.get_code("a")); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/encoding.rs:677:21 [INFO] [stderr] | [INFO] [stderr] 677 | assert_eq!(Some('z' as u8), enc.get_code("z")); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/encoding.rs:678:21 [INFO] [stderr] | [INFO] [stderr] 678 | assert_eq!(Some(' ' as u8), enc.get_code("space")); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/encoding.rs:679:21 [INFO] [stderr] | [INFO] [stderr] 679 | assert_eq!(Some('&' as u8), enc.get_code("ampersand")); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'&' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(66.336, some_len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(66.336, some_len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> tests/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | long_text = long_text + some_text; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `long_text += some_text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pdf-canvas`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/mandala.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | let segment = 2. * PI / n as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "21a20df04787b633c4ceb0a778667a060c225fbb58cd1054ada00ebe266c8477"` [INFO] running `"docker" "rm" "-f" "21a20df04787b633c4ceb0a778667a060c225fbb58cd1054ada00ebe266c8477"` [INFO] [stdout] 21a20df04787b633c4ceb0a778667a060c225fbb58cd1054ada00ebe266c8477