[INFO] crate pcf857x 0.2.0 is already in cache [INFO] extracting crate pcf857x 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/pcf857x/0.2.0 [INFO] extracting crate pcf857x 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcf857x/0.2.0 [INFO] validating manifest of pcf857x-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pcf857x-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pcf857x-0.2.0 [INFO] finished frobbing pcf857x-0.2.0 [INFO] frobbed toml for pcf857x-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/pcf857x/0.2.0/Cargo.toml [INFO] started frobbing pcf857x-0.2.0 [INFO] finished frobbing pcf857x-0.2.0 [INFO] frobbed toml for pcf857x-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcf857x/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pcf857x-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pcf857x/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19aa8f2ee5da18a4ce28a0d9ed2ebe35ad786e7281c49dcbe1a47205cf1ebf93 [INFO] running `"docker" "start" "-a" "19aa8f2ee5da18a4ce28a0d9ed2ebe35ad786e7281c49dcbe1a47205cf1ebf93"` [INFO] [stderr] Checking embedded-hal-mock v0.2.0 [INFO] [stderr] Checking pcf857x v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pins.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | Err(_) => panic!("Could not set pin to high."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | / io_pin_impl!( P0, P1, P2, P3, P4, P5, P6, P7, [INFO] [stderr] 131 | | P10, P11, P12, P13, P14, P15, P16, P17 ); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pins.rs:100:25 [INFO] [stderr] | [INFO] [stderr] 100 | Err(_) => panic!("Could not set pin to high."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | / io_pin_impl!( P0, P1, P2, P3, P4, P5, P6, P7, [INFO] [stderr] 131 | | P10, P11, P12, P13, P14, P15, P16, P17 ); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pins.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | Err(_) => panic!("Could not read pin status."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | / io_pin_impl!( P0, P1, P2, P3, P4, P5, P6, P7, [INFO] [stderr] 131 | | P10, P11, P12, P13, P14, P15, P16, P17 ); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pins.rs:121:25 [INFO] [stderr] | [INFO] [stderr] 121 | Err(_) => panic!("Could not read pin status."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | / io_pin_impl!( P0, P1, P2, P3, P4, P5, P6, P7, [INFO] [stderr] 131 | | P10, P11, P12, P13, P14, P15, P16, P17 ); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pins.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | Err(_) => panic!("Could not set pin to high."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | / io_pin_impl!( P0, P1, P2, P3, P4, P5, P6, P7, [INFO] [stderr] 131 | | P10, P11, P12, P13, P14, P15, P16, P17 ); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/devices/pcf8575.rs:83:34 [INFO] [stderr] | [INFO] [stderr] 83 | dev.last_set_mask = ((data[data.len()-1] as u16) << 8) | data[data.len()-2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[data.len()-1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/devices/pcf8575.rs:83:70 [INFO] [stderr] | [INFO] [stderr] 83 | dev.last_set_mask = ((data[data.len()-1] as u16) << 8) | data[data.len()-2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[data.len()-2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/devices/pcf8575.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | input[0] as u16 | ((input[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(input[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/devices/pcf8575.rs:157:24 [INFO] [stderr] | [INFO] [stderr] 157 | input[0] as u16 | ((input[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(input[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pins.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | Err(_) => panic!("Could not set pin to high."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | / io_pin_impl!( P0, P1, P2, P3, P4, P5, P6, P7, [INFO] [stderr] 131 | | P10, P11, P12, P13, P14, P15, P16, P17 ); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pins.rs:100:25 [INFO] [stderr] | [INFO] [stderr] 100 | Err(_) => panic!("Could not set pin to high."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | / io_pin_impl!( P0, P1, P2, P3, P4, P5, P6, P7, [INFO] [stderr] 131 | | P10, P11, P12, P13, P14, P15, P16, P17 ); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pins.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | Err(_) => panic!("Could not read pin status."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | / io_pin_impl!( P0, P1, P2, P3, P4, P5, P6, P7, [INFO] [stderr] 131 | | P10, P11, P12, P13, P14, P15, P16, P17 ); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pins.rs:121:25 [INFO] [stderr] | [INFO] [stderr] 121 | Err(_) => panic!("Could not read pin status."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | / io_pin_impl!( P0, P1, P2, P3, P4, P5, P6, P7, [INFO] [stderr] 131 | | P10, P11, P12, P13, P14, P15, P16, P17 ); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pins.rs:92:25 [INFO] [stderr] | [INFO] [stderr] 92 | Err(_) => panic!("Could not set pin to high."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | / io_pin_impl!( P0, P1, P2, P3, P4, P5, P6, P7, [INFO] [stderr] 131 | | P10, P11, P12, P13, P14, P15, P16, P17 ); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/devices/pcf8575.rs:83:34 [INFO] [stderr] | [INFO] [stderr] 83 | dev.last_set_mask = ((data[data.len()-1] as u16) << 8) | data[data.len()-2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[data.len()-1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/devices/pcf8575.rs:83:70 [INFO] [stderr] | [INFO] [stderr] 83 | dev.last_set_mask = ((data[data.len()-1] as u16) << 8) | data[data.len()-2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[data.len()-2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/devices/pcf8575.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | input[0] as u16 | ((input[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(input[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/devices/pcf8575.rs:157:24 [INFO] [stderr] | [INFO] [stderr] 157 | input[0] as u16 | ((input[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(input[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.69s [INFO] running `"docker" "inspect" "19aa8f2ee5da18a4ce28a0d9ed2ebe35ad786e7281c49dcbe1a47205cf1ebf93"` [INFO] running `"docker" "rm" "-f" "19aa8f2ee5da18a4ce28a0d9ed2ebe35ad786e7281c49dcbe1a47205cf1ebf93"` [INFO] [stdout] 19aa8f2ee5da18a4ce28a0d9ed2ebe35ad786e7281c49dcbe1a47205cf1ebf93