[INFO] crate pcell 0.7.1 is already in cache [INFO] extracting crate pcell 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/pcell/0.7.1 [INFO] extracting crate pcell 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcell/0.7.1 [INFO] validating manifest of pcell-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pcell-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pcell-0.7.1 [INFO] finished frobbing pcell-0.7.1 [INFO] frobbed toml for pcell-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/pcell/0.7.1/Cargo.toml [INFO] started frobbing pcell-0.7.1 [INFO] finished frobbing pcell-0.7.1 [INFO] frobbed toml for pcell-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcell/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pcell-0.7.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pcell/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8cae39f3195126d6b055bb6435b6b08c109300c8db7280676815c2c802e58aae [INFO] running `"docker" "start" "-a" "8cae39f3195126d6b055bb6435b6b08c109300c8db7280676815c2c802e58aae"` [INFO] [stderr] Checking pcell v0.7.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | fn make_live(b64: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / match matches.value_of("import") { [INFO] [stderr] 121 | | Some(s) => { [INFO] [stderr] 122 | | println!("Adding sample to database: {}", s); [INFO] [stderr] 123 | | let safe_file: (String, String, String) = make_safe(read_bytes(s)); [INFO] [stderr] ... | [INFO] [stderr] 129 | | None => (), [INFO] [stderr] 130 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | if let Some(s) = matches.value_of("import") { [INFO] [stderr] 121 | println!("Adding sample to database: {}", s); [INFO] [stderr] 122 | let safe_file: (String, String, String) = make_safe(read_bytes(s)); [INFO] [stderr] 123 | let path: &Path = Path::new(s); [INFO] [stderr] 124 | db.samples.push(Sample{filename: String::from(path.file_name().expect("Failed to find filename.").to_str().expect("Failed to parse filename.")), data: safe_file.0, md5: safe_file.1, sha256: safe_file.2}); [INFO] [stderr] 125 | db.size = db.size + 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | db.size = db.size + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `db.size += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / match matches.value_of("export") { [INFO] [stderr] 133 | | Some(s) => { [INFO] [stderr] 134 | | println!("Exporting from database: {}", s); [INFO] [stderr] 135 | | let mut live_bytes: Vec = vec!(); [INFO] [stderr] ... | [INFO] [stderr] 163 | | None => (), [INFO] [stderr] 164 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let Some(s) = matches.value_of("export") { [INFO] [stderr] 133 | println!("Exporting from database: {}", s); [INFO] [stderr] 134 | let mut live_bytes: Vec = vec!(); [INFO] [stderr] 135 | for sample in &db.samples { [INFO] [stderr] 136 | print!("."); [INFO] [stderr] 137 | if &sample.filename == s { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | if &sample.filename == s { [INFO] [stderr] | ----------------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `sample.filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | fn make_live(b64: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / match matches.value_of("import") { [INFO] [stderr] 121 | | Some(s) => { [INFO] [stderr] 122 | | println!("Adding sample to database: {}", s); [INFO] [stderr] 123 | | let safe_file: (String, String, String) = make_safe(read_bytes(s)); [INFO] [stderr] ... | [INFO] [stderr] 129 | | None => (), [INFO] [stderr] 130 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | if let Some(s) = matches.value_of("import") { [INFO] [stderr] 121 | println!("Adding sample to database: {}", s); [INFO] [stderr] 122 | let safe_file: (String, String, String) = make_safe(read_bytes(s)); [INFO] [stderr] 123 | let path: &Path = Path::new(s); [INFO] [stderr] 124 | db.samples.push(Sample{filename: String::from(path.file_name().expect("Failed to find filename.").to_str().expect("Failed to parse filename.")), data: safe_file.0, md5: safe_file.1, sha256: safe_file.2}); [INFO] [stderr] 125 | db.size = db.size + 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | db.size = db.size + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `db.size += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / match matches.value_of("export") { [INFO] [stderr] 133 | | Some(s) => { [INFO] [stderr] 134 | | println!("Exporting from database: {}", s); [INFO] [stderr] 135 | | let mut live_bytes: Vec = vec!(); [INFO] [stderr] ... | [INFO] [stderr] 163 | | None => (), [INFO] [stderr] 164 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let Some(s) = matches.value_of("export") { [INFO] [stderr] 133 | println!("Exporting from database: {}", s); [INFO] [stderr] 134 | let mut live_bytes: Vec = vec!(); [INFO] [stderr] 135 | for sample in &db.samples { [INFO] [stderr] 136 | print!("."); [INFO] [stderr] 137 | if &sample.filename == s { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | if &sample.filename == s { [INFO] [stderr] | ----------------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `sample.filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.58s [INFO] running `"docker" "inspect" "8cae39f3195126d6b055bb6435b6b08c109300c8db7280676815c2c802e58aae"` [INFO] running `"docker" "rm" "-f" "8cae39f3195126d6b055bb6435b6b08c109300c8db7280676815c2c802e58aae"` [INFO] [stdout] 8cae39f3195126d6b055bb6435b6b08c109300c8db7280676815c2c802e58aae