[INFO] crate pcb-core 0.2.0 is already in cache [INFO] extracting crate pcb-core 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/pcb-core/0.2.0 [INFO] extracting crate pcb-core 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcb-core/0.2.0 [INFO] validating manifest of pcb-core-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pcb-core-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pcb-core-0.2.0 [INFO] finished frobbing pcb-core-0.2.0 [INFO] frobbed toml for pcb-core-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/pcb-core/0.2.0/Cargo.toml [INFO] started frobbing pcb-core-0.2.0 [INFO] finished frobbing pcb-core-0.2.0 [INFO] frobbed toml for pcb-core-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcb-core/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pcb-core-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pcb-core/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28295c350016e0d43ae80e527bb0c25fe9c890912aa946259f0b26aa80f4d955 [INFO] running `"docker" "start" "-a" "28295c350016e0d43ae80e527bb0c25fe9c890912aa946259f0b26aa80f4d955"` [INFO] [stderr] Checking pcb-core v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `common::Context` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/common.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / impl Context { [INFO] [stderr] 13 | | pub fn new() -> Self { [INFO] [stderr] 14 | | Context { [INFO] [stderr] 15 | | store: Arena::new(), [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `common::Context` [INFO] [stderr] --> src/common.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Context { [INFO] [stderr] 15 | | store: Arena::new(), [INFO] [stderr] 16 | | vec: RefCell::new(vec![]) [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for common::Context { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `common::Interner` [INFO] [stderr] --> src/common.rs:81:3 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn new() -> Self { [INFO] [stderr] 82 | | Interner { [INFO] [stderr] 83 | | store: Arena::new(), [INFO] [stderr] 84 | | refs: RefCell::new(HashSet::new()), [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | impl Default for common::Interner { [INFO] [stderr] 81 | fn default() -> Self { [INFO] [stderr] 82 | Self::new() [INFO] [stderr] 83 | } [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `common::Context` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/common.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / impl Context { [INFO] [stderr] 13 | | pub fn new() -> Self { [INFO] [stderr] 14 | | Context { [INFO] [stderr] 15 | | store: Arena::new(), [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `common::Context` [INFO] [stderr] --> src/common.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Context { [INFO] [stderr] 15 | | store: Arena::new(), [INFO] [stderr] 16 | | vec: RefCell::new(vec![]) [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for common::Context { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `common::Interner` [INFO] [stderr] --> src/common.rs:81:3 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn new() -> Self { [INFO] [stderr] 82 | | Interner { [INFO] [stderr] 83 | | store: Arena::new(), [INFO] [stderr] 84 | | refs: RefCell::new(HashSet::new()), [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | impl Default for common::Interner { [INFO] [stderr] 81 | fn default() -> Self { [INFO] [stderr] 82 | Self::new() [INFO] [stderr] 83 | } [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.88s [INFO] running `"docker" "inspect" "28295c350016e0d43ae80e527bb0c25fe9c890912aa946259f0b26aa80f4d955"` [INFO] running `"docker" "rm" "-f" "28295c350016e0d43ae80e527bb0c25fe9c890912aa946259f0b26aa80f4d955"` [INFO] [stdout] 28295c350016e0d43ae80e527bb0c25fe9c890912aa946259f0b26aa80f4d955