[INFO] crate pcap-file-ra 0.1.1 is already in cache [INFO] extracting crate pcap-file-ra 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/pcap-file-ra/0.1.1 [INFO] extracting crate pcap-file-ra 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcap-file-ra/0.1.1 [INFO] validating manifest of pcap-file-ra-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pcap-file-ra-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pcap-file-ra-0.1.1 [INFO] finished frobbing pcap-file-ra-0.1.1 [INFO] frobbed toml for pcap-file-ra-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/pcap-file-ra/0.1.1/Cargo.toml [INFO] started frobbing pcap-file-ra-0.1.1 [INFO] finished frobbing pcap-file-ra-0.1.1 [INFO] frobbed toml for pcap-file-ra-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcap-file-ra/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pcap-file-ra-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pcap-file-ra/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc4df30dd2df42916e54fc5126d9a41b576fce9d6ba4d9d9fe917d40537ddc6c [INFO] running `"docker" "start" "-a" "dc4df30dd2df42916e54fc5126d9a41b576fce9d6ba4d9d9fe917d40537ddc6c"` [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking pcap-file v0.10.0 [INFO] [stderr] Checking pcap-file-ra v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | offsets: offsets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `offsets` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | offsets: offsets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `offsets` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `PcapReaderIndex` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | / impl PcapReaderIndex { [INFO] [stderr] 124 | | /// Creates the struct with full control. [INFO] [stderr] 125 | | pub fn new_full_control( [INFO] [stderr] 126 | | pcap_path: &str, [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:196:16 [INFO] [stderr] | [INFO] [stderr] 196 | if let Err(_) = seek_result { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 197 | | return None; [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________- help: try this: `if seek_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unused import: `*` [INFO] [stderr] --> src/lib.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | use *; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: item `PcapReaderIndex` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | / impl PcapReaderIndex { [INFO] [stderr] 124 | | /// Creates the struct with full control. [INFO] [stderr] 125 | | pub fn new_full_control( [INFO] [stderr] 126 | | pcap_path: &str, [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:196:16 [INFO] [stderr] | [INFO] [stderr] 196 | if let Err(_) = seek_result { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 197 | | return None; [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________- help: try this: `if seek_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:245:47 [INFO] [stderr] | [INFO] [stderr] 245 | calculated_offset += 16 + pkt.header.incl_len as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pkt.header.incl_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.90s [INFO] running `"docker" "inspect" "dc4df30dd2df42916e54fc5126d9a41b576fce9d6ba4d9d9fe917d40537ddc6c"` [INFO] running `"docker" "rm" "-f" "dc4df30dd2df42916e54fc5126d9a41b576fce9d6ba4d9d9fe917d40537ddc6c"` [INFO] [stdout] dc4df30dd2df42916e54fc5126d9a41b576fce9d6ba4d9d9fe917d40537ddc6c