[INFO] crate pc-keyboard 0.3.1 is already in cache [INFO] extracting crate pc-keyboard 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/pc-keyboard/0.3.1 [INFO] extracting crate pc-keyboard 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pc-keyboard/0.3.1 [INFO] validating manifest of pc-keyboard-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pc-keyboard-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pc-keyboard-0.3.1 [INFO] finished frobbing pc-keyboard-0.3.1 [INFO] frobbed toml for pc-keyboard-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/pc-keyboard/0.3.1/Cargo.toml [INFO] started frobbing pc-keyboard-0.3.1 [INFO] finished frobbing pc-keyboard-0.3.1 [INFO] frobbed toml for pc-keyboard-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pc-keyboard/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pc-keyboard-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pc-keyboard/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be4d9708d9df8d577fa602e200f7422acbde0abf877d1cfed0fa400445c21645 [INFO] running `"docker" "start" "-a" "be4d9708d9df8d577fa602e200f7422acbde0abf877d1cfed0fa400445c21645"` [INFO] [stderr] Checking pc-keyboard v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / match self { [INFO] [stderr] 233 | | &ConsumeState::Consume(ref st) => st.clone(), [INFO] [stderr] 234 | | &ConsumeState::Proceed(ref st) => st.clone(), [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 232 | match *self { [INFO] [stderr] 233 | ConsumeState::Consume(ref st) => st.clone(), [INFO] [stderr] 234 | ConsumeState::Proceed(ref st) => st.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:233:47 [INFO] [stderr] | [INFO] [stderr] 233 | &ConsumeState::Consume(ref st) => st.clone(), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*st` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:234:47 [INFO] [stderr] | [INFO] [stderr] 234 | &ConsumeState::Proceed(ref st) => st.clone(), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*st` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 59 [INFO] [stderr] --> src/layouts.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / fn map_keycode(keycode: KeyCode, modifiers: &Modifiers) -> DecodedKey { [INFO] [stderr] 13 | | match keycode { [INFO] [stderr] 14 | | KeyCode::BackTick => { [INFO] [stderr] 15 | | if modifiers.is_shifted() { [INFO] [stderr] ... | [INFO] [stderr] 427 | | } [INFO] [stderr] 428 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / match self { [INFO] [stderr] 233 | | &ConsumeState::Consume(ref st) => st.clone(), [INFO] [stderr] 234 | | &ConsumeState::Proceed(ref st) => st.clone(), [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 232 | match *self { [INFO] [stderr] 233 | ConsumeState::Consume(ref st) => st.clone(), [INFO] [stderr] 234 | ConsumeState::Proceed(ref st) => st.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:233:47 [INFO] [stderr] | [INFO] [stderr] 233 | &ConsumeState::Consume(ref st) => st.clone(), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*st` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:234:47 [INFO] [stderr] | [INFO] [stderr] 234 | &ConsumeState::Proceed(ref st) => st.clone(), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*st` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 59 [INFO] [stderr] --> src/layouts.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / fn map_keycode(keycode: KeyCode, modifiers: &Modifiers) -> DecodedKey { [INFO] [stderr] 13 | | match keycode { [INFO] [stderr] 14 | | KeyCode::BackTick => { [INFO] [stderr] 15 | | if modifiers.is_shifted() { [INFO] [stderr] ... | [INFO] [stderr] 427 | | } [INFO] [stderr] 428 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "be4d9708d9df8d577fa602e200f7422acbde0abf877d1cfed0fa400445c21645"` [INFO] running `"docker" "rm" "-f" "be4d9708d9df8d577fa602e200f7422acbde0abf877d1cfed0fa400445c21645"` [INFO] [stdout] be4d9708d9df8d577fa602e200f7422acbde0abf877d1cfed0fa400445c21645