[INFO] crate pbuf 0.3.31 is already in cache [INFO] extracting crate pbuf 0.3.31 into work/ex/clippy-test-run/sources/stable/reg/pbuf/0.3.31 [INFO] extracting crate pbuf 0.3.31 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pbuf/0.3.31 [INFO] validating manifest of pbuf-0.3.31 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pbuf-0.3.31 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pbuf-0.3.31 [INFO] finished frobbing pbuf-0.3.31 [INFO] frobbed toml for pbuf-0.3.31 written to work/ex/clippy-test-run/sources/stable/reg/pbuf/0.3.31/Cargo.toml [INFO] started frobbing pbuf-0.3.31 [INFO] finished frobbing pbuf-0.3.31 [INFO] frobbed toml for pbuf-0.3.31 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pbuf/0.3.31/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pbuf-0.3.31 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pbuf/0.3.31:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d325a415c4b7a768d4f5dc31111d483a6a393ad793dcda353940b6eea5469a6a [INFO] running `"docker" "start" "-a" "d325a415c4b7a768d4f5dc31111d483a6a393ad793dcda353940b6eea5469a6a"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking pbuf v0.3.31 (/opt/crater/workdir) [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | / loop { [INFO] [stderr] 15 | | match reader.read_exact(&mut head) { [INFO] [stderr] 16 | | Ok(n) => n, [INFO] [stderr] 17 | | Err(_) => break [INFO] [stderr] ... | [INFO] [stderr] 29 | | msgs.push(msg); [INFO] [stderr] 30 | | } [INFO] [stderr] | |___^ help: try: `while let Ok(n) = reader.read_exact(&mut head) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: The function/method `parse_from_bytes` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | msg = match parse_from_bytes::(&mut proto) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:34:15 [INFO] [stderr] | [INFO] [stderr] 34 | fn header(sz: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | / loop { [INFO] [stderr] 15 | | match reader.read_exact(&mut head) { [INFO] [stderr] 16 | | Ok(n) => n, [INFO] [stderr] 17 | | Err(_) => break [INFO] [stderr] ... | [INFO] [stderr] 29 | | msgs.push(msg); [INFO] [stderr] 30 | | } [INFO] [stderr] | |___^ help: try: `while let Ok(n) = reader.read_exact(&mut head) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: The function/method `parse_from_bytes` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | msg = match parse_from_bytes::(&mut proto) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:34:15 [INFO] [stderr] | [INFO] [stderr] 34 | fn header(sz: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "d325a415c4b7a768d4f5dc31111d483a6a393ad793dcda353940b6eea5469a6a"` [INFO] running `"docker" "rm" "-f" "d325a415c4b7a768d4f5dc31111d483a6a393ad793dcda353940b6eea5469a6a"` [INFO] [stdout] d325a415c4b7a768d4f5dc31111d483a6a393ad793dcda353940b6eea5469a6a