[INFO] crate pb-rs 0.7.0 is already in cache
[INFO] extracting crate pb-rs 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/pb-rs/0.7.0
[INFO] extracting crate pb-rs 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pb-rs/0.7.0
[INFO] validating manifest of pb-rs-0.7.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pb-rs-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pb-rs-0.7.0
[INFO] finished frobbing pb-rs-0.7.0
[INFO] frobbed toml for pb-rs-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/pb-rs/0.7.0/Cargo.toml
[INFO] started frobbing pb-rs-0.7.0
[INFO] finished frobbing pb-rs-0.7.0
[INFO] frobbed toml for pb-rs-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pb-rs/0.7.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pb-rs-0.7.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pb-rs/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4e0664e01b2fc24805a67a60d45b341a004ddaa1d556e0d5881ef510fa79778e
[INFO] running `"docker" "start" "-a" "4e0664e01b2fc24805a67a60d45b341a004ddaa1d556e0d5881ef510fa79778e"`
[INFO] [stderr]     Checking pb-rs v0.7.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:714:9
[INFO] [stderr]     |
[INFO] [stderr] 714 |         writeln!(w, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:717:9
[INFO] [stderr]     |
[INFO] [stderr] 717 |         writeln!(w, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:719:9
[INFO] [stderr]     |
[INFO] [stderr] 719 |         writeln!(w, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:723:13
[INFO] [stderr]     |
[INFO] [stderr] 723 |             writeln!(w, "")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:725:13
[INFO] [stderr]     |
[INFO] [stderr] 725 |             writeln!(w, "")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:753:13
[INFO] [stderr]     |
[INFO] [stderr] 753 |             writeln!(w, "")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:867:9
[INFO] [stderr]     |
[INFO] [stderr] 867 |         writeln!(w, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1072:9
[INFO] [stderr]      |
[INFO] [stderr] 1072 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1074:9
[INFO] [stderr]      |
[INFO] [stderr] 1074 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1079:13
[INFO] [stderr]      |
[INFO] [stderr] 1079 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1081:13
[INFO] [stderr]      |
[INFO] [stderr] 1081 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1169:9
[INFO] [stderr]      |
[INFO] [stderr] 1169 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1171:9
[INFO] [stderr]      |
[INFO] [stderr] 1171 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1780:9
[INFO] [stderr]      |
[INFO] [stderr] 1780 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1789:9
[INFO] [stderr]      |
[INFO] [stderr] 1789 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1794:9
[INFO] [stderr]      |
[INFO] [stderr] 1794 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1846:9
[INFO] [stderr]      |
[INFO] [stderr] 1846 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1853:13
[INFO] [stderr]      |
[INFO] [stderr] 1853 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1855:13
[INFO] [stderr]      |
[INFO] [stderr] 1855 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1857:13
[INFO] [stderr]      |
[INFO] [stderr] 1857 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1859:13
[INFO] [stderr]      |
[INFO] [stderr] 1859 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]     --> src/types.rs:1933:13
[INFO] [stderr]      |
[INFO] [stderr] 1933 |             write!(f, "{}\n", MAGIC_HEADER)?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]     --> src/types.rs:1936:9
[INFO] [stderr]      |
[INFO] [stderr] 1936 |         write!(f, "pub mod {};\n", name)?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             in_files: in_files,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `in_files`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |             out_file: out_file,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:119:13
[INFO] [stderr]     |
[INFO] [stderr] 119 |             include_paths: include_paths,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `include_paths`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:167:21
[INFO] [stderr]     |
[INFO] [stderr] 167 |                     out_file: out_file,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:714:9
[INFO] [stderr]     |
[INFO] [stderr] 714 |         writeln!(w, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:717:9
[INFO] [stderr]     |
[INFO] [stderr] 717 |         writeln!(w, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:719:9
[INFO] [stderr]     |
[INFO] [stderr] 719 |         writeln!(w, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:723:13
[INFO] [stderr]     |
[INFO] [stderr] 723 |             writeln!(w, "")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:725:13
[INFO] [stderr]     |
[INFO] [stderr] 725 |             writeln!(w, "")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:753:13
[INFO] [stderr]     |
[INFO] [stderr] 753 |             writeln!(w, "")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]    --> src/types.rs:867:9
[INFO] [stderr]     |
[INFO] [stderr] 867 |         writeln!(w, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1072:9
[INFO] [stderr]      |
[INFO] [stderr] 1072 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1074:9
[INFO] [stderr]      |
[INFO] [stderr] 1074 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1079:13
[INFO] [stderr]      |
[INFO] [stderr] 1079 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1081:13
[INFO] [stderr]      |
[INFO] [stderr] 1081 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1169:9
[INFO] [stderr]      |
[INFO] [stderr] 1169 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1171:9
[INFO] [stderr]      |
[INFO] [stderr] 1171 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1780:9
[INFO] [stderr]      |
[INFO] [stderr] 1780 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1789:9
[INFO] [stderr]      |
[INFO] [stderr] 1789 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1794:9
[INFO] [stderr]      |
[INFO] [stderr] 1794 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1846:9
[INFO] [stderr]      |
[INFO] [stderr] 1846 |         writeln!(w, "")?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1853:13
[INFO] [stderr]      |
[INFO] [stderr] 1853 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1855:13
[INFO] [stderr]      |
[INFO] [stderr] 1855 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1857:13
[INFO] [stderr]      |
[INFO] [stderr] 1857 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(w, "")`
[INFO] [stderr]     --> src/types.rs:1859:13
[INFO] [stderr]      |
[INFO] [stderr] 1859 |             writeln!(w, "")?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(w)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]     --> src/types.rs:1933:13
[INFO] [stderr]      |
[INFO] [stderr] 1933 |             write!(f, "{}\n", MAGIC_HEADER)?;
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]     --> src/types.rs:1936:9
[INFO] [stderr]      |
[INFO] [stderr] 1936 |         write!(f, "pub mod {};\n", name)?;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             in_files: in_files,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `in_files`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |             out_file: out_file,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:119:13
[INFO] [stderr]     |
[INFO] [stderr] 119 |             include_paths: include_paths,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `include_paths`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:167:21
[INFO] [stderr]     |
[INFO] [stderr] 167 |                     out_file: out_file,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/types.rs:15:18
[INFO] [stderr]    |
[INFO] [stderr] 15 |         0x4000...0x1FFFFF => 3,
[INFO] [stderr]    |                  ^^^^^^^^ help: consider: `0x001F_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/types.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         0x200000...0xFFFFFFF => 4,
[INFO] [stderr]    |         ^^^^^^^^ help: consider: `0x0020_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/types.rs:16:20
[INFO] [stderr]    |
[INFO] [stderr] 16 |         0x200000...0xFFFFFFF => 4,
[INFO] [stderr]    |                    ^^^^^^^^^ help: consider: `0x0FFF_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]     --> src/types.rs:1882:12
[INFO] [stderr]      |
[INFO] [stderr] 1882 |       } else {
[INFO] [stderr]      |  ____________^
[INFO] [stderr] 1883 | |         if let Some(i) = package.rfind('.') {
[INFO] [stderr] 1884 | |             (&package[0..i], &package[i + 1..])
[INFO] [stderr] 1885 | |         } else {
[INFO] [stderr] 1886 | |             ("", package)
[INFO] [stderr] 1887 | |         }
[INFO] [stderr] 1888 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1882 |     } else if let Some(i) = package.rfind('.') {
[INFO] [stderr] 1883 |     (&package[0..i], &package[i + 1..])
[INFO] [stderr] 1884 | } else {
[INFO] [stderr] 1885 |     ("", package)
[INFO] [stderr] 1886 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]     --> src/types.rs:1891:22
[INFO] [stderr]      |
[INFO] [stderr] 1891 | const MAGIC_HEADER: &'static str = "// Automatically generated mod.rs";
[INFO] [stderr]      |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/types.rs:15:18
[INFO] [stderr]    |
[INFO] [stderr] 15 |         0x4000...0x1FFFFF => 3,
[INFO] [stderr]    |                  ^^^^^^^^ help: consider: `0x001F_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/types.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         0x200000...0xFFFFFFF => 4,
[INFO] [stderr]    |         ^^^^^^^^ help: consider: `0x0020_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/types.rs:16:20
[INFO] [stderr]    |
[INFO] [stderr] 16 |         0x200000...0xFFFFFFF => 4,
[INFO] [stderr]    |                    ^^^^^^^^^ help: consider: `0x0FFF_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]     --> src/types.rs:1882:12
[INFO] [stderr]      |
[INFO] [stderr] 1882 |       } else {
[INFO] [stderr]      |  ____________^
[INFO] [stderr] 1883 | |         if let Some(i) = package.rfind('.') {
[INFO] [stderr] 1884 | |             (&package[0..i], &package[i + 1..])
[INFO] [stderr] 1885 | |         } else {
[INFO] [stderr] 1886 | |             ("", package)
[INFO] [stderr] 1887 | |         }
[INFO] [stderr] 1888 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1882 |     } else if let Some(i) = package.rfind('.') {
[INFO] [stderr] 1883 |     (&package[0..i], &package[i + 1..])
[INFO] [stderr] 1884 | } else {
[INFO] [stderr] 1885 |     ("", package)
[INFO] [stderr] 1886 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]     --> src/types.rs:1891:22
[INFO] [stderr]      |
[INFO] [stderr] 1891 | const MAGIC_HEADER: &'static str = "// Automatically generated mod.rs";
[INFO] [stderr]      |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/parser.rs:109:17
[INFO] [stderr]     |
[INFO] [stderr] 109 |             >> ((from_..(to_ + 1)).collect())
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: use: `(from_..=to_)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/parser.rs:109:17
[INFO] [stderr]     |
[INFO] [stderr] 109 |             >> ((from_..(to_ + 1)).collect())
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: use: `(from_..=to_)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]    --> src/parser.rs:269:5
[INFO] [stderr]     |
[INFO] [stderr] 269 |     Message(Message),
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::large_enum_variant)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]     |
[INFO] [stderr] 269 |     Message(Box<Message>),
[INFO] [stderr]     |             ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]    --> src/parser.rs:392:5
[INFO] [stderr]     |
[INFO] [stderr] 392 |     Message(Message),
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]     |
[INFO] [stderr] 392 |     Message(Box<Message>),
[INFO] [stderr]     |             ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]   --> src/scc.rs:9:1
[INFO] [stderr]    |
[INFO] [stderr] 9  | / fn scc(
[INFO] [stderr] 10 | |     vertices: &[MessageIndex],
[INFO] [stderr] 11 | |     desc: &FileDescriptor,
[INFO] [stderr] 12 | |     u: usize,
[INFO] [stderr] ...  |
[INFO] [stderr] 49 | |     }
[INFO] [stderr] 50 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]    --> src/parser.rs:269:5
[INFO] [stderr]     |
[INFO] [stderr] 269 |     Message(Message),
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::large_enum_variant)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]     |
[INFO] [stderr] 269 |     Message(Box<Message>),
[INFO] [stderr]     |             ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]    --> src/parser.rs:392:5
[INFO] [stderr]     |
[INFO] [stderr] 392 |     Message(Message),
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]     |
[INFO] [stderr] 392 |     Message(Box<Message>),
[INFO] [stderr]     |             ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]   --> src/scc.rs:9:1
[INFO] [stderr]    |
[INFO] [stderr] 9  | / fn scc(
[INFO] [stderr] 10 | |     vertices: &[MessageIndex],
[INFO] [stderr] 11 | |     desc: &FileDescriptor,
[INFO] [stderr] 12 | |     u: usize,
[INFO] [stderr] ...  |
[INFO] [stderr] 49 | |     }
[INFO] [stderr] 50 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/types.rs:926:22
[INFO] [stderr]     |
[INFO] [stderr] 926 |                       .ok_or(Error::InvalidDefaultEnum(format!(
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 927 | |                                 "Error in message {}\n\
[INFO] [stderr] 928 | |                                 Enum field {:?} has a default value '{}' which is not valid for enum index {:?}",
[INFO] [stderr] 929 | |                                 self.name, f, var, e)))?;
[INFO] [stderr]     | |_______________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 926 |                     .ok_or_else(|| Error::InvalidDefaultEnum(format!(
[INFO] [stderr] 927 |                                 "Error in message {}\n\
[INFO] [stderr] 928 |                                 Enum field {:?} has a default value '{}' which is not valid for enum index {:?}",
[INFO] [stderr] 929 |                                 self.name, f, var, e)))?;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]     --> src/types.rs:1432:26
[INFO] [stderr]      |
[INFO] [stderr] 1432 |                 m.path = in_file.clone().to_path_buf();
[INFO] [stderr]      |                          ^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]      |
[INFO] [stderr] 1432 |                 m.path = &(*in_file).clone().to_path_buf();
[INFO] [stderr]      |                          ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]      |
[INFO] [stderr] 1432 |                 m.path = &std::path::Path::clone(in_file).to_path_buf();
[INFO] [stderr]      |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]     --> src/types.rs:1433:20
[INFO] [stderr]      |
[INFO] [stderr] 1433 |                 if &import_search_path.len() > &0 {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]      |
[INFO] [stderr] 1433 |                 if import_search_path.len() > 0 {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^^^^^^^^^   ^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]     --> src/types.rs:1596:38
[INFO] [stderr]      |
[INFO] [stderr] 1596 |                     let cycle = &scc[i..i + cycle + 1];
[INFO] [stderr]      |                                      ^^^^^^^^^^^^^^^^ help: use: `i..=i + cycle`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/types.rs:926:22
[INFO] [stderr]     |
[INFO] [stderr] 926 |                       .ok_or(Error::InvalidDefaultEnum(format!(
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 927 | |                                 "Error in message {}\n\
[INFO] [stderr] 928 | |                                 Enum field {:?} has a default value '{}' which is not valid for enum index {:?}",
[INFO] [stderr] 929 | |                                 self.name, f, var, e)))?;
[INFO] [stderr]     | |_______________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 926 |                     .ok_or_else(|| Error::InvalidDefaultEnum(format!(
[INFO] [stderr] 927 |                                 "Error in message {}\n\
[INFO] [stderr] 928 |                                 Enum field {:?} has a default value '{}' which is not valid for enum index {:?}",
[INFO] [stderr] 929 |                                 self.name, f, var, e)))?;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]     --> src/types.rs:1721:71
[INFO] [stderr]      |
[INFO] [stderr] 1721 |                     let test_names: Vec<String> = if name.starts_with(".") {
[INFO] [stderr]      |                                                                       ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]     --> src/types.rs:1947:24
[INFO] [stderr]      |
[INFO] [stderr] 1947 |         .ok_or_else(|| Error::from(Error::OutputFile(format!("{}", path.display()))))?;
[INFO] [stderr]      |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `Error::OutputFile(format!("{}", path.display()))`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `pb-rs`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]     --> src/types.rs:1432:26
[INFO] [stderr]      |
[INFO] [stderr] 1432 |                 m.path = in_file.clone().to_path_buf();
[INFO] [stderr]      |                          ^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]      |
[INFO] [stderr] 1432 |                 m.path = &(*in_file).clone().to_path_buf();
[INFO] [stderr]      |                          ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]      |
[INFO] [stderr] 1432 |                 m.path = &std::path::Path::clone(in_file).to_path_buf();
[INFO] [stderr]      |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]     --> src/types.rs:1433:20
[INFO] [stderr]      |
[INFO] [stderr] 1433 |                 if &import_search_path.len() > &0 {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]      |
[INFO] [stderr] 1433 |                 if import_search_path.len() > 0 {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^^^^^^^^^   ^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]     --> src/types.rs:1596:38
[INFO] [stderr]      |
[INFO] [stderr] 1596 |                     let cycle = &scc[i..i + cycle + 1];
[INFO] [stderr]      |                                      ^^^^^^^^^^^^^^^^ help: use: `i..=i + cycle`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]     --> src/types.rs:1721:71
[INFO] [stderr]      |
[INFO] [stderr] 1721 |                     let test_names: Vec<String> = if name.starts_with(".") {
[INFO] [stderr]      |                                                                       ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]     --> src/types.rs:1947:24
[INFO] [stderr]      |
[INFO] [stderr] 1947 |         .ok_or_else(|| Error::from(Error::OutputFile(format!("{}", path.display()))))?;
[INFO] [stderr]      |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `Error::OutputFile(format!("{}", path.display()))`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `pb-rs`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "4e0664e01b2fc24805a67a60d45b341a004ddaa1d556e0d5881ef510fa79778e"`
[INFO] running `"docker" "rm" "-f" "4e0664e01b2fc24805a67a60d45b341a004ddaa1d556e0d5881ef510fa79778e"`
[INFO] [stdout] 4e0664e01b2fc24805a67a60d45b341a004ddaa1d556e0d5881ef510fa79778e