[INFO] crate pazi 0.2.0 is already in cache
[INFO] extracting crate pazi 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/pazi/0.2.0
[INFO] extracting crate pazi 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pazi/0.2.0
[INFO] validating manifest of pazi-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pazi-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pazi-0.2.0
[INFO] finished frobbing pazi-0.2.0
[INFO] frobbed toml for pazi-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/pazi/0.2.0/Cargo.toml
[INFO] started frobbing pazi-0.2.0
[INFO] finished frobbing pazi-0.2.0
[INFO] frobbed toml for pazi-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pazi/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pazi-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pazi/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3ab29a864fadddb9f150a33665b50dcf09f1d337df539669264f90459262eb6f
[INFO] running `"docker" "start" "-a" "3ab29a864fadddb9f150a33665b50dcf09f1d337df539669264f90459262eb6f"`
[INFO] [stderr]     Checking snailquote v0.1.1
[INFO] [stderr]     Checking crossbeam-epoch v0.6.1
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking failure v0.1.5
[INFO] [stderr]     Checking which v2.0.1
[INFO] [stderr]     Checking crossbeam-channel v0.2.6
[INFO] [stderr]     Checking pazi v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/frecency.rs:39:13
[INFO] [stderr]    |
[INFO] [stderr] 39 |             max_size: max_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/frecent_paths.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             additions: additions,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additions`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/frecent_paths.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             removals: removals,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `removals`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/frecent_paths.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             frecency: frecency,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `frecency`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frecent_paths.rs:296:13
[INFO] [stderr]     |
[INFO] [stderr] 296 |             db: db,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `db`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/interactive.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         write!(alt, "{}\t{}\t{}\n", opts.len() - i, opts[i].1, opts[i].0)?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/frecency.rs:39:13
[INFO] [stderr]    |
[INFO] [stderr] 39 |             max_size: max_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/frecent_paths.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             additions: additions,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additions`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/frecent_paths.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             removals: removals,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `removals`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/frecent_paths.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             frecency: frecency,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `frecency`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frecent_paths.rs:296:13
[INFO] [stderr]     |
[INFO] [stderr] 296 |             db: db,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `db`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/interactive.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         write!(alt, "{}\t{}\t{}\n", opts.len() - i, opts[i].1, opts[i].0)?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/interactive.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             return Err(FilterError::NoSelection);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(FilterError::NoSelection)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/interactive.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 | /             return res.unwrap()
[INFO] [stderr] 54 | |                 .map_err(|_| FilterError::String("unable to read input".to_string()))
[INFO] [stderr] 55 | |                 .and_then(|val| {
[INFO] [stderr] 56 | |                     if val.trim().is_empty() {
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |                     }
[INFO] [stderr] 79 | |                 });
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 53 |             res.unwrap()
[INFO] [stderr] 54 |                 .map_err(|_| FilterError::String("unable to read input".to_string()))
[INFO] [stderr] 55 |                 .and_then(|val| {
[INFO] [stderr] 56 |                     if val.trim().is_empty() {
[INFO] [stderr] 57 |                         debug!("user input is empty");
[INFO] [stderr] 58 |                         Err(FilterError::NoSelection)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:338:13
[INFO] [stderr]     |
[INFO] [stderr] 338 |             return PaziResult::Success;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Success`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:342:13
[INFO] [stderr]     |
[INFO] [stderr] 342 |             return PaziResult::Error;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Error`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:352:17
[INFO] [stderr]     |
[INFO] [stderr] 352 |                 return PaziResult::Success;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Success`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:356:17
[INFO] [stderr]     |
[INFO] [stderr] 356 |                 return PaziResult::Error;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Error`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:361:13
[INFO] [stderr]     |
[INFO] [stderr] 361 |             return PaziResult::Error;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Error`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:467:13
[INFO] [stderr]     |
[INFO] [stderr] 467 |             return PaziResult::Success;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Success`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:471:13
[INFO] [stderr]     |
[INFO] [stderr] 471 |             return PaziResult::Error;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Error`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/interactive.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             return Err(FilterError::NoSelection);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(FilterError::NoSelection)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/interactive.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 | /             return res.unwrap()
[INFO] [stderr] 54 | |                 .map_err(|_| FilterError::String("unable to read input".to_string()))
[INFO] [stderr] 55 | |                 .and_then(|val| {
[INFO] [stderr] 56 | |                     if val.trim().is_empty() {
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |                     }
[INFO] [stderr] 79 | |                 });
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 53 |             res.unwrap()
[INFO] [stderr] 54 |                 .map_err(|_| FilterError::String("unable to read input".to_string()))
[INFO] [stderr] 55 |                 .and_then(|val| {
[INFO] [stderr] 56 |                     if val.trim().is_empty() {
[INFO] [stderr] 57 |                         debug!("user input is empty");
[INFO] [stderr] 58 |                         Err(FilterError::NoSelection)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:338:13
[INFO] [stderr]     |
[INFO] [stderr] 338 |             return PaziResult::Success;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Success`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:342:13
[INFO] [stderr]     |
[INFO] [stderr] 342 |             return PaziResult::Error;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Error`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:352:17
[INFO] [stderr]     |
[INFO] [stderr] 352 |                 return PaziResult::Success;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Success`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:356:17
[INFO] [stderr]     |
[INFO] [stderr] 356 |                 return PaziResult::Error;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Error`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:361:13
[INFO] [stderr]     |
[INFO] [stderr] 361 |             return PaziResult::Error;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Error`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:467:13
[INFO] [stderr]     |
[INFO] [stderr] 467 |             return PaziResult::Success;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Success`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:471:13
[INFO] [stderr]     |
[INFO] [stderr] 471 |             return PaziResult::Error;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PaziResult::Error`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/edit.rs:15:19
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn edit(data: &Vec<(String, f64)>) -> Result<PathFrecencyDiff, String> {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, f64)]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/edit.rs:35:24
[INFO] [stderr]    |
[INFO] [stderr] 35 |             for bin in vec!["editor", "nano", "vim", "vi"] {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["editor", "nano", "vim", "vi"]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/edit.rs:36:17
[INFO] [stderr]    |
[INFO] [stderr] 36 | /                 match which::which(bin) {
[INFO] [stderr] 37 | |                     Ok(ed) => {
[INFO] [stderr] 38 | |                         return Ok((ed, vec![]));
[INFO] [stderr] 39 | |                     }
[INFO] [stderr] 40 | |                     Err(_) => (),
[INFO] [stderr] 41 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 if let Ok(ed) = which::which(bin) {
[INFO] [stderr] 37 |     return Ok((ed, vec![]));
[INFO] [stderr] 38 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/edit.rs:92:20
[INFO] [stderr]    |
[INFO] [stderr] 92 |                 if item.1 != w {
[INFO] [stderr]    |                    ^^^^^^^^^^^ help: consider comparing them within some error: `(item.1 - w).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/edit.rs:92:20
[INFO] [stderr]    |
[INFO] [stderr] 92 |                 if item.1 != w {
[INFO] [stderr]    |                    ^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/edit.rs:116:27
[INFO] [stderr]     |
[INFO] [stderr] 116 | pub fn serialize(matches: &Vec<(String, f64)>) -> String {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, f64)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/edit.rs:137:12
[INFO] [stderr]     |
[INFO] [stderr] 137 |         if line.len() == 0 || line.starts_with('#') {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/frecency.rs:52:55
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let now_secs = since_epoch.as_secs() as f64 + since_epoch.subsec_nanos() as f64 * 1e-9;
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(since_epoch.subsec_nanos())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/frecency.rs:131:31
[INFO] [stderr]     |
[INFO] [stderr] 131 |             .map(|(k, v)| (k, v.clone()))
[INFO] [stderr]     |                               ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/frecency.rs:133:12
[INFO] [stderr]     |
[INFO] [stderr] 133 |         if items.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/frecency.rs:155:31
[INFO] [stderr]     |
[INFO] [stderr] 155 |             .map(|(k, v)| (k, v.clone()))
[INFO] [stderr]     |                               ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/frecency.rs:164:10
[INFO] [stderr]     |
[INFO] [stderr] 164 |         .expect(&format!("{} could not be compared to {}", lhs.1, rhs.1))
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{} could not be compared to {}", lhs.1))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/frecent_paths.rs:122:14
[INFO] [stderr]     |
[INFO] [stderr] 122 |             .ok_or("path did not have file component".to_string())?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "path did not have file component".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/frecent_paths.rs:128:14
[INFO] [stderr]     |
[INFO] [stderr] 128 |             .ok_or("unable to get parent".to_string())?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "unable to get parent".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/frecent_paths.rs:141:5
[INFO] [stderr]     |
[INFO] [stderr] 141 | /     pub fn items_with_frecency<'a>(&'a mut self) -> FrecentPathIter<'a> {
[INFO] [stderr] 142 | |         let items = self
[INFO] [stderr] 143 | |             .frecency
[INFO] [stderr] 144 | |             .items()
[INFO] [stderr] ...   |
[INFO] [stderr] 149 | |         FrecentPathIter::new(self, items)
[INFO] [stderr] 150 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/frecent_paths.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 | /     pub fn items_with_frecency_raw<'a>(&'a mut self) -> FrecentPathIter<'a> {
[INFO] [stderr] 153 | |         let mut items = self
[INFO] [stderr] 154 | |             .frecency
[INFO] [stderr] 155 | |             .items()
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |         FrecentPathIter::new(self, items)
[INFO] [stderr] 162 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/frecent_paths.rs:274:34
[INFO] [stderr]     |
[INFO] [stderr] 274 |     pub fn trim(&mut self, path: &String) -> bool {
[INFO] [stderr]     |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/importers/mod.rs:39:45
[INFO] [stderr]    |
[INFO] [stderr] 39 |             let data = match line.splitn(2, "|").next() {
[INFO] [stderr]    |                                             ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/interactive.rs:72:48
[INFO] [stderr]    |
[INFO] [stderr] 72 |                       } else if ndx > opts.len() {
[INFO] [stderr]    |  ________________________________________________^
[INFO] [stderr] 73 | |                         // handle separately from 'opts.get' to avoid underflow panicing
[INFO] [stderr] 74 | |                         Err(FilterError::String("index out of bounds".to_string()))
[INFO] [stderr] 75 | |                     } else {
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/interactive.rs:70:41
[INFO] [stderr]    |
[INFO] [stderr] 70 |                       if ndx > opts.len() {
[INFO] [stderr]    |  _________________________________________^
[INFO] [stderr] 71 | |                         Err(FilterError::String("index out of bounds".to_string()))
[INFO] [stderr] 72 | |                     } else if ndx > opts.len() {
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/interactive.rs:77:30
[INFO] [stderr]    |
[INFO] [stderr] 77 |                             .ok_or(FilterError::String("index out of bounds".to_string()))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| FilterError::String("index out of bounds".to_string()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/interactive.rs:117:9
[INFO] [stderr]     |
[INFO] [stderr] 117 | /         match self {
[INFO] [stderr] 118 | |             &FilterError::String(ref s) => s.fmt(f),
[INFO] [stderr] 119 | |             &FilterError::NoSelection => Ok(()),
[INFO] [stderr] 120 | |             &FilterError::WriteErr(ref ioe) => ioe.fmt(f),
[INFO] [stderr] 121 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 117 |         match *self {
[INFO] [stderr] 118 |             FilterError::String(ref s) => s.fmt(f),
[INFO] [stderr] 119 |             FilterError::NoSelection => Ok(()),
[INFO] [stderr] 120 |             FilterError::WriteErr(ref ioe) => ioe.fmt(f),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/matcher.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 | /             match self.0.matches(s, search) {
[INFO] [stderr] 62 | |                 Some(v) => {
[INFO] [stderr] 63 | |                     let attv = v * weight;
[INFO] [stderr] 64 | |                     res = match res {
[INFO] [stderr] ...  |
[INFO] [stderr] 73 | |                 None => {}
[INFO] [stderr] 74 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 61 |             if let Some(v) = self.0.matches(s, search) {
[INFO] [stderr] 62 |     let attv = v * weight;
[INFO] [stderr] 63 |     res = match res {
[INFO] [stderr] 64 |         None => Some(attv),
[INFO] [stderr] 65 |         Some(existing) => if attv > existing {
[INFO] [stderr] 66 |             Some(attv)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/main.rs:43:31
[INFO] [stderr]    |
[INFO] [stderr] 43 |       let extended_exit_codes = match std::env::var(PAZI_EXTENDED_EXIT_CODES_ENV!()) {
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 44 | |         Ok(_) => true,
[INFO] [stderr] 45 | |         Err(_) => false,
[INFO] [stderr] 46 | |     };
[INFO] [stderr]    | |_____^ help: try this: `std::env::var(PAZI_EXTENDED_EXIT_CODES_ENV!()).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/edit.rs:15:19
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn edit(data: &Vec<(String, f64)>) -> Result<PathFrecencyDiff, String> {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, f64)]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:111:57
[INFO] [stderr]     |
[INFO] [stderr] 111 |                   .arg(Arg::with_name("autojumper").help(&format!(
[INFO] [stderr]     |  _________________________________________________________^
[INFO] [stderr] 112 | |                     "the other autojump program to import from, only fasd is currently supported",
[INFO] [stderr] 113 | |                 ))),
[INFO] [stderr]     | |_________________^ help: consider using .to_string(): `"the other autojump program to import from, only fasd is currently supported".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/edit.rs:35:24
[INFO] [stderr]    |
[INFO] [stderr] 35 |             for bin in vec!["editor", "nano", "vim", "vi"] {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["editor", "nano", "vim", "vi"]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/edit.rs:36:17
[INFO] [stderr]    |
[INFO] [stderr] 36 | /                 match which::which(bin) {
[INFO] [stderr] 37 | |                     Ok(ed) => {
[INFO] [stderr] 38 | |                         return Ok((ed, vec![]));
[INFO] [stderr] 39 | |                     }
[INFO] [stderr] 40 | |                     Err(_) => (),
[INFO] [stderr] 41 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 if let Ok(ed) = which::which(bin) {
[INFO] [stderr] 37 |     return Ok((ed, vec![]));
[INFO] [stderr] 38 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/edit.rs:92:20
[INFO] [stderr]    |
[INFO] [stderr] 92 |                 if item.1 != w {
[INFO] [stderr]    |                    ^^^^^^^^^^^ help: consider comparing them within some error: `(item.1 - w).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/edit.rs:92:20
[INFO] [stderr]    |
[INFO] [stderr] 92 |                 if item.1 != w {
[INFO] [stderr]    |                    ^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/edit.rs:116:27
[INFO] [stderr]     |
[INFO] [stderr] 116 | pub fn serialize(matches: &Vec<(String, f64)>) -> String {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, f64)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/edit.rs:137:12
[INFO] [stderr]     |
[INFO] [stderr] 137 |         if line.len() == 0 || line.starts_with('#') {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/frecency.rs:52:55
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let now_secs = since_epoch.as_secs() as f64 + since_epoch.subsec_nanos() as f64 * 1e-9;
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(since_epoch.subsec_nanos())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:503:10
[INFO] [stderr]     |
[INFO] [stderr] 503 |         .ok_or("unable to determine config path".to_owned())?;
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "unable to determine config path".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/frecency.rs:131:31
[INFO] [stderr]     |
[INFO] [stderr] 131 |             .map(|(k, v)| (k, v.clone()))
[INFO] [stderr]     |                               ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/frecency.rs:133:12
[INFO] [stderr]     |
[INFO] [stderr] 133 |         if items.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/frecency.rs:155:31
[INFO] [stderr]     |
[INFO] [stderr] 155 |             .map(|(k, v)| (k, v.clone()))
[INFO] [stderr]     |                               ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/frecency.rs:164:10
[INFO] [stderr]     |
[INFO] [stderr] 164 |         .expect(&format!("{} could not be compared to {}", lhs.1, rhs.1))
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{} could not be compared to {}", lhs.1))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/frecent_paths.rs:122:14
[INFO] [stderr]     |
[INFO] [stderr] 122 |             .ok_or("path did not have file component".to_string())?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "path did not have file component".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/frecent_paths.rs:128:14
[INFO] [stderr]     |
[INFO] [stderr] 128 |             .ok_or("unable to get parent".to_string())?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "unable to get parent".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/frecent_paths.rs:141:5
[INFO] [stderr]     |
[INFO] [stderr] 141 | /     pub fn items_with_frecency<'a>(&'a mut self) -> FrecentPathIter<'a> {
[INFO] [stderr] 142 | |         let items = self
[INFO] [stderr] 143 | |             .frecency
[INFO] [stderr] 144 | |             .items()
[INFO] [stderr] ...   |
[INFO] [stderr] 149 | |         FrecentPathIter::new(self, items)
[INFO] [stderr] 150 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/frecent_paths.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 | /     pub fn items_with_frecency_raw<'a>(&'a mut self) -> FrecentPathIter<'a> {
[INFO] [stderr] 153 | |         let mut items = self
[INFO] [stderr] 154 | |             .frecency
[INFO] [stderr] 155 | |             .items()
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |         FrecentPathIter::new(self, items)
[INFO] [stderr] 162 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `pazi`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/frecent_paths.rs:274:34
[INFO] [stderr]     |
[INFO] [stderr] 274 |     pub fn trim(&mut self, path: &String) -> bool {
[INFO] [stderr]     |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/importers/mod.rs:39:45
[INFO] [stderr]    |
[INFO] [stderr] 39 |             let data = match line.splitn(2, "|").next() {
[INFO] [stderr]    |                                             ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/interactive.rs:72:48
[INFO] [stderr]    |
[INFO] [stderr] 72 |                       } else if ndx > opts.len() {
[INFO] [stderr]    |  ________________________________________________^
[INFO] [stderr] 73 | |                         // handle separately from 'opts.get' to avoid underflow panicing
[INFO] [stderr] 74 | |                         Err(FilterError::String("index out of bounds".to_string()))
[INFO] [stderr] 75 | |                     } else {
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/interactive.rs:70:41
[INFO] [stderr]    |
[INFO] [stderr] 70 |                       if ndx > opts.len() {
[INFO] [stderr]    |  _________________________________________^
[INFO] [stderr] 71 | |                         Err(FilterError::String("index out of bounds".to_string()))
[INFO] [stderr] 72 | |                     } else if ndx > opts.len() {
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/interactive.rs:77:30
[INFO] [stderr]    |
[INFO] [stderr] 77 |                             .ok_or(FilterError::String("index out of bounds".to_string()))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| FilterError::String("index out of bounds".to_string()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/interactive.rs:117:9
[INFO] [stderr]     |
[INFO] [stderr] 117 | /         match self {
[INFO] [stderr] 118 | |             &FilterError::String(ref s) => s.fmt(f),
[INFO] [stderr] 119 | |             &FilterError::NoSelection => Ok(()),
[INFO] [stderr] 120 | |             &FilterError::WriteErr(ref ioe) => ioe.fmt(f),
[INFO] [stderr] 121 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 117 |         match *self {
[INFO] [stderr] 118 |             FilterError::String(ref s) => s.fmt(f),
[INFO] [stderr] 119 |             FilterError::NoSelection => Ok(()),
[INFO] [stderr] 120 |             FilterError::WriteErr(ref ioe) => ioe.fmt(f),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/matcher.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 | /             match self.0.matches(s, search) {
[INFO] [stderr] 62 | |                 Some(v) => {
[INFO] [stderr] 63 | |                     let attv = v * weight;
[INFO] [stderr] 64 | |                     res = match res {
[INFO] [stderr] ...  |
[INFO] [stderr] 73 | |                 None => {}
[INFO] [stderr] 74 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 61 |             if let Some(v) = self.0.matches(s, search) {
[INFO] [stderr] 62 |     let attv = v * weight;
[INFO] [stderr] 63 |     res = match res {
[INFO] [stderr] 64 |         None => Some(attv),
[INFO] [stderr] 65 |         Some(existing) => if attv > existing {
[INFO] [stderr] 66 |             Some(attv)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/main.rs:43:31
[INFO] [stderr]    |
[INFO] [stderr] 43 |       let extended_exit_codes = match std::env::var(PAZI_EXTENDED_EXIT_CODES_ENV!()) {
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 44 | |         Ok(_) => true,
[INFO] [stderr] 45 | |         Err(_) => false,
[INFO] [stderr] 46 | |     };
[INFO] [stderr]    | |_____^ help: try this: `std::env::var(PAZI_EXTENDED_EXIT_CODES_ENV!()).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:111:57
[INFO] [stderr]     |
[INFO] [stderr] 111 |                   .arg(Arg::with_name("autojumper").help(&format!(
[INFO] [stderr]     |  _________________________________________________________^
[INFO] [stderr] 112 | |                     "the other autojump program to import from, only fasd is currently supported",
[INFO] [stderr] 113 | |                 ))),
[INFO] [stderr]     | |_________________^ help: consider using .to_string(): `"the other autojump program to import from, only fasd is currently supported".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:503:10
[INFO] [stderr]     |
[INFO] [stderr] 503 |         .ok_or("unable to determine config path".to_owned())?;
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "unable to determine config path".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `pazi`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "3ab29a864fadddb9f150a33665b50dcf09f1d337df539669264f90459262eb6f"`
[INFO] running `"docker" "rm" "-f" "3ab29a864fadddb9f150a33665b50dcf09f1d337df539669264f90459262eb6f"`
[INFO] [stdout] 3ab29a864fadddb9f150a33665b50dcf09f1d337df539669264f90459262eb6f