[INFO] crate paxos-rust 0.2.0 is already in cache [INFO] extracting crate paxos-rust 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/paxos-rust/0.2.0 [INFO] extracting crate paxos-rust 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/paxos-rust/0.2.0 [INFO] validating manifest of paxos-rust-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paxos-rust-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paxos-rust-0.2.0 [INFO] finished frobbing paxos-rust-0.2.0 [INFO] frobbed toml for paxos-rust-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/paxos-rust/0.2.0/Cargo.toml [INFO] started frobbing paxos-rust-0.2.0 [INFO] finished frobbing paxos-rust-0.2.0 [INFO] frobbed toml for paxos-rust-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/paxos-rust/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting paxos-rust-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/paxos-rust/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b5c227fb507531ebba8c5f12b4405e31dd5da8028bb99f7dd25b8742c1f3a310 [INFO] running `"docker" "start" "-a" "b5c227fb507531ebba8c5f12b4405e31dd5da8028bb99f7dd25b8742c1f3a310"` [INFO] [stderr] Checking paxos-rust v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/learner.rs:57:46 [INFO] [stderr] | [INFO] [stderr] 57 | self.accepted_received.entry(id).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/learner.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | if self.accepted_received.get(&id).unwrap().len() == self.quorum as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.accepted_received[&id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/learner.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | / self.accepted_received [INFO] [stderr] 64 | | .get(&id) [INFO] [stderr] 65 | | .unwrap() [INFO] [stderr] | |_________________________________^ help: try this: `&self.accepted_received[&id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/proposer.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | if self.promises_received.get(&self.proposal_n).unwrap().len() == self.quorum as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.promises_received[&self.proposal_n]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/proposer.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | if promises_vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `promises_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/proposer.rs:109:16 [INFO] [stderr] | [INFO] [stderr] 109 | if self.accepted_received.get(&self.proposal_n).unwrap().len() == self.quorum as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.accepted_received[&self.proposal_n]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/learner.rs:57:46 [INFO] [stderr] | [INFO] [stderr] 57 | self.accepted_received.entry(id).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/learner.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | if self.accepted_received.get(&id).unwrap().len() == self.quorum as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.accepted_received[&id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/learner.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | / self.accepted_received [INFO] [stderr] 64 | | .get(&id) [INFO] [stderr] 65 | | .unwrap() [INFO] [stderr] | |_________________________________^ help: try this: `&self.accepted_received[&id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/learner.rs:110:20 [INFO] [stderr] | [INFO] [stderr] 110 | assert_eq!(l.accepted_received.get(&id).unwrap().len(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&l.accepted_received[&id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/learner.rs:116:23 [INFO] [stderr] | [INFO] [stderr] 116 | from: i as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/proposer.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | if self.promises_received.get(&self.proposal_n).unwrap().len() == self.quorum as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.promises_received[&self.proposal_n]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/proposer.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | if promises_vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `promises_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/proposer.rs:109:16 [INFO] [stderr] | [INFO] [stderr] 109 | if self.accepted_received.get(&self.proposal_n).unwrap().len() == self.quorum as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.accepted_received[&self.proposal_n]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "b5c227fb507531ebba8c5f12b4405e31dd5da8028bb99f7dd25b8742c1f3a310"` [INFO] running `"docker" "rm" "-f" "b5c227fb507531ebba8c5f12b4405e31dd5da8028bb99f7dd25b8742c1f3a310"` [INFO] [stdout] b5c227fb507531ebba8c5f12b4405e31dd5da8028bb99f7dd25b8742c1f3a310