[INFO] crate patricia-trie 0.3.0 is already in cache [INFO] extracting crate patricia-trie 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/patricia-trie/0.3.0 [INFO] extracting crate patricia-trie 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/patricia-trie/0.3.0 [INFO] validating manifest of patricia-trie-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of patricia-trie-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing patricia-trie-0.3.0 [INFO] finished frobbing patricia-trie-0.3.0 [INFO] frobbed toml for patricia-trie-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/patricia-trie/0.3.0/Cargo.toml [INFO] started frobbing patricia-trie-0.3.0 [INFO] finished frobbing patricia-trie-0.3.0 [INFO] frobbed toml for patricia-trie-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/patricia-trie/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting patricia-trie-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/patricia-trie/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c4c505a3e2ae14bc501da5b053c4d75205479e3eb580155effe71beb633bf4b [INFO] running `"docker" "start" "-a" "7c4c505a3e2ae14bc501da5b053c4d75205479e3eb580155effe71beb633bf4b"` [INFO] [stderr] Checking hashdb v0.3.0 [INFO] [stderr] Checking plain_hasher v0.2.0 [INFO] [stderr] Checking rlp v0.3.0 [INFO] [stderr] Checking hashdb v0.2.1 [INFO] [stderr] Checking trie-standardmap v0.1.1 [INFO] [stderr] Checking memorydb v0.3.0 [INFO] [stderr] Checking triehash v0.3.0 [INFO] [stderr] Checking patricia-trie v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triedb.rs:126:4 [INFO] [stderr] | [INFO] [stderr] 126 | query: query, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triedbmut.rs:321:4 [INFO] [stderr] | [INFO] [stderr] 321 | db: db, [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triedbmut.rs:322:4 [INFO] [stderr] | [INFO] [stderr] 322 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triedbmut.rs:323:4 [INFO] [stderr] | [INFO] [stderr] 323 | root_handle: root_handle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triedbmut.rs:340:4 [INFO] [stderr] | [INFO] [stderr] 340 | db: db, [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triedbmut.rs:341:4 [INFO] [stderr] | [INFO] [stderr] 341 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triedbmut.rs:342:4 [INFO] [stderr] | [INFO] [stderr] 342 | root_handle: root_handle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/triedbmut.rs:1037:5 [INFO] [stderr] | [INFO] [stderr] 1037 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/triedbmut.rs:1048:5 [INFO] [stderr] | [INFO] [stderr] 1048 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/triedbmut.rs:1265:5 [INFO] [stderr] | [INFO] [stderr] 1265 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recorder.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fatdb.rs:90:4 [INFO] [stderr] | [INFO] [stderr] 90 | trie: trie, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `trie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking patricia-trie v0.2.2 [INFO] [stderr] Checking keccak-hasher v0.1.1 [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/node.rs:35:2 [INFO] [stderr] | [INFO] [stderr] 35 | Branch([&'a [u8]; 16], Option<&'a [u8]>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/node.rs:35:2 [INFO] [stderr] | [INFO] [stderr] 35 | Branch([&'a [u8]; 16], Option<&'a [u8]>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/triedb.rs:106:11 [INFO] [stderr] | [INFO] [stderr] 106 | .map(|v| Cow::Owned(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Cow::Owned` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/triedb.rs:127:10 [INFO] [stderr] | [INFO] [stderr] 127 | hash: self.root.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/triedb.rs:132:27 [INFO] [stderr] | [INFO] [stderr] 132 | fn iter<'a>(&'a self) -> Result> + 'a>, H::Out, C::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/triedb.rs:164:55 [INFO] [stderr] | [INFO] [stderr] 164 | let nodes: Vec> = nodes.into_iter().map(|n| TrieAwareDebugNode{trie: self.trie, key: n} ).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/triedb.rs:281:36 [INFO] [stderr] | [INFO] [stderr] 281 | Node::Branch(ref nodes, _) => match key.is_empty() { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 282 | | true => { [INFO] [stderr] 283 | | self.trail.push(Crumb { [INFO] [stderr] 284 | | status: Status::Entering, [INFO] [stderr] ... | [INFO] [stderr] 298 | | } [INFO] [stderr] 299 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 281 | Node::Branch(ref nodes, _) => if key.is_empty() { [INFO] [stderr] 282 | self.trail.push(Crumb { [INFO] [stderr] 283 | status: Status::Entering, [INFO] [stderr] 284 | node: node.clone().into(), [INFO] [stderr] 285 | }); [INFO] [stderr] 286 | return Ok(()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/triedb.rs:313:6 [INFO] [stderr] | [INFO] [stderr] 313 | Ok(self.descend_into_node(node.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 313 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/triedb.rs:319:3 [INFO] [stderr] | [INFO] [stderr] 319 | match &self.trail.last().expect("just pushed item; qed").node { [INFO] [stderr] | _________^ [INFO] [stderr] 320 | | &OwnedNode::Leaf(ref n, _) | &OwnedNode::Extension(ref n, _) => { [INFO] [stderr] 321 | | self.key_nibbles.extend((0..n.len()).map(|i| n.at(i))); [INFO] [stderr] 322 | | }, [INFO] [stderr] 323 | | _ => {} [INFO] [stderr] 324 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 319 | match self.trail.last().expect("just pushed item; qed").node { [INFO] [stderr] 320 | OwnedNode::Leaf(ref n, _) | OwnedNode::Extension(ref n, _) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/triedb.rs:348:41 [INFO] [stderr] | [INFO] [stderr] 348 | self.seek(&root_rlp, NibbleSlice::new(key.as_ref())) [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/triedbmut.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | maybe_child.map(|child| child_cb(child)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `child_cb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/triedbmut.rs:371:68 [INFO] [stderr] | [INFO] [stderr] 371 | fn inspect(&mut self, stored: Stored, inspector: F) -> Result, bool)>, H::Out, C::Error> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/triedbmut.rs:403:12 [INFO] [stderr] | [INFO] [stderr] 403 | hash: hash.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/triedbmut.rs:473:6 [INFO] [stderr] | [INFO] [stderr] 473 | match unchanged { [INFO] [stderr] | _____________________^ [INFO] [stderr] 474 | | true => InsertAction::Restore(branch), [INFO] [stderr] 475 | | false => InsertAction::Replace(branch), [INFO] [stderr] 476 | | } [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if unchanged { InsertAction::Restore(branch) } else { InsertAction::Replace(branch) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/triedbmut.rs:506:6 [INFO] [stderr] | [INFO] [stderr] 506 | match unchanged { [INFO] [stderr] | _____________________^ [INFO] [stderr] 507 | | // unchanged. restore [INFO] [stderr] 508 | | true => InsertAction::Restore(Node::Leaf(encoded.clone(), value)), [INFO] [stderr] 509 | | false => InsertAction::Replace(Node::Leaf(encoded.clone(), value)), [INFO] [stderr] 510 | | } [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if unchanged { InsertAction::Restore(Node::Leaf(encoded.clone(), value)) } else { InsertAction::Replace(Node::Leaf(encoded.clone(), value)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/triedbmut.rs:594:6 [INFO] [stderr] | [INFO] [stderr] 594 | match changed { [INFO] [stderr] | _____________________^ [INFO] [stderr] 595 | | true => InsertAction::Replace(new_ext), [INFO] [stderr] 596 | | false => InsertAction::Restore(new_ext), [INFO] [stderr] 597 | | } [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if changed { InsertAction::Replace(new_ext) } else { InsertAction::Restore(new_ext) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/triedbmut.rs:650:8 [INFO] [stderr] | [INFO] [stderr] 650 | match changed { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 651 | | // child was changed, so we were too. [INFO] [stderr] 652 | | true => Action::Replace(branch), [INFO] [stderr] 653 | | // unchanged, so we are too. [INFO] [stderr] 654 | | false => Action::Restore(branch), [INFO] [stderr] 655 | | } [INFO] [stderr] | |_____________________________^ help: consider using an if/else expression: `if changed { Action::Replace(branch) } else { Action::Restore(branch) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/triedbmut.rs:694:8 [INFO] [stderr] | [INFO] [stderr] 694 | match changed { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 695 | | true => Action::Replace(self.fix(Node::Extension(encoded, new_child))?), [INFO] [stderr] 696 | | false => Action::Restore(Node::Extension(encoded, new_child)), [INFO] [stderr] 697 | | } [INFO] [stderr] | |_____________________________^ help: consider using an if/else expression: `if changed { Action::Replace(self.fix(Node::Extension(encoded, new_child))?) } else { Action::Restore(Node::Extension(encoded, new_child)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `children` [INFO] [stderr] --> src/triedbmut.rs:730:14 [INFO] [stderr] | [INFO] [stderr] 730 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 730 | for (i, ) in children.iter().enumerate().take(16) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/sectriedb.rs:75:27 [INFO] [stderr] | [INFO] [stderr] 75 | fn iter<'a>(&'a self) -> Result> + 'a>, H::Out, C::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fatdb.rs:66:27 [INFO] [stderr] | [INFO] [stderr] 66 | fn iter<'a>(&'a self) -> Result> + 'a>, ::Out, C::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lookup.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(match slice == key { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 73 | | true => Some(self.query.decode(value)), [INFO] [stderr] 74 | | false => None, [INFO] [stderr] 75 | | }) [INFO] [stderr] | |_________________________^ help: consider using an if/else expression: `if slice == key { Some(self.query.decode(value)) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lookup.rs:85:39 [INFO] [stderr] | [INFO] [stderr] 85 | Node::Branch(children, value) => match key.is_empty() { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 86 | | true => return Ok(value.map(move |val| self.query.decode(val))), [INFO] [stderr] 87 | | false => { [INFO] [stderr] 88 | | node_data = children[key.at(0) as usize]; [INFO] [stderr] 89 | | key = key.mid(1); [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 85 | Node::Branch(children, value) => if key.is_empty() { return Ok(value.map(move |val| self.query.decode(val))) } else { [INFO] [stderr] 86 | node_data = children[key.at(0) as usize]; [INFO] [stderr] 87 | key = key.mid(1); [INFO] [stderr] 88 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/nibbleslice.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | match self.i <= self.p.len() { [INFO] [stderr] | _________^ [INFO] [stderr] 64 | | true => Some(self.p.at(self.i - 1)), [INFO] [stderr] 65 | | false => None, [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.i <= self.p.len() { Some(self.p.at(self.i - 1)) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:182:27 [INFO] [stderr] | [INFO] [stderr] 182 | fn iter<'a>(&'a self) -> Result> + 'a>, H::Out, C::Error>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:282:27 [INFO] [stderr] | [INFO] [stderr] 282 | fn iter<'a>(&'a self) -> Result> + 'a>, H::Out, C::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:321:3 [INFO] [stderr] | [INFO] [stderr] 321 | &self, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:324:7 [INFO] [stderr] | [INFO] [stderr] 324 | ) -> Result + 'db>, H::Out, >::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `patricia-trie`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "7c4c505a3e2ae14bc501da5b053c4d75205479e3eb580155effe71beb633bf4b"` [INFO] running `"docker" "rm" "-f" "7c4c505a3e2ae14bc501da5b053c4d75205479e3eb580155effe71beb633bf4b"` [INFO] [stdout] 7c4c505a3e2ae14bc501da5b053c4d75205479e3eb580155effe71beb633bf4b