[INFO] crate pathfinding 1.1.2 is already in cache [INFO] extracting crate pathfinding 1.1.2 into work/ex/clippy-test-run/sources/stable/reg/pathfinding/1.1.2 [INFO] extracting crate pathfinding 1.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pathfinding/1.1.2 [INFO] validating manifest of pathfinding-1.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pathfinding-1.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pathfinding-1.1.2 [INFO] finished frobbing pathfinding-1.1.2 [INFO] frobbed toml for pathfinding-1.1.2 written to work/ex/clippy-test-run/sources/stable/reg/pathfinding/1.1.2/Cargo.toml [INFO] started frobbing pathfinding-1.1.2 [INFO] finished frobbing pathfinding-1.1.2 [INFO] frobbed toml for pathfinding-1.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pathfinding/1.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pathfinding-1.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pathfinding/1.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d82950daf3b545e76d4c392e0b0fe44c2c05b04cca50bb6df878a6f20690888f [INFO] running `"docker" "start" "-a" "d82950daf3b545e76d4c392e0b0fe44c2c05b04cca50bb6df878a6f20690888f"` [INFO] [stderr] Checking movingai v0.7.0 [INFO] [stderr] Checking noisy_float v0.1.9 [INFO] [stderr] Checking pathfinding v1.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/pathfinding.rs:8:25 [INFO] [stderr] | [INFO] [stderr] 8 | fn successors(node: &u8) -> Vec<(u8, usize)> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> tests/matrix.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / fn square_rotate() { [INFO] [stderr] 68 | | // 0 1 => 2 0 => 3 2 => 1 3 [INFO] [stderr] 69 | | // 2 3 3 1 1 0 0 2 [INFO] [stderr] 70 | | let m1 = Matrix::square_from_vec(vec![0, 1, 2, 3]); [INFO] [stderr] ... | [INFO] [stderr] 119 | | assert_eq!(m2.rotated_cw(3), m1); [INFO] [stderr] 120 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> tests/topological_sort.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | fn tsig(succs: &[&[usize]]) -> Result>, (Vec>, Vec)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/topological_sort.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | let nodes: Vec = (0..succs.len()).into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..succs.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/matrix.rs:267:29 [INFO] [stderr] | [INFO] [stderr] 267 | for diagonal in vec![false, true] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[false, true]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> tests/connected-components.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | assert!([1, 2, 3, 4].into_iter().map(|n| h[n]).all_equal()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> tests/connected-components.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | assert!([1, 2, 3, 4].into_iter().map(|n| h[n]).all_equal()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pathfinding`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/strongly_connected_components.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | fn successors(n: &usize) -> Vec { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "d82950daf3b545e76d4c392e0b0fe44c2c05b04cca50bb6df878a6f20690888f"` [INFO] running `"docker" "rm" "-f" "d82950daf3b545e76d4c392e0b0fe44c2c05b04cca50bb6df878a6f20690888f"` [INFO] [stdout] d82950daf3b545e76d4c392e0b0fe44c2c05b04cca50bb6df878a6f20690888f