[INFO] crate pathfinder 0.5.4 is already in cache [INFO] extracting crate pathfinder 0.5.4 into work/ex/clippy-test-run/sources/stable/reg/pathfinder/0.5.4 [INFO] extracting crate pathfinder 0.5.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pathfinder/0.5.4 [INFO] validating manifest of pathfinder-0.5.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pathfinder-0.5.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pathfinder-0.5.4 [INFO] finished frobbing pathfinder-0.5.4 [INFO] frobbed toml for pathfinder-0.5.4 written to work/ex/clippy-test-run/sources/stable/reg/pathfinder/0.5.4/Cargo.toml [INFO] started frobbing pathfinder-0.5.4 [INFO] finished frobbing pathfinder-0.5.4 [INFO] frobbed toml for pathfinder-0.5.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pathfinder/0.5.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pathfinder-0.5.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pathfinder/0.5.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 42c333e2354aba1aca95d3ed3a7ff0ef1b6b1fa3a5765ee47fd4a580ff06b077 [INFO] running `"docker" "start" "-a" "42c333e2354aba1aca95d3ed3a7ff0ef1b6b1fa3a5765ee47fd4a580ff06b077"` [INFO] [stderr] Checking pythagoras v0.1.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking pathfinder v0.5.4 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tests/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | / mod tests { [INFO] [stderr] 3 | | [INFO] [stderr] 4 | | // Seperate from other tests, since it tests from_list for all [INFO] [stderr] 5 | | // classes that have it. [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/coordinate/mod.rs:166:31 [INFO] [stderr] | [INFO] [stderr] 166 | let co2: Coordinate = co1.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `co1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/coordinate/mod.rs:205:30 [INFO] [stderr] | [INFO] [stderr] 205 | println!("{:?}", v.get(0).unwrap().geo); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `&v[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/coordinate/mod.rs:280:24 [INFO] [stderr] | [INFO] [stderr] 280 | assert!(co1 == co1.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `co1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/coordinate/mod.rs:281:24 [INFO] [stderr] | [INFO] [stderr] 281 | assert!(co2 == co2.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `co2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/data/mod.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | let _ = file.write_all(content.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/data/mod.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | let _ = fs::remove_file("test.txt").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/map/gif.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let _ = fs::remove_file(output).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `plot` [INFO] [stderr] --> src/tools/mod.rs:371:18 [INFO] [stderr] | [INFO] [stderr] 371 | for i in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 371 | for (i, ) in plot.iter().enumerate().take(10) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/mod.rs:72:23 [INFO] [stderr] | [INFO] [stderr] 72 | fn no_move(a: &Vec, b: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/mod.rs:72:38 [INFO] [stderr] | [INFO] [stderr] 72 | fn no_move(a: &Vec, b: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.24s [INFO] running `"docker" "inspect" "42c333e2354aba1aca95d3ed3a7ff0ef1b6b1fa3a5765ee47fd4a580ff06b077"` [INFO] running `"docker" "rm" "-f" "42c333e2354aba1aca95d3ed3a7ff0ef1b6b1fa3a5765ee47fd4a580ff06b077"` [INFO] [stdout] 42c333e2354aba1aca95d3ed3a7ff0ef1b6b1fa3a5765ee47fd4a580ff06b077