[INFO] crate path_abs 0.4.1 is already in cache [INFO] extracting crate path_abs 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/path_abs/0.4.1 [INFO] extracting crate path_abs 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/path_abs/0.4.1 [INFO] validating manifest of path_abs-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of path_abs-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing path_abs-0.4.1 [INFO] finished frobbing path_abs-0.4.1 [INFO] frobbed toml for path_abs-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/path_abs/0.4.1/Cargo.toml [INFO] started frobbing path_abs-0.4.1 [INFO] finished frobbing path_abs-0.4.1 [INFO] frobbed toml for path_abs-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/path_abs/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting path_abs-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/path_abs/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9b021680b947f74b1fc4301d8c9ac92808ab2d19dd38bfcf764c6be38196dc4b [INFO] running `"docker" "start" "-a" "9b021680b947f74b1fc4301d8c9ac92808ab2d19dd38bfcf764c6be38196dc4b"` [INFO] [stderr] Checking std_prelude v0.2.12 [INFO] [stderr] Checking pretty_assertions v0.4.1 [INFO] [stderr] Checking stfu8 v0.2.4 [INFO] [stderr] Checking path_abs v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dir.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | fsread: fsread, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fsread` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/open.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/open.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/open.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/open.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/open.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | io_err: io_err, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `io_err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dir.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | fsread: fsread, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fsread` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/open.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/open.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/open.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/open.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/open.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | io_err: io_err, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `io_err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/arc.rs:190:20 [INFO] [stderr] | [INFO] [stderr] 190 | if let None = stack.pop() { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 191 | | return Err(Error::new( [INFO] [stderr] 192 | | io::Error::new(io::ErrorKind::NotFound, ".. consumed root"), [INFO] [stderr] 193 | | "resolving absolute", [INFO] [stderr] 194 | | self.clone(), [INFO] [stderr] 195 | | )); [INFO] [stderr] 196 | | } [INFO] [stderr] | |_____________- help: try this: `if stack.pop().is_none()` [INFO] [stderr] ... [INFO] [stderr] 213 | Component::ParentDir => pop_stack!(), [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/arc.rs:329:16 [INFO] [stderr] | [INFO] [stderr] 329 | if let None = stack.pop() { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 330 | | return Err(Error::new( [INFO] [stderr] 331 | | io::Error::new(io::ErrorKind::NotFound, ".. consumed root"), [INFO] [stderr] 332 | | "resolving absolute", [INFO] [stderr] 333 | | resolving.clone(), [INFO] [stderr] 334 | | )); [INFO] [stderr] 335 | | } [INFO] [stderr] | |_________- help: try this: `if stack.pop().is_none()` [INFO] [stderr] ... [INFO] [stderr] 416 | Component::ParentDir => pop_stack!(), [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/arc.rs:190:20 [INFO] [stderr] | [INFO] [stderr] 190 | if let None = stack.pop() { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 191 | | return Err(Error::new( [INFO] [stderr] 192 | | io::Error::new(io::ErrorKind::NotFound, ".. consumed root"), [INFO] [stderr] 193 | | "resolving absolute", [INFO] [stderr] 194 | | self.clone(), [INFO] [stderr] 195 | | )); [INFO] [stderr] 196 | | } [INFO] [stderr] | |_____________- help: try this: `if stack.pop().is_none()` [INFO] [stderr] ... [INFO] [stderr] 213 | Component::ParentDir => pop_stack!(), [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/arc.rs:329:16 [INFO] [stderr] | [INFO] [stderr] 329 | if let None = stack.pop() { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 330 | | return Err(Error::new( [INFO] [stderr] 331 | | io::Error::new(io::ErrorKind::NotFound, ".. consumed root"), [INFO] [stderr] 332 | | "resolving absolute", [INFO] [stderr] 333 | | resolving.clone(), [INFO] [stderr] 334 | | )); [INFO] [stderr] 335 | | } [INFO] [stderr] | |_________- help: try this: `if stack.pop().is_none()` [INFO] [stderr] ... [INFO] [stderr] 416 | Component::ParentDir => pop_stack!(), [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/ser.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | let foo = PathFile::create(tmp_abs.join("foo.txt")).expect("foo.txt"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/lib.rs:382:17 [INFO] [stderr] | [INFO] [stderr] 382 | let foo = PathFile::create(tmp_abs.join("foo.txt")).expect("foo.txt"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.03s [INFO] running `"docker" "inspect" "9b021680b947f74b1fc4301d8c9ac92808ab2d19dd38bfcf764c6be38196dc4b"` [INFO] running `"docker" "rm" "-f" "9b021680b947f74b1fc4301d8c9ac92808ab2d19dd38bfcf764c6be38196dc4b"` [INFO] [stdout] 9b021680b947f74b1fc4301d8c9ac92808ab2d19dd38bfcf764c6be38196dc4b