[INFO] crate pastebin_rust_api 0.5.13 is already in cache [INFO] extracting crate pastebin_rust_api 0.5.13 into work/ex/clippy-test-run/sources/stable/reg/pastebin_rust_api/0.5.13 [INFO] extracting crate pastebin_rust_api 0.5.13 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pastebin_rust_api/0.5.13 [INFO] validating manifest of pastebin_rust_api-0.5.13 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pastebin_rust_api-0.5.13 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pastebin_rust_api-0.5.13 [INFO] finished frobbing pastebin_rust_api-0.5.13 [INFO] frobbed toml for pastebin_rust_api-0.5.13 written to work/ex/clippy-test-run/sources/stable/reg/pastebin_rust_api/0.5.13/Cargo.toml [INFO] started frobbing pastebin_rust_api-0.5.13 [INFO] finished frobbing pastebin_rust_api-0.5.13 [INFO] frobbed toml for pastebin_rust_api-0.5.13 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pastebin_rust_api/0.5.13/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pastebin_rust_api-0.5.13 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pastebin_rust_api/0.5.13:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 411a7a6287bf2563b565ebf63cf3510d84e0086afaf60837e872b1e62eaea0c6 [INFO] running `"docker" "start" "-a" "411a7a6287bf2563b565ebf63cf3510d84e0086afaf60837e872b1e62eaea0c6"` [INFO] [stderr] Checking xml-rs v0.2.2 [INFO] [stderr] Checking reqwest v0.5.2 [INFO] [stderr] Checking treexml v0.3.0 [INFO] [stderr] Checking pastebin_rust_api v0.5.13 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/paster/mod.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | Paster { developer_key: developer_key } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `developer_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/paster/mod.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | Paster { developer_key: developer_key } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `developer_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | expire_date: expire_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expire_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | private: private, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `private` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | format_short: format_short, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `format_short` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | format_long: format_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `format_long` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | hits: hits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | expire_date: expire_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expire_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | private: private, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `private` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | format_short: format_short, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `format_short` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | format_long: format_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `format_long` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paste.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | hits: hits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/paster/access.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / match access { [INFO] [stderr] 11 | | &Access::Public => "0", [INFO] [stderr] 12 | | &Access::Unlisted => "1", [INFO] [stderr] 13 | | &Access::Private => "2", [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | match *access { [INFO] [stderr] 11 | Access::Public => "0", [INFO] [stderr] 12 | Access::Unlisted => "1", [INFO] [stderr] 13 | Access::Private => "2", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/paster/expiration.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match expiration { [INFO] [stderr] 14 | | &Expiration::Never => "N", [INFO] [stderr] 15 | | &Expiration::TenMinutes => "10M", [INFO] [stderr] 16 | | &Expiration::OneHour => "1H", [INFO] [stderr] ... | [INFO] [stderr] 20 | | &Expiration::OneMonth => "1M", [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *expiration { [INFO] [stderr] 14 | Expiration::Never => "N", [INFO] [stderr] 15 | Expiration::TenMinutes => "10M", [INFO] [stderr] 16 | Expiration::OneHour => "1H", [INFO] [stderr] 17 | Expiration::OneDay => "1D", [INFO] [stderr] 18 | Expiration::OneWeek => "1W", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/paster/format.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | / match format { [INFO] [stderr] 260 | | &Format::CS4 => "4cs", [INFO] [stderr] 261 | | &Format::ACMECrossAssembler6502 => "6502acme", [INFO] [stderr] 262 | | &Format::KickAssembler6502 => "6502kickass", [INFO] [stderr] ... | [INFO] [stderr] 512 | | &Format::ZXBasic => "zxbasic", [INFO] [stderr] 513 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | match *format { [INFO] [stderr] 260 | Format::CS4 => "4cs", [INFO] [stderr] 261 | Format::ACMECrossAssembler6502 => "6502acme", [INFO] [stderr] 262 | Format::KickAssembler6502 => "6502kickass", [INFO] [stderr] 263 | Format::TASM64TASS6502 => "6502tasm", [INFO] [stderr] 264 | Format::ABAP => "abap", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:117:19 [INFO] [stderr] | [INFO] [stderr] 117 | let doc = Document::parse(xml.as_bytes()).unwrap_or(Document::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `Document::parse(xml.as_bytes()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:131:31 [INFO] [stderr] | [INFO] [stderr] 131 | let mut xml: String = self.send_post_request(&url, ¶ms) [INFO] [stderr] | _______________________________^ [INFO] [stderr] 132 | | .unwrap_or(String::new()); [INFO] [stderr] | |___________________________________________________________^ help: try this: `self.send_post_request(&url, ¶ms).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:135:19 [INFO] [stderr] | [INFO] [stderr] 135 | let doc = Document::parse(xml.as_bytes()).unwrap_or(Document::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `Document::parse(xml.as_bytes()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | let key = i.find_child(|e| e.name == "paste_key") [INFO] [stderr] | _______________________^ [INFO] [stderr] 145 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_key").cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:146:26 [INFO] [stderr] | [INFO] [stderr] 146 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | let date = i.find_child(|e| e.name == "paste_date") [INFO] [stderr] | ________________________^ [INFO] [stderr] 149 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_date").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:150:26 [INFO] [stderr] | [INFO] [stderr] 150 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | let title = i.find_child(|e| e.name == "paste_date") [INFO] [stderr] | _________________________^ [INFO] [stderr] 153 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_date").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:154:26 [INFO] [stderr] | [INFO] [stderr] 154 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | let size = i.find_child(|e| e.name == "paste_size") [INFO] [stderr] | ________________________^ [INFO] [stderr] 157 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_size").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:158:26 [INFO] [stderr] | [INFO] [stderr] 158 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:160:26 [INFO] [stderr] | [INFO] [stderr] 160 | let expire = i.find_child(|e| e.name == "paste_expire_date") [INFO] [stderr] | __________________________^ [INFO] [stderr] 161 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_expire_date").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:162:26 [INFO] [stderr] | [INFO] [stderr] 162 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:164:27 [INFO] [stderr] | [INFO] [stderr] 164 | let private = i.find_child(|e| e.name == "paste_private") [INFO] [stderr] | ___________________________^ [INFO] [stderr] 165 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_private").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:166:26 [INFO] [stderr] | [INFO] [stderr] 166 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:168:32 [INFO] [stderr] | [INFO] [stderr] 168 | let format_short = i.find_child(|e| e.name == "paste_format_short") [INFO] [stderr] | ________________________________^ [INFO] [stderr] 169 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_format_short").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:170:26 [INFO] [stderr] | [INFO] [stderr] 170 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:172:31 [INFO] [stderr] | [INFO] [stderr] 172 | let format_long = i.find_child(|e| e.name == "paste_format_long") [INFO] [stderr] | _______________________________^ [INFO] [stderr] 173 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_format_long").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:174:26 [INFO] [stderr] | [INFO] [stderr] 174 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:176:23 [INFO] [stderr] | [INFO] [stderr] 176 | let url = i.find_child(|e| e.name == "paste_url") [INFO] [stderr] | _______________________^ [INFO] [stderr] 177 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_url").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:180:24 [INFO] [stderr] | [INFO] [stderr] 180 | let hits = i.find_child(|e| e.name == "paste_hits") [INFO] [stderr] | ________________________^ [INFO] [stderr] 181 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_hits").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:182:26 [INFO] [stderr] | [INFO] [stderr] 182 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/paster/access.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / match access { [INFO] [stderr] 11 | | &Access::Public => "0", [INFO] [stderr] 12 | | &Access::Unlisted => "1", [INFO] [stderr] 13 | | &Access::Private => "2", [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | match *access { [INFO] [stderr] 11 | Access::Public => "0", [INFO] [stderr] 12 | Access::Unlisted => "1", [INFO] [stderr] 13 | Access::Private => "2", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/paster/expiration.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match expiration { [INFO] [stderr] 14 | | &Expiration::Never => "N", [INFO] [stderr] 15 | | &Expiration::TenMinutes => "10M", [INFO] [stderr] 16 | | &Expiration::OneHour => "1H", [INFO] [stderr] ... | [INFO] [stderr] 20 | | &Expiration::OneMonth => "1M", [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *expiration { [INFO] [stderr] 14 | Expiration::Never => "N", [INFO] [stderr] 15 | Expiration::TenMinutes => "10M", [INFO] [stderr] 16 | Expiration::OneHour => "1H", [INFO] [stderr] 17 | Expiration::OneDay => "1D", [INFO] [stderr] 18 | Expiration::OneWeek => "1W", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/objects/paste.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new(key: String, [INFO] [stderr] 17 | | date: String, [INFO] [stderr] 18 | | title: String, [INFO] [stderr] 19 | | size: String, [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/paster/format.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | / match format { [INFO] [stderr] 260 | | &Format::CS4 => "4cs", [INFO] [stderr] 261 | | &Format::ACMECrossAssembler6502 => "6502acme", [INFO] [stderr] 262 | | &Format::KickAssembler6502 => "6502kickass", [INFO] [stderr] ... | [INFO] [stderr] 512 | | &Format::ZXBasic => "zxbasic", [INFO] [stderr] 513 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | match *format { [INFO] [stderr] 260 | Format::CS4 => "4cs", [INFO] [stderr] 261 | Format::ACMECrossAssembler6502 => "6502acme", [INFO] [stderr] 262 | Format::KickAssembler6502 => "6502kickass", [INFO] [stderr] 263 | Format::TASM64TASS6502 => "6502tasm", [INFO] [stderr] 264 | Format::ABAP => "abap", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:117:19 [INFO] [stderr] | [INFO] [stderr] 117 | let doc = Document::parse(xml.as_bytes()).unwrap_or(Document::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `Document::parse(xml.as_bytes()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:131:31 [INFO] [stderr] | [INFO] [stderr] 131 | let mut xml: String = self.send_post_request(&url, ¶ms) [INFO] [stderr] | _______________________________^ [INFO] [stderr] 132 | | .unwrap_or(String::new()); [INFO] [stderr] | |___________________________________________________________^ help: try this: `self.send_post_request(&url, ¶ms).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:135:19 [INFO] [stderr] | [INFO] [stderr] 135 | let doc = Document::parse(xml.as_bytes()).unwrap_or(Document::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `Document::parse(xml.as_bytes()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | let key = i.find_child(|e| e.name == "paste_key") [INFO] [stderr] | _______________________^ [INFO] [stderr] 145 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_key").cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:146:26 [INFO] [stderr] | [INFO] [stderr] 146 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | let date = i.find_child(|e| e.name == "paste_date") [INFO] [stderr] | ________________________^ [INFO] [stderr] 149 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_date").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:150:26 [INFO] [stderr] | [INFO] [stderr] 150 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | let title = i.find_child(|e| e.name == "paste_date") [INFO] [stderr] | _________________________^ [INFO] [stderr] 153 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_date").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:154:26 [INFO] [stderr] | [INFO] [stderr] 154 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | let size = i.find_child(|e| e.name == "paste_size") [INFO] [stderr] | ________________________^ [INFO] [stderr] 157 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_size").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:158:26 [INFO] [stderr] | [INFO] [stderr] 158 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:160:26 [INFO] [stderr] | [INFO] [stderr] 160 | let expire = i.find_child(|e| e.name == "paste_expire_date") [INFO] [stderr] | __________________________^ [INFO] [stderr] 161 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_expire_date").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:162:26 [INFO] [stderr] | [INFO] [stderr] 162 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:164:27 [INFO] [stderr] | [INFO] [stderr] 164 | let private = i.find_child(|e| e.name == "paste_private") [INFO] [stderr] | ___________________________^ [INFO] [stderr] 165 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_private").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:166:26 [INFO] [stderr] | [INFO] [stderr] 166 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:168:32 [INFO] [stderr] | [INFO] [stderr] 168 | let format_short = i.find_child(|e| e.name == "paste_format_short") [INFO] [stderr] | ________________________________^ [INFO] [stderr] 169 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_format_short").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:170:26 [INFO] [stderr] | [INFO] [stderr] 170 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:172:31 [INFO] [stderr] | [INFO] [stderr] 172 | let format_long = i.find_child(|e| e.name == "paste_format_long") [INFO] [stderr] | _______________________________^ [INFO] [stderr] 173 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_format_long").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:174:26 [INFO] [stderr] | [INFO] [stderr] 174 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:176:23 [INFO] [stderr] | [INFO] [stderr] 176 | let url = i.find_child(|e| e.name == "paste_url") [INFO] [stderr] | _______________________^ [INFO] [stderr] 177 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_url").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/paster/mod.rs:180:24 [INFO] [stderr] | [INFO] [stderr] 180 | let hits = i.find_child(|e| e.name == "paste_hits") [INFO] [stderr] | ________________________^ [INFO] [stderr] 181 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `i.find_child(|e| e.name == "paste_hits").cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/paster/mod.rs:182:26 [INFO] [stderr] | [INFO] [stderr] 182 | .map(|k| k.text.unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `k.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/objects/paste.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new(key: String, [INFO] [stderr] 17 | | date: String, [INFO] [stderr] 18 | | title: String, [INFO] [stderr] 19 | | size: String, [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/test_api.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / if let Some(message) = response.ok() { [INFO] [stderr] 19 | | println!("URL: {}", message); [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(message)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/test_api.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / if let Some(user_key) = response.ok() { [INFO] [stderr] 29 | | println!("user_key: {}", user_key); [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(user_key)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/test_api.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / if let Some(user_key) = user_key_response.ok() { [INFO] [stderr] 39 | | let url_response = paster.paste("", [INFO] [stderr] 40 | | &Access::Unlisted, [INFO] [stderr] 41 | | Some("TestHtml"), [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(user_key)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/test_api.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / if let Some(message) = url_response.ok() { [INFO] [stderr] 47 | | println!("URL: {}", message); [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(message)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/test_api.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / if let Some(message) = response.ok() { [INFO] [stderr] 64 | | println!("URL: {}", message); [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(message)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/test_api.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / if let Some(trending) = trending.ok() { [INFO] [stderr] 74 | | println!("URL: {}", trending[0].url); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(trending)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/test_api.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / if let Some(user_key) = user_key_response.ok() { [INFO] [stderr] 84 | | let pastes = paster.get_my_posts(&user_key, 100); [INFO] [stderr] 85 | | assert!(pastes.is_ok()); [INFO] [stderr] 86 | | if let Some(pastes) = pastes.ok() { [INFO] [stderr] 87 | | println!("paste count: {}", pastes.len()); [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(user_key)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> tests/test_api.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / if let Some(pastes) = pastes.ok() { [INFO] [stderr] 87 | | println!("paste count: {}", pastes.len()); [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(pastes)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.83s [INFO] running `"docker" "inspect" "411a7a6287bf2563b565ebf63cf3510d84e0086afaf60837e872b1e62eaea0c6"` [INFO] running `"docker" "rm" "-f" "411a7a6287bf2563b565ebf63cf3510d84e0086afaf60837e872b1e62eaea0c6"` [INFO] [stdout] 411a7a6287bf2563b565ebf63cf3510d84e0086afaf60837e872b1e62eaea0c6