[INFO] crate pastebin 0.17.9 is already in cache [INFO] extracting crate pastebin 0.17.9 into work/ex/clippy-test-run/sources/stable/reg/pastebin/0.17.9 [INFO] extracting crate pastebin 0.17.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pastebin/0.17.9 [INFO] validating manifest of pastebin-0.17.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pastebin-0.17.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pastebin-0.17.9 [INFO] finished frobbing pastebin-0.17.9 [INFO] frobbed toml for pastebin-0.17.9 written to work/ex/clippy-test-run/sources/stable/reg/pastebin/0.17.9/Cargo.toml [INFO] started frobbing pastebin-0.17.9 [INFO] finished frobbing pastebin-0.17.9 [INFO] frobbed toml for pastebin-0.17.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pastebin/0.17.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pastebin-0.17.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pastebin/0.17.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d9886826b7871451d40c42deb94fcbafaa2237570a87ed181786ffb18c25dfab [INFO] running `"docker" "start" "-a" "d9886826b7871451d40c42deb94fcbafaa2237570a87ed181786ffb18c25dfab"` [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking bson v0.11.1 [INFO] [stderr] Checking tera v0.11.20 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tree_magic v0.2.1 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking pastebin v0.17.9 (/opt/crater/workdir) [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/id.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | res += (buf[buf.len() - i - 1] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buf[buf.len() - i - 1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/id.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 18 | for (i, ) in buf.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pastebin.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | .map_err(|e| Error::Url(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pastebin.rs:97:50 [INFO] [stderr] | [INFO] [stderr] 97 | let paste = itry!(self.db.load_data(id)).ok_or(Error::IdNotFound(id))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::IdNotFound(id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test.rs:108:25 [INFO] [stderr] | [INFO] [stderr] 108 | const LISTEN_ADDR: &'static str = "127.0.0.1:8000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test.rs:145:25 [INFO] [stderr] | [INFO] [stderr] 145 | const LISTEN_ADDR: &'static str = "127.0.0.1:8001"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test.rs:168:25 [INFO] [stderr] | [INFO] [stderr] 168 | const LISTEN_ADDR: &'static str = "127.0.0.1:8002"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test.rs:189:25 [INFO] [stderr] | [INFO] [stderr] 189 | const LISTEN_ADDR: &'static str = "127.0.0.1:8003"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/id.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | res += (buf[buf.len() - i - 1] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buf[buf.len() - i - 1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/id.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 18 | for (i, ) in buf.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pastebin.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | .map_err(|e| Error::Url(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pastebin.rs:97:50 [INFO] [stderr] | [INFO] [stderr] 97 | let paste = itry!(self.db.load_data(id)).ok_or(Error::IdNotFound(id))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::IdNotFound(id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/test.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / self.storage.lock() [INFO] [stderr] 26 | | .unwrap() [INFO] [stderr] 27 | | .get(&id) [INFO] [stderr] 28 | | .map(|data| data.clone()) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 25 | self.storage.lock() [INFO] [stderr] 26 | .unwrap() [INFO] [stderr] 27 | .get(&id).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.34s [INFO] running `"docker" "inspect" "d9886826b7871451d40c42deb94fcbafaa2237570a87ed181786ffb18c25dfab"` [INFO] running `"docker" "rm" "-f" "d9886826b7871451d40c42deb94fcbafaa2237570a87ed181786ffb18c25dfab"` [INFO] [stdout] d9886826b7871451d40c42deb94fcbafaa2237570a87ed181786ffb18c25dfab