[INFO] crate parsswd 0.1.0 is already in cache [INFO] extracting crate parsswd 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/parsswd/0.1.0 [INFO] extracting crate parsswd 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parsswd/0.1.0 [INFO] validating manifest of parsswd-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of parsswd-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing parsswd-0.1.0 [INFO] finished frobbing parsswd-0.1.0 [INFO] frobbed toml for parsswd-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/parsswd/0.1.0/Cargo.toml [INFO] started frobbing parsswd-0.1.0 [INFO] finished frobbing parsswd-0.1.0 [INFO] frobbed toml for parsswd-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parsswd/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting parsswd-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/parsswd/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f19a45aae21266533de96a63c92836044859fab4db62a7b0c913082dc073bbc7 [INFO] running `"docker" "start" "-a" "f19a45aae21266533de96a63c92836044859fab4db62a7b0c913082dc073bbc7"` [INFO] [stderr] Compiling skeptic v0.4.0 [INFO] [stderr] Compiling parsswd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn from_str(s: &'a str) -> Option> { [INFO] [stderr] 14 | | let mut entries = s.splitn(7, ':'); [INFO] [stderr] 15 | | Some(PwEnt { [INFO] [stderr] 16 | | name: match entries.next() { None => return None, Some(s) => s }, [INFO] [stderr] ... | [INFO] [stderr] 23 | | }) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn from_str(s: &'a str) -> Option> { [INFO] [stderr] 37 | | let mut entries = s.splitn(4, ':'); [INFO] [stderr] 38 | | Some(GrpEnt { [INFO] [stderr] 39 | | name: match entries.next() { None => return None, Some(s) => s }, [INFO] [stderr] ... | [INFO] [stderr] 43 | | }) [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn from_str(s: &'a str) -> Option> { [INFO] [stderr] 14 | | let mut entries = s.splitn(7, ':'); [INFO] [stderr] 15 | | Some(PwEnt { [INFO] [stderr] 16 | | name: match entries.next() { None => return None, Some(s) => s }, [INFO] [stderr] ... | [INFO] [stderr] 23 | | }) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn from_str(s: &'a str) -> Option> { [INFO] [stderr] 37 | | let mut entries = s.splitn(4, ':'); [INFO] [stderr] 38 | | Some(GrpEnt { [INFO] [stderr] 39 | | name: match entries.next() { None => return None, Some(s) => s }, [INFO] [stderr] ... | [INFO] [stderr] 43 | | }) [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> /opt/crater/target/debug/build/parsswd-8516170e14155657/out/skeptic-tests.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let ref s = format!("{}", r#"extern crate parsswd; [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 5 | | [INFO] [stderr] 6 | | use parsswd::{PwEnt, GrpEnt}; [INFO] [stderr] 7 | | use std::io::prelude::*; [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | "#); [INFO] [stderr] | |____- help: try: `let s = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> /opt/crater/target/debug/build/parsswd-8516170e14155657/out/skeptic-tests.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | let ref s = format!("{}", r#"extern crate parsswd; [INFO] [stderr] | _________________^ [INFO] [stderr] 5 | | [INFO] [stderr] 6 | | use parsswd::{PwEnt, GrpEnt}; [INFO] [stderr] 7 | | use std::io::prelude::*; [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | "#); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( r#"extern crate parsswd; [INFO] [stderr] 3 | [INFO] [stderr] 4 | use parsswd::{PwEnt, GrpEnt}; [INFO] [stderr] 5 | use std::io::prelude::*; [INFO] [stderr] 6 | use std::io::BufReader; [INFO] [stderr] 7 | use std::fs::File; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.78s [INFO] running `"docker" "inspect" "f19a45aae21266533de96a63c92836044859fab4db62a7b0c913082dc073bbc7"` [INFO] running `"docker" "rm" "-f" "f19a45aae21266533de96a63c92836044859fab4db62a7b0c913082dc073bbc7"` [INFO] [stdout] f19a45aae21266533de96a63c92836044859fab4db62a7b0c913082dc073bbc7