[INFO] crate parking_lot 0.7.0 is already in cache [INFO] extracting crate parking_lot 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/parking_lot/0.7.0 [INFO] extracting crate parking_lot 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parking_lot/0.7.0 [INFO] validating manifest of parking_lot-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of parking_lot-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing parking_lot-0.7.0 [INFO] finished frobbing parking_lot-0.7.0 [INFO] frobbed toml for parking_lot-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/parking_lot/0.7.0/Cargo.toml [INFO] started frobbing parking_lot-0.7.0 [INFO] finished frobbing parking_lot-0.7.0 [INFO] frobbed toml for parking_lot-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parking_lot/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting parking_lot-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/parking_lot/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 422e92e05977b087d89c88ca214e12613d2993ef2950dcd16fe9f3d0541b4212 [INFO] running `"docker" "start" "-a" "422e92e05977b087d89c88ca214e12613d2993ef2950dcd16fe9f3d0541b4212"` [INFO] [stderr] Checking parking_lot v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/raw_rwlock.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 130 | | if self [INFO] [stderr] 131 | | .state [INFO] [stderr] 132 | | .compare_exchange_weak( [INFO] [stderr] ... | [INFO] [stderr] 140 | | } [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | } else if self [INFO] [stderr] 130 | .state [INFO] [stderr] 131 | .compare_exchange_weak( [INFO] [stderr] 132 | state, [INFO] [stderr] 133 | state - SHARED_GUARD, [INFO] [stderr] 134 | Ordering::Release, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/raw_rwlock.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 164 | | if self [INFO] [stderr] 165 | | .state [INFO] [stderr] 166 | | .compare_exchange_weak( [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 163 | } else if self [INFO] [stderr] 164 | .state [INFO] [stderr] 165 | .compare_exchange_weak( [INFO] [stderr] 166 | state, [INFO] [stderr] 167 | state - SHARED_GUARD, [INFO] [stderr] 168 | Ordering::Release, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/condvar.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn timed_out(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/once.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn poisoned(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/once.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn done(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/once.rs:95:1 [INFO] [stderr] | [INFO] [stderr] 95 | pub const ONCE_INIT: Once = Once(ATOMIC_U8_INIT); [INFO] [stderr] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: make this a static item: `static` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/mutex.rs:245:39 [INFO] [stderr] | [INFO] [stderr] 245 | let _ = thread::spawn(move || -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/raw_rwlock.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 130 | | if self [INFO] [stderr] 131 | | .state [INFO] [stderr] 132 | | .compare_exchange_weak( [INFO] [stderr] ... | [INFO] [stderr] 140 | | } [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | } else if self [INFO] [stderr] 130 | .state [INFO] [stderr] 131 | .compare_exchange_weak( [INFO] [stderr] 132 | state, [INFO] [stderr] 133 | state - SHARED_GUARD, [INFO] [stderr] 134 | Ordering::Release, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/raw_rwlock.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 164 | | if self [INFO] [stderr] 165 | | .state [INFO] [stderr] 166 | | .compare_exchange_weak( [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 163 | } else if self [INFO] [stderr] 164 | .state [INFO] [stderr] 165 | .compare_exchange_weak( [INFO] [stderr] 166 | state, [INFO] [stderr] 167 | state - SHARED_GUARD, [INFO] [stderr] 168 | Ordering::Release, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/raw_rwlock.rs:920:16 [INFO] [stderr] | [INFO] [stderr] 920 | if state & PARKED_BIT == 0 [INFO] [stderr] | ________________^ [INFO] [stderr] 921 | | || (state & UPGRADING_BIT == 0 && state & GUARD_COUNT_MASK != SHARED_GUARD) [INFO] [stderr] 922 | | || (state & UPGRADING_BIT != 0 [INFO] [stderr] 923 | | && state & GUARD_COUNT_MASK != UPGRADABLE_GUARD + SHARED_GUARD) [INFO] [stderr] | |___________________________________________________________________________________^ help: try: `state & PARKED_BIT == 0 || state & UPGRADING_BIT == 0 && state & GUARD_COUNT_MASK != SHARED_GUARD || state & UPGRADING_BIT != 0 && state & GUARD_COUNT_MASK != UPGRADABLE_GUARD + SHARED_GUARD` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/rwlock.rs:319:39 [INFO] [stderr] | [INFO] [stderr] 319 | let _ = thread::spawn(move || -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `parking_lot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/condvar.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn timed_out(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/condvar.rs:557:68 [INFO] [stderr] | [INFO] [stderr] 557 | let timeout_res = c.wait_for(&mut g, Duration::from_millis(u32::max_value() as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/condvar.rs:578:52 [INFO] [stderr] | [INFO] [stderr] 578 | Instant::now() + Duration::from_millis(u32::max_value() as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/condvar.rs:612:9 [INFO] [stderr] | [INFO] [stderr] 612 | let _ = c.wait(&mut m3.lock()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/once.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn poisoned(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/once.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn done(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/once.rs:95:1 [INFO] [stderr] | [INFO] [stderr] 95 | pub const ONCE_INIT: Once = Once(ATOMIC_U8_INIT); [INFO] [stderr] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: make this a static item: `static` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/raw_rwlock.rs:920:16 [INFO] [stderr] | [INFO] [stderr] 920 | if state & PARKED_BIT == 0 [INFO] [stderr] | ________________^ [INFO] [stderr] 921 | | || (state & UPGRADING_BIT == 0 && state & GUARD_COUNT_MASK != SHARED_GUARD) [INFO] [stderr] 922 | | || (state & UPGRADING_BIT != 0 [INFO] [stderr] 923 | | && state & GUARD_COUNT_MASK != UPGRADABLE_GUARD + SHARED_GUARD) [INFO] [stderr] | |___________________________________________________________________________________^ help: try: `state & PARKED_BIT == 0 || state & UPGRADING_BIT == 0 && state & GUARD_COUNT_MASK != SHARED_GUARD || state & UPGRADING_BIT != 0 && state & GUARD_COUNT_MASK != UPGRADABLE_GUARD + SHARED_GUARD` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/rwlock.rs:160:43 [INFO] [stderr] | [INFO] [stderr] 160 | if rng.gen_bool(1.0 / N as f64) { [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(N)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `parking_lot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "422e92e05977b087d89c88ca214e12613d2993ef2950dcd16fe9f3d0541b4212"` [INFO] running `"docker" "rm" "-f" "422e92e05977b087d89c88ca214e12613d2993ef2950dcd16fe9f3d0541b4212"` [INFO] [stdout] 422e92e05977b087d89c88ca214e12613d2993ef2950dcd16fe9f3d0541b4212