[INFO] crate park 0.0.1 is already in cache [INFO] extracting crate park 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/park/0.0.1 [INFO] extracting crate park 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/park/0.0.1 [INFO] validating manifest of park-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of park-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing park-0.0.1 [INFO] finished frobbing park-0.0.1 [INFO] frobbed toml for park-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/park/0.0.1/Cargo.toml [INFO] started frobbing park-0.0.1 [INFO] finished frobbing park-0.0.1 [INFO] frobbed toml for park-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/park/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting park-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/park/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc643fdce1836dc3c9a468e82190a172e282cacf8df706e8509e5a5b180b44ca [INFO] running `"docker" "start" "-a" "cc643fdce1836dc3c9a468e82190a172e282cacf8df706e8509e5a5b180b44ca"` [INFO] [stderr] Checking park v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if let Err(_) = env_file.write(envs.as_bytes()) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 58 | | eprintln!("Write content to {} failed!", &conf.env_file); [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____- help: try this: `if env_file.write(envs.as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:93:28 [INFO] [stderr] | [INFO] [stderr] 93 | line = String::from(format!( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 94 | | "{}{}{}={}\n", [INFO] [stderr] 95 | | prefix, [INFO] [stderr] 96 | | mid, [INFO] [stderr] 97 | | key, [INFO] [stderr] 98 | | v.as_str().unwrap().trim_matches('"') [INFO] [stderr] 99 | | )); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 93 | line = format!( [INFO] [stderr] 94 | "{}{}{}={}\n", [INFO] [stderr] 95 | prefix, [INFO] [stderr] 96 | mid, [INFO] [stderr] 97 | key, [INFO] [stderr] 98 | v.as_str().unwrap().trim_matches('"') [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:101:28 [INFO] [stderr] | [INFO] [stderr] 101 | line = String::from(format!("{}{}{}={}\n", prefix, mid, key, v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}{}{}={}\n", prefix, mid, key, v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if let Err(_) = env_file.write(envs.as_bytes()) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 58 | | eprintln!("Write content to {} failed!", &conf.env_file); [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____- help: try this: `if env_file.write(envs.as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:93:28 [INFO] [stderr] | [INFO] [stderr] 93 | line = String::from(format!( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 94 | | "{}{}{}={}\n", [INFO] [stderr] 95 | | prefix, [INFO] [stderr] 96 | | mid, [INFO] [stderr] 97 | | key, [INFO] [stderr] 98 | | v.as_str().unwrap().trim_matches('"') [INFO] [stderr] 99 | | )); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 93 | line = format!( [INFO] [stderr] 94 | "{}{}{}={}\n", [INFO] [stderr] 95 | prefix, [INFO] [stderr] 96 | mid, [INFO] [stderr] 97 | key, [INFO] [stderr] 98 | v.as_str().unwrap().trim_matches('"') [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:101:28 [INFO] [stderr] | [INFO] [stderr] 101 | line = String::from(format!("{}{}{}={}\n", prefix, mid, key, v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}{}{}={}\n", prefix, mid, key, v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.18s [INFO] running `"docker" "inspect" "cc643fdce1836dc3c9a468e82190a172e282cacf8df706e8509e5a5b180b44ca"` [INFO] running `"docker" "rm" "-f" "cc643fdce1836dc3c9a468e82190a172e282cacf8df706e8509e5a5b180b44ca"` [INFO] [stdout] cc643fdce1836dc3c9a468e82190a172e282cacf8df706e8509e5a5b180b44ca