[INFO] crate parity-wasm-cp 0.1.6 is already in cache [INFO] extracting crate parity-wasm-cp 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/parity-wasm-cp/0.1.6 [INFO] extracting crate parity-wasm-cp 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parity-wasm-cp/0.1.6 [INFO] validating manifest of parity-wasm-cp-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of parity-wasm-cp-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing parity-wasm-cp-0.1.6 [INFO] finished frobbing parity-wasm-cp-0.1.6 [INFO] frobbed toml for parity-wasm-cp-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/parity-wasm-cp/0.1.6/Cargo.toml [INFO] started frobbing parity-wasm-cp-0.1.6 [INFO] finished frobbing parity-wasm-cp-0.1.6 [INFO] frobbed toml for parity-wasm-cp-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parity-wasm-cp/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting parity-wasm-cp-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/parity-wasm-cp/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 958b014092567dcf403893fadffed579f41278b48eb1e5c06f6b5a0eec3f529f [INFO] running `"docker" "start" "-a" "958b014092567dcf403893fadffed579f41278b48eb1e5c06f6b5a0eec3f529f"` [INFO] [stderr] Checking parity-wasm-cp v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/primitives.rs:580:4 [INFO] [stderr] | [INFO] [stderr] 580 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | sections: sections, ..Default::default() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:442:4 [INFO] [stderr] | [INFO] [stderr] 442 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:443:4 [INFO] [stderr] | [INFO] [stderr] 443 | sections: sections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/section.rs:251:4 [INFO] [stderr] | [INFO] [stderr] 251 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/section.rs:323:22 [INFO] [stderr] | [INFO] [stderr] 323 | Ok(CustomSection { name: name, payload: payload }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/section.rs:323:34 [INFO] [stderr] | [INFO] [stderr] 323 | Ok(CustomSection { name: name, payload: payload }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:153:4 [INFO] [stderr] | [INFO] [stderr] 153 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:154:4 [INFO] [stderr] | [INFO] [stderr] 154 | return_type: return_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:193:4 [INFO] [stderr] | [INFO] [stderr] 193 | form: form, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `form` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:194:4 [INFO] [stderr] | [INFO] [stderr] 194 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:195:4 [INFO] [stderr] | [INFO] [stderr] 195 | return_type: return_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:19:4 [INFO] [stderr] | [INFO] [stderr] 19 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | is_mutable: is_mutable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_mutable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:38:4 [INFO] [stderr] | [INFO] [stderr] 38 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | elem_type: elem_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | limits: limits, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `limits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:134:4 [INFO] [stderr] | [INFO] [stderr] 134 | maximum: maximum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `maximum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:253:4 [INFO] [stderr] | [INFO] [stderr] 253 | module_str: module_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:254:4 [INFO] [stderr] | [INFO] [stderr] 254 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:255:4 [INFO] [stderr] | [INFO] [stderr] 255 | external: external, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `external` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:291:4 [INFO] [stderr] | [INFO] [stderr] 291 | module_str: module_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:292:4 [INFO] [stderr] | [INFO] [stderr] 292 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:293:4 [INFO] [stderr] | [INFO] [stderr] 293 | external: external, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `external` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:63:4 [INFO] [stderr] | [INFO] [stderr] 63 | internal: internal [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `internal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:88:4 [INFO] [stderr] | [INFO] [stderr] 88 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:89:4 [INFO] [stderr] | [INFO] [stderr] 89 | internal: internal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `internal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | global_type: global_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:16:4 [INFO] [stderr] | [INFO] [stderr] 16 | init_expr: init_expr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | global_type: global_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:38:4 [INFO] [stderr] | [INFO] [stderr] 38 | init_expr: init_expr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:54:11 [INFO] [stderr] | [INFO] [stderr] 54 | Local { count: count, value_type: value_type } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | Local { count: count, value_type: value_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:70:35 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(Local { count: count.into(), value_type: value_type }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | FuncBody { locals: locals, instructions: instructions } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | FuncBody { locals: locals, instructions: instructions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | Ok(FuncBody { locals: locals, instructions: instructions }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:125:33 [INFO] [stderr] | [INFO] [stderr] 125 | Ok(FuncBody { locals: locals, instructions: instructions }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:16:50 [INFO] [stderr] | [INFO] [stderr] 16 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `members` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:83:4 [INFO] [stderr] | [INFO] [stderr] 83 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:116:4 [INFO] [stderr] | [INFO] [stderr] 116 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/primitives.rs:580:4 [INFO] [stderr] | [INFO] [stderr] 580 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | sections: sections, ..Default::default() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/module.rs:79:4 [INFO] [stderr] | [INFO] [stderr] 79 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/module.rs:151:4 [INFO] [stderr] | [INFO] [stderr] 151 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:29:4 [INFO] [stderr] | [INFO] [stderr] 29 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:118:4 [INFO] [stderr] | [INFO] [stderr] 118 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:150:4 [INFO] [stderr] | [INFO] [stderr] 150 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:226:4 [INFO] [stderr] | [INFO] [stderr] 226 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:294:4 [INFO] [stderr] | [INFO] [stderr] 294 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | ValueTypeBuilder { callback: callback } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | OptionalValueTypeBuilder { callback: callback } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/import.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/import.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/memory.rs:42:4 [INFO] [stderr] | [INFO] [stderr] 42 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/memory.rs:66:4 [INFO] [stderr] | [INFO] [stderr] 66 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/table.rs:42:4 [INFO] [stderr] | [INFO] [stderr] 42 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/table.rs:66:4 [INFO] [stderr] | [INFO] [stderr] 66 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/export.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/export.rs:73:4 [INFO] [stderr] | [INFO] [stderr] 73 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/global.rs:24:4 [INFO] [stderr] | [INFO] [stderr] 24 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/data.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:442:4 [INFO] [stderr] | [INFO] [stderr] 442 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:443:4 [INFO] [stderr] | [INFO] [stderr] 443 | sections: sections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/section.rs:251:4 [INFO] [stderr] | [INFO] [stderr] 251 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/section.rs:323:22 [INFO] [stderr] | [INFO] [stderr] 323 | Ok(CustomSection { name: name, payload: payload }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/section.rs:323:34 [INFO] [stderr] | [INFO] [stderr] 323 | Ok(CustomSection { name: name, payload: payload }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:153:4 [INFO] [stderr] | [INFO] [stderr] 153 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:154:4 [INFO] [stderr] | [INFO] [stderr] 154 | return_type: return_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:193:4 [INFO] [stderr] | [INFO] [stderr] 193 | form: form, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `form` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:194:4 [INFO] [stderr] | [INFO] [stderr] 194 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:195:4 [INFO] [stderr] | [INFO] [stderr] 195 | return_type: return_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:19:4 [INFO] [stderr] | [INFO] [stderr] 19 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | is_mutable: is_mutable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_mutable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:38:4 [INFO] [stderr] | [INFO] [stderr] 38 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | elem_type: elem_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | limits: limits, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `limits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:134:4 [INFO] [stderr] | [INFO] [stderr] 134 | maximum: maximum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `maximum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:253:4 [INFO] [stderr] | [INFO] [stderr] 253 | module_str: module_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:254:4 [INFO] [stderr] | [INFO] [stderr] 254 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:255:4 [INFO] [stderr] | [INFO] [stderr] 255 | external: external, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `external` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:291:4 [INFO] [stderr] | [INFO] [stderr] 291 | module_str: module_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:292:4 [INFO] [stderr] | [INFO] [stderr] 292 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:293:4 [INFO] [stderr] | [INFO] [stderr] 293 | external: external, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `external` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:63:4 [INFO] [stderr] | [INFO] [stderr] 63 | internal: internal [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `internal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:88:4 [INFO] [stderr] | [INFO] [stderr] 88 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:89:4 [INFO] [stderr] | [INFO] [stderr] 89 | internal: internal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `internal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | global_type: global_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:16:4 [INFO] [stderr] | [INFO] [stderr] 16 | init_expr: init_expr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | global_type: global_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:38:4 [INFO] [stderr] | [INFO] [stderr] 38 | init_expr: init_expr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:54:11 [INFO] [stderr] | [INFO] [stderr] 54 | Local { count: count, value_type: value_type } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | Local { count: count, value_type: value_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:70:35 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(Local { count: count.into(), value_type: value_type }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | FuncBody { locals: locals, instructions: instructions } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | FuncBody { locals: locals, instructions: instructions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | Ok(FuncBody { locals: locals, instructions: instructions }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:125:33 [INFO] [stderr] | [INFO] [stderr] 125 | Ok(FuncBody { locals: locals, instructions: instructions }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:16:50 [INFO] [stderr] | [INFO] [stderr] 16 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `members` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:83:4 [INFO] [stderr] | [INFO] [stderr] 83 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:116:4 [INFO] [stderr] | [INFO] [stderr] 116 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/module.rs:79:4 [INFO] [stderr] | [INFO] [stderr] 79 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/module.rs:151:4 [INFO] [stderr] | [INFO] [stderr] 151 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:29:4 [INFO] [stderr] | [INFO] [stderr] 29 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:118:4 [INFO] [stderr] | [INFO] [stderr] 118 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:150:4 [INFO] [stderr] | [INFO] [stderr] 150 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:226:4 [INFO] [stderr] | [INFO] [stderr] 226 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:294:4 [INFO] [stderr] | [INFO] [stderr] 294 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | ValueTypeBuilder { callback: callback } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | OptionalValueTypeBuilder { callback: callback } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/import.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/import.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/memory.rs:42:4 [INFO] [stderr] | [INFO] [stderr] 42 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/memory.rs:66:4 [INFO] [stderr] | [INFO] [stderr] 66 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/table.rs:42:4 [INFO] [stderr] | [INFO] [stderr] 42 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/table.rs:66:4 [INFO] [stderr] | [INFO] [stderr] 66 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/export.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/export.rs:73:4 [INFO] [stderr] | [INFO] [stderr] 73 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/global.rs:24:4 [INFO] [stderr] | [INFO] [stderr] 24 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/data.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/elements/primitives.rs:302:12 [INFO] [stderr] | [INFO] [stderr] 302 | } else if shift >= 32 && b & 0b0100_0000 == 0 { [INFO] [stderr] | ________________________^ [INFO] [stderr] 303 | | if b.leading_zeros() < 5 { [INFO] [stderr] 304 | | return Err(Error::InvalidVarInt32); [INFO] [stderr] 305 | | } [INFO] [stderr] 306 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 302 | } else if shift >= 32 && b & 0b0100_0000 == 0 && b.leading_zeros() < 5 { [INFO] [stderr] 303 | return Err(Error::InvalidVarInt32); [INFO] [stderr] 304 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Instructions`, `serialize` [INFO] [stderr] --> src/elements/module.rs:6:85 [INFO] [stderr] | [INFO] [stderr] 6 | use super::{Deserialize, Serialize, Error, Uint32, External, InitExpr, DataSegment, serialize, Instruction, Instructions}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `InitExpr` [INFO] [stderr] --> src/elements/section.rs:26:2 [INFO] [stderr] | [INFO] [stderr] 26 | InitExpr, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/elements/index_map.rs:107:3 [INFO] [stderr] | [INFO] [stderr] 107 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/elements/index_map.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | let result = match self.entries.get_mut(idx as usize) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 99 | | Some(value @ &mut Some(_)) => { [INFO] [stderr] 100 | | self.len -= 1; [INFO] [stderr] 101 | | value.take() [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | Some(&mut None) | None => None, [INFO] [stderr] 104 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/elements/primitives.rs:302:12 [INFO] [stderr] | [INFO] [stderr] 302 | } else if shift >= 32 && b & 0b0100_0000 == 0 { [INFO] [stderr] | ________________________^ [INFO] [stderr] 303 | | if b.leading_zeros() < 5 { [INFO] [stderr] 304 | | return Err(Error::InvalidVarInt32); [INFO] [stderr] 305 | | } [INFO] [stderr] 306 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 302 | } else if shift >= 32 && b & 0b0100_0000 == 0 && b.leading_zeros() < 5 { [INFO] [stderr] 303 | return Err(Error::InvalidVarInt32); [INFO] [stderr] 304 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/primitives.rs:764:5 [INFO] [stderr] | [INFO] [stderr] 764 | -9223372036854775808, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/primitives.rs:790:4 [INFO] [stderr] | [INFO] [stderr] 790 | 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/primitives.rs:852:5 [INFO] [stderr] | [INFO] [stderr] 852 | -2147483648, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/primitives.rs:883:4 [INFO] [stderr] | [INFO] [stderr] 883 | 2147483647, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Instructions`, `serialize` [INFO] [stderr] --> src/elements/module.rs:6:85 [INFO] [stderr] | [INFO] [stderr] 6 | use super::{Deserialize, Serialize, Error, Uint32, External, InitExpr, DataSegment, serialize, Instruction, Instructions}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:617:23 [INFO] [stderr] | [INFO] [stderr] 617 | assert_eq!(I64Const(9223372036854775807), func.code().elements()[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:618:24 [INFO] [stderr] | [INFO] [stderr] 618 | assert_eq!(I64Const(-9223372036854775808), func.code().elements()[1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:619:24 [INFO] [stderr] | [INFO] [stderr] 619 | assert_eq!(I64Const(-1152894205662152753), func.code().elements()[2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_152_894_205_662_152_753` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:633:24 [INFO] [stderr] | [INFO] [stderr] 633 | assert_eq!(I32Const(-2147483648), func.code().elements()[16]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:634:23 [INFO] [stderr] | [INFO] [stderr] 634 | assert_eq!(I32Const(2147483647), func.code().elements()[17]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `InitExpr` [INFO] [stderr] --> src/elements/section.rs:26:2 [INFO] [stderr] | [INFO] [stderr] 26 | InitExpr, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/elements/section.rs:1092:4 [INFO] [stderr] | [INFO] [stderr] 1092 | 08u8, // 8 bytes overall [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1092 | 8u8, // 8 bytes overall [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1092 | 0o8u8, // 8 bytes overall [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/elements/section.rs:1137:47 [INFO] [stderr] | [INFO] [stderr] 1137 | let section: Section = deserialize_buffer(&[08u8, 01u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1137 | let section: Section = deserialize_buffer(&[8u8, 01u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1137 | let section: Section = deserialize_buffer(&[0o8u8, 01u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/elements/section.rs:1137:53 [INFO] [stderr] | [INFO] [stderr] 1137 | let section: Section = deserialize_buffer(&[08u8, 01u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1137 | let section: Section = deserialize_buffer(&[08u8, 1u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1137 | let section: Section = deserialize_buffer(&[08u8, 0o1u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/elements/section.rs:1145:31 [INFO] [stderr] | [INFO] [stderr] 1145 | assert_eq!(serialized, vec![08u8, 01u8, 00u8]); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1145 | assert_eq!(serialized, vec![8u8, 01u8, 00u8]); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1145 | assert_eq!(serialized, vec![0o8u8, 01u8, 00u8]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/elements/section.rs:1145:37 [INFO] [stderr] | [INFO] [stderr] 1145 | assert_eq!(serialized, vec![08u8, 01u8, 00u8]); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1145 | assert_eq!(serialized, vec![08u8, 1u8, 00u8]); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1145 | assert_eq!(serialized, vec![08u8, 0o1u8, 00u8]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/elements/index_map.rs:107:3 [INFO] [stderr] | [INFO] [stderr] 107 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/elements/index_map.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | let result = match self.entries.get_mut(idx as usize) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 99 | | Some(value @ &mut Some(_)) => { [INFO] [stderr] 100 | | self.len -= 1; [INFO] [stderr] 101 | | value.take() [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | Some(&mut None) | None => None, [INFO] [stderr] 104 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | let b = u8buf[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(u8buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:104:12 [INFO] [stderr] | [INFO] [stderr] 104 | let b = u8buf[0] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u8buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:292:11 [INFO] [stderr] | [INFO] [stderr] 292 | res |= ((b & 0x7f) as i32).checked_shl(shift).ok_or(Error::InvalidVarInt32)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(b & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:366:11 [INFO] [stderr] | [INFO] [stderr] 366 | res |= ((b & 0x7f) as i64).checked_shl(shift).ok_or(Error::InvalidVarInt64)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(b & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `v @ _` pattern can be written as just `v` [INFO] [stderr] --> src/elements/primitives.rs:507:4 [INFO] [stderr] | [INFO] [stderr] 507 | v @ _ => Err(Error::InvalidVarUint1(v)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:78:4 [INFO] [stderr] | [INFO] [stderr] 78 | if let &Section::Code(ref code_section) = section { return Some(code_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 78 | if let Section::Code(ref code_section) = *section { return Some(code_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:94:4 [INFO] [stderr] | [INFO] [stderr] 94 | if let &Section::Type(ref type_section) = section { return Some(type_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | if let Section::Type(ref type_section) = *section { return Some(type_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:111:4 [INFO] [stderr] | [INFO] [stderr] 111 | if let &Section::Import(ref import_section) = section { return Some(import_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 111 | if let Section::Import(ref import_section) = *section { return Some(import_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:127:4 [INFO] [stderr] | [INFO] [stderr] 127 | if let &Section::Global(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | if let Section::Global(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:144:4 [INFO] [stderr] | [INFO] [stderr] 144 | if let &Section::Export(ref export_section) = section { return Some(export_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | if let Section::Export(ref export_section) = *section { return Some(export_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:160:4 [INFO] [stderr] | [INFO] [stderr] 160 | if let &Section::Table(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | if let Section::Table(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:176:4 [INFO] [stderr] | [INFO] [stderr] 176 | if let &Section::Data(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 176 | if let Section::Data(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:215:4 [INFO] [stderr] | [INFO] [stderr] 215 | if let &Section::Element(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 215 | if let Section::Element(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:231:4 [INFO] [stderr] | [INFO] [stderr] 231 | if let &Section::Memory(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 231 | if let Section::Memory(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:247:4 [INFO] [stderr] | [INFO] [stderr] 247 | if let &Section::Function(ref sect) = section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 247 | if let Section::Function(ref sect) = *section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:263:4 [INFO] [stderr] | [INFO] [stderr] 263 | if let &Section::Start(sect) = section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 263 | if let Section::Start(sect) = *section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elements/module.rs:315:6 [INFO] [stderr] | [INFO] [stderr] 315 | if parse_errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parse_errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elements/module.rs:356:6 [INFO] [stderr] | [INFO] [stderr] 356 | if parse_errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parse_errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elements/section.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | Section::Custom(CustomSection::deserialize(reader)?.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `CustomSection::deserialize(reader)?` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/section.rs:409:20 [INFO] [stderr] | [INFO] [stderr] 409 | .filter(|entry| match entry.external() { &External::Function(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 409 | .filter(|entry| match *entry.external() { External::Function(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/section.rs:416:20 [INFO] [stderr] | [INFO] [stderr] 416 | .filter(|entry| match entry.external() { &External::Global(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 416 | .filter(|entry| match *entry.external() { External::Global(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elements/import_entry.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn content_type(&self) -> ValueType { self.content_type } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elements/import_entry.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn is_mutable(&self) -> bool { self.is_mutable } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/ops.rs:311:3 [INFO] [stderr] | [INFO] [stderr] 311 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 312 | | &Instruction::Block(_) | &Instruction::Loop(_) | &Instruction::If(_) => true, [INFO] [stderr] 313 | | _ => false, [INFO] [stderr] 314 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 311 | match *self { [INFO] [stderr] 312 | Instruction::Block(_) | Instruction::Loop(_) | Instruction::If(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/ops.rs:320:3 [INFO] [stderr] | [INFO] [stderr] 320 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 321 | | &Instruction::End => true, [INFO] [stderr] 322 | | _ => false, [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 320 | match *self { [INFO] [stderr] 321 | Instruction::End => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/elements/ops.rs:857:12 [INFO] [stderr] | [INFO] [stderr] 857 | table.into_iter().map(|x| VarUint32::from(*x)), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | let b = u8buf[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(u8buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:104:12 [INFO] [stderr] | [INFO] [stderr] 104 | let b = u8buf[0] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u8buf[0])` [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elements/func.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn type_ref(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elements/func.rs:58:15 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn count(&self) -> u32 { self.count } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elements/func.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn value_type(&self) -> ValueType { self.value_type } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:292:11 [INFO] [stderr] | [INFO] [stderr] 292 | res |= ((b & 0x7f) as i32).checked_shl(shift).ok_or(Error::InvalidVarInt32)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(b & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:366:11 [INFO] [stderr] | [INFO] [stderr] 366 | res |= ((b & 0x7f) as i64).checked_shl(shift).ok_or(Error::InvalidVarInt64)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(b & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/index_map.rs:299:4 [INFO] [stderr] | [INFO] [stderr] 299 | if let &Some(ref value) = value_opt { [INFO] [stderr] | _____________^ [INFO] [stderr] 300 | | self.remaining_len -= 1; [INFO] [stderr] 301 | | return Some((idx, value)); [INFO] [stderr] 302 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] warning: the `v @ _` pattern can be written as just `v` [INFO] [stderr] --> src/elements/primitives.rs:507:4 [INFO] [stderr] | [INFO] [stderr] 507 | v @ _ => Err(Error::InvalidVarUint1(v)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 299 | if let Some(ref value) = *value_opt { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/elements/primitives.rs:905:18 [INFO] [stderr] | [INFO] [stderr] 905 | let v3: i8 = (*vars.get(1).unwrap()).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&vars[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:78:4 [INFO] [stderr] | [INFO] [stderr] 78 | if let &Section::Code(ref code_section) = section { return Some(code_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 78 | if let Section::Code(ref code_section) = *section { return Some(code_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:94:4 [INFO] [stderr] | [INFO] [stderr] 94 | if let &Section::Type(ref type_section) = section { return Some(type_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | if let Section::Type(ref type_section) = *section { return Some(type_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:111:4 [INFO] [stderr] | [INFO] [stderr] 111 | if let &Section::Import(ref import_section) = section { return Some(import_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 111 | if let Section::Import(ref import_section) = *section { return Some(import_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:127:4 [INFO] [stderr] | [INFO] [stderr] 127 | if let &Section::Global(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | if let Section::Global(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:144:4 [INFO] [stderr] | [INFO] [stderr] 144 | if let &Section::Export(ref export_section) = section { return Some(export_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | if let Section::Export(ref export_section) = *section { return Some(export_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:160:4 [INFO] [stderr] | [INFO] [stderr] 160 | if let &Section::Table(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | if let Section::Table(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:176:4 [INFO] [stderr] | [INFO] [stderr] 176 | if let &Section::Data(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 176 | if let Section::Data(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:93:6 [INFO] [stderr] | [INFO] [stderr] 93 | if types.types().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!types.types().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:97:6 [INFO] [stderr] | [INFO] [stderr] 97 | if import.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!import.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:101:6 [INFO] [stderr] | [INFO] [stderr] 101 | if functions.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!functions.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:105:6 [INFO] [stderr] | [INFO] [stderr] 105 | if table.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!table.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:109:6 [INFO] [stderr] | [INFO] [stderr] 109 | if memory.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!memory.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:215:4 [INFO] [stderr] | [INFO] [stderr] 215 | if let &Section::Element(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:113:6 [INFO] [stderr] | [INFO] [stderr] 113 | if global.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!global.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:117:6 [INFO] [stderr] 215 | if let Section::Element(ref section) = *section { return Some(section); } [INFO] [stderr] | [INFO] [stderr] 117 | if export.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!export.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:231:4 [INFO] [stderr] | [INFO] [stderr] 231 | if let &Section::Memory(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 231 | if let Section::Memory(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:124:6 [INFO] [stderr] | [INFO] [stderr] 124 | if element.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!element.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:128:6 [INFO] [stderr] | [INFO] [stderr] 128 | if code.bodies().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!code.bodies().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:132:6 [INFO] [stderr] | [INFO] [stderr] 132 | if data.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::module::ModuleBuilder` [INFO] [stderr] --> src/builder/module.rs:142:2 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 143 | | ModuleBuilder::with_callback(Identity) [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | impl Default for builder::module::ModuleBuilder { [INFO] [stderr] 141 | fn default() -> Self { [INFO] [stderr] 142 | Self::new() [INFO] [stderr] 143 | } [INFO] [stderr] 144 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:247:4 [INFO] [stderr] | [INFO] [stderr] 247 | if let &Section::Function(ref sect) = section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 247 | if let Section::Function(ref sect) = *section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:263:4 [INFO] [stderr] | [INFO] [stderr] 263 | if let &Section::Start(sect) = section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 263 | if let Section::Start(sect) = *section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::SignatureBuilder` [INFO] [stderr] --> src/builder/code.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 21 | | SignatureBuilder::with_callback(Identity) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for builder::code::SignatureBuilder { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::SignaturesBuilder` [INFO] [stderr] --> src/builder/code.rs:141:2 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 142 | | SignaturesBuilder::with_callback(Identity) [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 139 | impl Default for builder::code::SignaturesBuilder { [INFO] [stderr] 140 | fn default() -> Self { [INFO] [stderr] 141 | Self::new() [INFO] [stderr] 142 | } [INFO] [stderr] 143 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::FunctionBuilder` [INFO] [stderr] --> src/builder/code.rs:285:2 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 286 | | FunctionBuilder::with_callback(Identity) [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 283 | impl Default for builder::code::FunctionBuilder { [INFO] [stderr] 284 | fn default() -> Self { [INFO] [stderr] 285 | Self::new() [INFO] [stderr] 286 | } [INFO] [stderr] 287 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::import::ImportBuilder` [INFO] [stderr] --> src/builder/import.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | ImportBuilder::with_callback(Identity) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for builder::import::ImportBuilder { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elements/module.rs:315:6 [INFO] [stderr] | [INFO] [stderr] 315 | if parse_errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parse_errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elements/module.rs:356:6 [INFO] [stderr] | [INFO] [stderr] 356 | if parse_errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parse_errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::memory::MemoryBuilder` [INFO] [stderr] --> src/builder/memory.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 34 | | MemoryBuilder::with_callback(Identity) [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | impl Default for builder::memory::MemoryBuilder { [INFO] [stderr] 32 | fn default() -> Self { [INFO] [stderr] 33 | Self::new() [INFO] [stderr] 34 | } [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::table::TableBuilder` [INFO] [stderr] --> src/builder/table.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 34 | | TableBuilder::with_callback(Identity) [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | impl Default for builder::table::TableBuilder { [INFO] [stderr] 32 | fn default() -> Self { [INFO] [stderr] 33 | Self::new() [INFO] [stderr] 34 | } [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::export::ExportBuilder` [INFO] [stderr] --> src/builder/export.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 16 | | ExportBuilder::with_callback(Identity) [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for builder::export::ExportBuilder { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::global::GlobalBuilder` [INFO] [stderr] --> src/builder/global.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 16 | | GlobalBuilder::with_callback(Identity) [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for builder::global::GlobalBuilder { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::data::DataSegmentBuilder` [INFO] [stderr] --> src/builder/data.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | DataSegmentBuilder::with_callback(Identity) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for builder::data::DataSegmentBuilder { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:558:4 [INFO] [stderr] | [INFO] [stderr] 558 | if let &Section::Type(_) = x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 558 | if let Section::Type(_) = *x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:576:4 [INFO] [stderr] | [INFO] [stderr] 576 | if let &Section::Import(_) = x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 576 | if let Section::Import(_) = *x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:594:4 [INFO] [stderr] | [INFO] [stderr] 594 | if let &Section::Code(_) = x { return true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 594 | if let Section::Code(_) = *x { return true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:595:4 [INFO] [stderr] | [INFO] [stderr] 595 | if let &Section::Function(_) = x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 595 | if let Section::Function(_) = *x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elements/module.rs:703:4 [INFO] [stderr] | [INFO] [stderr] 703 | match *section { [INFO] [stderr] | _____________^ [INFO] [stderr] 704 | | Section::Name(ref name_section) => { [INFO] [stderr] 705 | | match *name_section { [INFO] [stderr] 706 | | NameSection::Function(ref function_name_section) => { [INFO] [stderr] ... | [INFO] [stderr] 721 | | _ => {}, [INFO] [stderr] 722 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 703 | if let Section::Name(ref name_section) = *section { [INFO] [stderr] 704 | match *name_section { [INFO] [stderr] 705 | NameSection::Function(ref function_name_section) => { [INFO] [stderr] 706 | assert_eq!( [INFO] [stderr] 707 | function_name_section.names().get(0).expect("Should be entry #0"), [INFO] [stderr] 708 | "elog" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elements/module.rs:705:6 [INFO] [stderr] | [INFO] [stderr] 705 | match *name_section { [INFO] [stderr] | _____________________^ [INFO] [stderr] 706 | | NameSection::Function(ref function_name_section) => { [INFO] [stderr] 707 | | assert_eq!( [INFO] [stderr] 708 | | function_name_section.names().get(0).expect("Should be entry #0"), [INFO] [stderr] ... | [INFO] [stderr] 718 | | _ => {}, [INFO] [stderr] 719 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 705 | if let NameSection::Function(ref function_name_section) = *name_section { [INFO] [stderr] 706 | assert_eq!( [INFO] [stderr] 707 | function_name_section.names().get(0).expect("Should be entry #0"), [INFO] [stderr] 708 | "elog" [INFO] [stderr] 709 | ); [INFO] [stderr] 710 | assert_eq!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elements/section.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | Section::Custom(CustomSection::deserialize(reader)?.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `CustomSection::deserialize(reader)?` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/section.rs:409:20 [INFO] [stderr] | [INFO] [stderr] 409 | .filter(|entry| match entry.external() { &External::Function(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 409 | .filter(|entry| match *entry.external() { External::Function(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/section.rs:416:20 [INFO] [stderr] | [INFO] [stderr] 416 | .filter(|entry| match entry.external() { &External::Global(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 416 | .filter(|entry| match *entry.external() { External::Global(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elements/section.rs:828:4 [INFO] [stderr] | [INFO] [stderr] 828 | match section { [INFO] [stderr] | _____________^ [INFO] [stderr] 829 | | &Section::Import(ref import_section) => { [INFO] [stderr] 830 | | assert_eq!(25, import_section.entries().len()); [INFO] [stderr] 831 | | found = true [INFO] [stderr] 832 | | }, [INFO] [stderr] 833 | | _ => { } [INFO] [stderr] 834 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 828 | if let &Section::Import(ref import_section) = section { [INFO] [stderr] 829 | assert_eq!(25, import_section.entries().len()); [INFO] [stderr] 830 | found = true [INFO] [stderr] 831 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/section.rs:828:4 [INFO] [stderr] | [INFO] [stderr] 828 | match section { [INFO] [stderr] | _____________^ [INFO] [stderr] 829 | | &Section::Import(ref import_section) => { [INFO] [stderr] 830 | | assert_eq!(25, import_section.entries().len()); [INFO] [stderr] 831 | | found = true [INFO] [stderr] 832 | | }, [INFO] [stderr] 833 | | _ => { } [INFO] [stderr] 834 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 828 | match *section { [INFO] [stderr] 829 | Section::Import(ref import_section) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elements/section.rs:876:3 [INFO] [stderr] | [INFO] [stderr] 876 | match section { [INFO] [stderr] | _________^ [INFO] [stderr] 877 | | Section::Function(fn_section) => { [INFO] [stderr] 878 | | assert_eq!(4, fn_section.entries().len(), "There should be 4 functions total"); [INFO] [stderr] 879 | | }, [INFO] [stderr] ... | [INFO] [stderr] 882 | | } [INFO] [stderr] 883 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 876 | if let Section::Function(fn_section) = section { [INFO] [stderr] 877 | assert_eq!(4, fn_section.entries().len(), "There should be 4 functions total"); [INFO] [stderr] 878 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elements/section.rs:891:3 [INFO] [stderr] | [INFO] [stderr] 891 | match section { [INFO] [stderr] | _________^ [INFO] [stderr] 892 | | Section::Function(fn_section) => { [INFO] [stderr] 893 | | assert_eq!(6, fn_section.entries()[1].type_ref()); [INFO] [stderr] 894 | | }, [INFO] [stderr] ... | [INFO] [stderr] 897 | | } [INFO] [stderr] 898 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 891 | if let Section::Function(fn_section) = section { [INFO] [stderr] 892 | assert_eq!(6, fn_section.entries()[1].type_ref()); [INFO] [stderr] 893 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elements/section.rs:943:12 [INFO] [stderr] | [INFO] [stderr] 943 | let t1 = match &type_section.types()[1] { [INFO] [stderr] | __________________^ [INFO] [stderr] 944 | | &Type::Function(ref func_type) => func_type [INFO] [stderr] 945 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 943 | let t1 = match type_section.types()[1] { [INFO] [stderr] 944 | Type::Function(ref func_type) => func_type [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elements/import_entry.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn content_type(&self) -> ValueType { self.content_type } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elements/import_entry.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn is_mutable(&self) -> bool { self.is_mutable } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/ops.rs:311:3 [INFO] [stderr] | [INFO] [stderr] 311 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 312 | | &Instruction::Block(_) | &Instruction::Loop(_) | &Instruction::If(_) => true, [INFO] [stderr] 313 | | _ => false, [INFO] [stderr] 314 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 311 | match *self { [INFO] [stderr] 312 | Instruction::Block(_) | Instruction::Loop(_) | Instruction::If(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/ops.rs:320:3 [INFO] [stderr] | [INFO] [stderr] 320 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 321 | | &Instruction::End => true, [INFO] [stderr] 322 | | _ => false, [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 320 | match *self { [INFO] [stderr] 321 | Instruction::End => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/elements/ops.rs:857:12 [INFO] [stderr] | [INFO] [stderr] 857 | table.into_iter().map(|x| VarUint32::from(*x)), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/info.rs:42:39 [INFO] [stderr] | [INFO] [stderr] 42 | Section::Data(ref data_section) if data_section.entries().len() > 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data_section.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elements/ops.rs:1438:2 [INFO] [stderr] | [INFO] [stderr] 1438 | match &instructions[0] { [INFO] [stderr] | _____^ [INFO] [stderr] 1439 | | &Instruction::If(_) => (), [INFO] [stderr] 1440 | | _ => panic!("Should be deserialized as if instruction"), [INFO] [stderr] 1441 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1438 | match instructions[0] { [INFO] [stderr] 1439 | Instruction::If(_) => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elements/func.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn type_ref(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elements/func.rs:58:15 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn count(&self) -> u32 { self.count } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elements/func.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn value_type(&self) -> ValueType { self.value_type } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/index_map.rs:299:4 [INFO] [stderr] | [INFO] [stderr] 299 | if let &Some(ref value) = value_opt { [INFO] [stderr] | _____________^ [INFO] [stderr] 300 | | self.remaining_len -= 1; [INFO] [stderr] 301 | | return Some((idx, value)); [INFO] [stderr] 302 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 299 | if let Some(ref value) = *value_opt { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/elements/index_map.rs:368:24 [INFO] [stderr] | [INFO] [stderr] 368 | assert_eq!(map.iter().collect::>().len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/elements/index_map.rs:369:29 [INFO] [stderr] | [INFO] [stderr] 369 | assert_eq!(map.into_iter().collect::>().len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elements/reloc_section.rs:335:4 [INFO] [stderr] | [INFO] [stderr] 335 | match *section { [INFO] [stderr] | _____________^ [INFO] [stderr] 336 | | Section::Reloc(ref reloc_section) => { [INFO] [stderr] 337 | | assert_eq!(vec![ [INFO] [stderr] 338 | | RelocationEntry::MemoryAddressSleb { offset: 4, index: 0, addend: 0 }, [INFO] [stderr] ... | [INFO] [stderr] 343 | | _ => { } [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 335 | if let Section::Reloc(ref reloc_section) = *section { [INFO] [stderr] 336 | assert_eq!(vec![ [INFO] [stderr] 337 | RelocationEntry::MemoryAddressSleb { offset: 4, index: 0, addend: 0 }, [INFO] [stderr] 338 | RelocationEntry::FunctionIndexLeb { offset: 12, index: 0 }, [INFO] [stderr] 339 | ], reloc_section.entries()); [INFO] [stderr] 340 | found = true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:93:6 [INFO] [stderr] | [INFO] [stderr] 93 | if types.types().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!types.types().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:97:6 [INFO] [stderr] | [INFO] [stderr] 97 | if import.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!import.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:101:6 [INFO] [stderr] | [INFO] [stderr] 101 | if functions.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!functions.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:105:6 [INFO] [stderr] | [INFO] [stderr] 105 | if table.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!table.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:109:6 [INFO] [stderr] | [INFO] [stderr] 109 | if memory.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!memory.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:113:6 [INFO] [stderr] | [INFO] [stderr] 113 | if global.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!global.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:117:6 [INFO] [stderr] | [INFO] [stderr] 117 | if export.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!export.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:124:6 [INFO] [stderr] | [INFO] [stderr] 124 | if element.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!element.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:128:6 [INFO] [stderr] | [INFO] [stderr] 128 | if code.bodies().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!code.bodies().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:132:6 [INFO] [stderr] | [INFO] [stderr] 132 | if data.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::module::ModuleBuilder` [INFO] [stderr] --> src/builder/module.rs:142:2 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 143 | | ModuleBuilder::with_callback(Identity) [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | impl Default for builder::module::ModuleBuilder { [INFO] [stderr] 141 | fn default() -> Self { [INFO] [stderr] 142 | Self::new() [INFO] [stderr] 143 | } [INFO] [stderr] 144 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::SignatureBuilder` [INFO] [stderr] --> src/builder/code.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 21 | | SignatureBuilder::with_callback(Identity) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for builder::code::SignatureBuilder { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::SignaturesBuilder` [INFO] [stderr] --> src/builder/code.rs:141:2 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 142 | | SignaturesBuilder::with_callback(Identity) [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 139 | impl Default for builder::code::SignaturesBuilder { [INFO] [stderr] 140 | fn default() -> Self { [INFO] [stderr] 141 | Self::new() [INFO] [stderr] 142 | } [INFO] [stderr] 143 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::FunctionBuilder` [INFO] [stderr] --> src/builder/code.rs:285:2 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 286 | | FunctionBuilder::with_callback(Identity) [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 283 | impl Default for builder::code::FunctionBuilder { [INFO] [stderr] 284 | fn default() -> Self { [INFO] [stderr] 285 | Self::new() [INFO] [stderr] 286 | } [INFO] [stderr] 287 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/bench-decoder.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | let file_size = fs::metadata(file_name).expect(&format!("{} to exist", file_name)).len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} to exist", file_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> examples/inject.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | let need_inject = match &instructions[position] { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 14 | | &Block(_) | &If(_) => true, [INFO] [stderr] 15 | | _ => false, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 13 | let need_inject = match instructions[position] { [INFO] [stderr] 14 | Block(_) | If(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/bench-decoder.rs:19:43 [INFO] [stderr] | [INFO] [stderr] 19 | (file_size as f64 * iterations as f64 / (1024*1024) as f64) / // total work megabytes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1024*1024)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/inject.rs:38:3 [INFO] [stderr] | [INFO] [stderr] 38 | match section { [INFO] [stderr] | _________^ [INFO] [stderr] 39 | | &mut elements::Section::Code(ref mut code_section) => { [INFO] [stderr] 40 | | for ref mut func_body in code_section.bodies_mut() { [INFO] [stderr] 41 | | inject_nop(func_body.code_mut()); [INFO] [stderr] ... | [INFO] [stderr] 44 | | _ => { } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let &mut elements::Section::Code(ref mut code_section) = section { [INFO] [stderr] 39 | for ref mut func_body in code_section.bodies_mut() { [INFO] [stderr] 40 | inject_nop(func_body.code_mut()); [INFO] [stderr] 41 | } [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/inject.rs:38:3 [INFO] [stderr] | [INFO] [stderr] 38 | match section { [INFO] [stderr] | _________^ [INFO] [stderr] 39 | | &mut elements::Section::Code(ref mut code_section) => { [INFO] [stderr] 40 | | for ref mut func_body in code_section.bodies_mut() { [INFO] [stderr] 41 | | inject_nop(func_body.code_mut()); [INFO] [stderr] ... | [INFO] [stderr] 44 | | _ => { } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | match *section { [INFO] [stderr] 39 | elements::Section::Code(ref mut code_section) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/inject.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | for ref mut func_body in code_section.bodies_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ------------------------- help: try: `let func_body = &mut code_section.bodies_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::import::ImportBuilder` [INFO] [stderr] --> src/builder/import.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | ImportBuilder::with_callback(Identity) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for builder::import::ImportBuilder { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::memory::MemoryBuilder` [INFO] [stderr] --> src/builder/memory.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 34 | | MemoryBuilder::with_callback(Identity) [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | impl Default for builder::memory::MemoryBuilder { [INFO] [stderr] 32 | fn default() -> Self { [INFO] [stderr] 33 | Self::new() [INFO] [stderr] 34 | } [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::table::TableBuilder` [INFO] [stderr] --> src/builder/table.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 34 | | TableBuilder::with_callback(Identity) [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | impl Default for builder::table::TableBuilder { [INFO] [stderr] 32 | fn default() -> Self { [INFO] [stderr] 33 | Self::new() [INFO] [stderr] 34 | } [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::export::ExportBuilder` [INFO] [stderr] --> src/builder/export.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 16 | | ExportBuilder::with_callback(Identity) [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for builder::export::ExportBuilder { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::global::GlobalBuilder` [INFO] [stderr] --> src/builder/global.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 16 | | GlobalBuilder::with_callback(Identity) [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for builder::global::GlobalBuilder { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::data::DataSegmentBuilder` [INFO] [stderr] --> src/builder/data.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | DataSegmentBuilder::with_callback(Identity) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for builder::data::DataSegmentBuilder { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/exports.rs:24:44 [INFO] [stderr] | [INFO] [stderr] 24 | import.entries().iter().filter(|entry| match entry.external() { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 25 | | &External::Function(_) => true, [INFO] [stderr] 26 | | _ => false, [INFO] [stderr] 27 | | }).count(), [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | import.entries().iter().filter(|entry| match *entry.external() { [INFO] [stderr] 25 | External::Function(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in data_section.entries().enumerate()` or similar iterators [INFO] [stderr] --> examples/data.rs:31:15 [INFO] [stderr] | [INFO] [stderr] 31 | for entry in data_section.entries() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.89s [INFO] running `"docker" "inspect" "958b014092567dcf403893fadffed579f41278b48eb1e5c06f6b5a0eec3f529f"` [INFO] running `"docker" "rm" "-f" "958b014092567dcf403893fadffed579f41278b48eb1e5c06f6b5a0eec3f529f"` [INFO] [stdout] 958b014092567dcf403893fadffed579f41278b48eb1e5c06f6b5a0eec3f529f