[INFO] crate parallel_image_crop 0.1.0 is already in cache [INFO] extracting crate parallel_image_crop 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/parallel_image_crop/0.1.0 [INFO] extracting crate parallel_image_crop 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parallel_image_crop/0.1.0 [INFO] validating manifest of parallel_image_crop-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of parallel_image_crop-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing parallel_image_crop-0.1.0 [INFO] finished frobbing parallel_image_crop-0.1.0 [INFO] frobbed toml for parallel_image_crop-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/parallel_image_crop/0.1.0/Cargo.toml [INFO] started frobbing parallel_image_crop-0.1.0 [INFO] finished frobbing parallel_image_crop-0.1.0 [INFO] frobbed toml for parallel_image_crop-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parallel_image_crop/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting parallel_image_crop-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/parallel_image_crop/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 598d0e300616f41d8c475b9b781e0cc21cf83c8bcc9a7a2edb2cad477b070578 [INFO] running `"docker" "start" "-a" "598d0e300616f41d8c475b9b781e0cc21cf83c8bcc9a7a2edb2cad477b070578"` [INFO] [stderr] Checking parallel_image_crop v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `OsStr` [INFO] [stderr] --> src/lib.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | use std::ffi::{CStr, OsStr}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `c_uchar` [INFO] [stderr] --> src/lib.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | use libc::{size_t, c_char, c_uchar}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ColorType`, `ImageBuffer`, `imageops` [INFO] [stderr] --> src/lib.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | use image::{GenericImage, ImageBuffer, imageops, FilterType, ColorType, ImageDecoder}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lazy_load.rs:43:19 [INFO] [stderr] | [INFO] [stderr] 43 | format => return Err(image::ImageError::UnsupportedError(format!( [INFO] [stderr] | ___________________^ [INFO] [stderr] 44 | | "Image format image/{:?} is not supported.", [INFO] [stderr] 45 | | format [INFO] [stderr] 46 | | ))) [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 43 | format => Err(image::ImageError::UnsupportedError(format!( [INFO] [stderr] 44 | "Image format image/{:?} is not supported.", [INFO] [stderr] 45 | format [INFO] [stderr] 46 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `OsStr` [INFO] [stderr] --> src/lib.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | use std::ffi::{CStr, OsStr}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `c_uchar` [INFO] [stderr] --> src/lib.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | use libc::{size_t, c_char, c_uchar}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ImageBuffer`, `imageops` [INFO] [stderr] --> src/lib.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | use image::{GenericImage, ImageBuffer, imageops, FilterType, ColorType, ImageDecoder}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lazy_load.rs:43:19 [INFO] [stderr] | [INFO] [stderr] 43 | format => return Err(image::ImageError::UnsupportedError(format!( [INFO] [stderr] | ___________________^ [INFO] [stderr] 44 | | "Image format image/{:?} is not supported.", [INFO] [stderr] 45 | | format [INFO] [stderr] 46 | | ))) [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 43 | format => Err(image::ImageError::UnsupportedError(format!( [INFO] [stderr] 44 | "Image format image/{:?} is not supported.", [INFO] [stderr] 45 | format [INFO] [stderr] 46 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `ImageDecoder` [INFO] [stderr] --> src/lib.rs:13:73 [INFO] [stderr] | [INFO] [stderr] 13 | use image::{GenericImage, ImageBuffer, imageops, FilterType, ColorType, ImageDecoder}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_vec` [INFO] [stderr] --> src/lib.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | fn into_vec(self) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lazy_load.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lazy_load.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lazy_load.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn vec_to_image(v: &Vec) -> ImageResult [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:170:69 [INFO] [stderr] | [INFO] [stderr] 170 | let image_paths_vec: Vec<&str> = unsafe { slice::from_raw_parts(image_paths_ptr, length as usize) }.iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:177:55 [INFO] [stderr] | [INFO] [stderr] 177 | let scale_values = unsafe { slice::from_raw_parts(scale_ptr, length as usize) }; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:178:51 [INFO] [stderr] | [INFO] [stderr] 178 | let x_values = unsafe { slice::from_raw_parts(x_ptr, length as usize) }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:179:51 [INFO] [stderr] | [INFO] [stderr] 179 | let y_values = unsafe { slice::from_raw_parts(y_ptr, length as usize) }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:211:52 [INFO] [stderr] | [INFO] [stderr] 211 | unsafe { ptr::copy(rvec.data as *const u8, return_ptr.offset(begin as isize), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:211:52 [INFO] [stderr] | [INFO] [stderr] 211 | unsafe { ptr::copy(rvec.data as *const u8, return_ptr.offset(begin as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `return_ptr.add(begin)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `parallel_image_crop`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `ImageDecoder` [INFO] [stderr] --> src/lib.rs:13:73 [INFO] [stderr] | [INFO] [stderr] 13 | use image::{GenericImage, ImageBuffer, imageops, FilterType, ColorType, ImageDecoder}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_vec` [INFO] [stderr] --> src/lib.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | fn into_vec(self) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lazy_load.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lazy_load.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lazy_load.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn vec_to_image(v: &Vec) -> ImageResult [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:170:69 [INFO] [stderr] | [INFO] [stderr] 170 | let image_paths_vec: Vec<&str> = unsafe { slice::from_raw_parts(image_paths_ptr, length as usize) }.iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:177:55 [INFO] [stderr] | [INFO] [stderr] 177 | let scale_values = unsafe { slice::from_raw_parts(scale_ptr, length as usize) }; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:178:51 [INFO] [stderr] | [INFO] [stderr] 178 | let x_values = unsafe { slice::from_raw_parts(x_ptr, length as usize) }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:179:51 [INFO] [stderr] | [INFO] [stderr] 179 | let y_values = unsafe { slice::from_raw_parts(y_ptr, length as usize) }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:211:52 [INFO] [stderr] | [INFO] [stderr] 211 | unsafe { ptr::copy(rvec.data as *const u8, return_ptr.offset(begin as isize), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:211:52 [INFO] [stderr] | [INFO] [stderr] 211 | unsafe { ptr::copy(rvec.data as *const u8, return_ptr.offset(begin as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `return_ptr.add(begin)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | assert!(is_color == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!is_color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `parallel_image_crop`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "598d0e300616f41d8c475b9b781e0cc21cf83c8bcc9a7a2edb2cad477b070578"` [INFO] running `"docker" "rm" "-f" "598d0e300616f41d8c475b9b781e0cc21cf83c8bcc9a7a2edb2cad477b070578"` [INFO] [stdout] 598d0e300616f41d8c475b9b781e0cc21cf83c8bcc9a7a2edb2cad477b070578