[INFO] crate parallel-getter 0.2.0 is already in cache [INFO] extracting crate parallel-getter 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/parallel-getter/0.2.0 [INFO] extracting crate parallel-getter 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parallel-getter/0.2.0 [INFO] validating manifest of parallel-getter-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of parallel-getter-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing parallel-getter-0.2.0 [INFO] finished frobbing parallel-getter-0.2.0 [INFO] frobbed toml for parallel-getter-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/parallel-getter/0.2.0/Cargo.toml [INFO] started frobbing parallel-getter-0.2.0 [INFO] finished frobbing parallel-getter-0.2.0 [INFO] frobbed toml for parallel-getter-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parallel-getter/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting parallel-getter-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/parallel-getter/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bdb3bd0268a7fb085466d1b3bf26d19cd538433992892fc27ca0178ab0259ed8 [INFO] running `"docker" "start" "-a" "bdb3bd0268a7fb085466d1b3bf26d19cd538433992892fc27ca0178ab0259ed8"` [INFO] [stderr] Checking numtoa v0.2.3 [INFO] [stderr] Checking progress-streams v1.0.0 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking crossbeam-deque v0.5.2 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking crossbeam v0.4.1 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking parallel-getter v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/range.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | (124125, 1215251, 195125810), [INFO] [stderr] | ^^^^^^ help: consider: `124_125` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/range.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | (124125, 1215251, 195125810), [INFO] [stderr] | ^^^^^^^ help: consider: `1_215_251` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/range.rs:89:31 [INFO] [stderr] | [INFO] [stderr] 89 | (124125, 1215251, 195125810), [INFO] [stderr] | ^^^^^^^^^ help: consider: `195_125_810` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/range.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | format!("content range did not contain a number") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"content range did not contain a number".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | progress_callback: Option<(Box, u64)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:354:11 [INFO] [stderr] | [INFO] [stderr] 354 | part: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn PartWriter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:352:1 [INFO] [stderr] | [INFO] [stderr] 352 | / fn attempt_get( [INFO] [stderr] 353 | | client: Arc, [INFO] [stderr] 354 | | part: &mut Box, [INFO] [stderr] 355 | | url: &str, [INFO] [stderr] ... | [INFO] [stderr] 373 | | Ok(()) [INFO] [stderr] 374 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/range.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | format!("content range did not contain a number") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"content range did not contain a number".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | progress_callback: Option<(Box, u64)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:354:11 [INFO] [stderr] | [INFO] [stderr] 354 | part: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn PartWriter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:352:1 [INFO] [stderr] | [INFO] [stderr] 352 | / fn attempt_get( [INFO] [stderr] 353 | | client: Arc, [INFO] [stderr] 354 | | part: &mut Box, [INFO] [stderr] 355 | | url: &str, [INFO] [stderr] ... | [INFO] [stderr] 373 | | Ok(()) [INFO] [stderr] 374 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.46s [INFO] running `"docker" "inspect" "bdb3bd0268a7fb085466d1b3bf26d19cd538433992892fc27ca0178ab0259ed8"` [INFO] running `"docker" "rm" "-f" "bdb3bd0268a7fb085466d1b3bf26d19cd538433992892fc27ca0178ab0259ed8"` [INFO] [stdout] bdb3bd0268a7fb085466d1b3bf26d19cd538433992892fc27ca0178ab0259ed8