[INFO] crate pane 0.1.4 is already in cache [INFO] extracting crate pane 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/pane/0.1.4 [INFO] extracting crate pane 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pane/0.1.4 [INFO] validating manifest of pane-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pane-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pane-0.1.4 [INFO] removed 1 missing examples [INFO] finished frobbing pane-0.1.4 [INFO] frobbed toml for pane-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/pane/0.1.4/Cargo.toml [INFO] started frobbing pane-0.1.4 [INFO] removed 1 missing examples [INFO] finished frobbing pane-0.1.4 [INFO] frobbed toml for pane-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pane/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pane-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pane/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b0cef7b30c6cc8583d05676cf4c2a4ebabc9a7ba60821d8c8a6f391047b4989 [INFO] running `"docker" "start" "-a" "2b0cef7b30c6cc8583d05676cf4c2a4ebabc9a7ba60821d8c8a6f391047b4989"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/simple.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking graphics_buffer v0.4.4 [INFO] [stderr] Checking pane v0.1.4 (/opt/crater/workdir) [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/math.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | const ZERO: Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `Self` to be `Copy` [INFO] [stderr] --> src/math.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | const ZERO: Self; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/math.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | const ONE: Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider requiring `Self` to be `Copy` [INFO] [stderr] --> src/math.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | const ONE: Self; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/math.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | const TWO: Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider requiring `Self` to be `Copy` [INFO] [stderr] --> src/math.rs:160:16 [INFO] [stderr] | [INFO] [stderr] 160 | const TWO: Self; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | fn split_rect(&self, margin: R::Scalar, rect: R, weights: W) -> Vec [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Pane` [INFO] [stderr] --> src/lib.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / pub fn new() -> Self { [INFO] [stderr] 136 | | Pane { [INFO] [stderr] 137 | | contents: None, [INFO] [stderr] 138 | | orientation: Orientation::default(), [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | impl Default for Pane { [INFO] [stderr] 131 | fn default() -> Self { [INFO] [stderr] 132 | Self::new() [INFO] [stderr] 133 | } [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pane`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/math.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | const ZERO: Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `Self` to be `Copy` [INFO] [stderr] --> src/math.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | const ZERO: Self; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/math.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | const ONE: Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider requiring `Self` to be `Copy` [INFO] [stderr] --> src/math.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | const ONE: Self; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/math.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | const TWO: Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider requiring `Self` to be `Copy` [INFO] [stderr] --> src/math.rs:160:16 [INFO] [stderr] | [INFO] [stderr] 160 | const TWO: Self; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | fn split_rect(&self, margin: R::Scalar, rect: R, weights: W) -> Vec [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Pane` [INFO] [stderr] --> src/lib.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / pub fn new() -> Self { [INFO] [stderr] 136 | | Pane { [INFO] [stderr] 137 | | contents: None, [INFO] [stderr] 138 | | orientation: Orientation::default(), [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | impl Default for Pane { [INFO] [stderr] 131 | fn default() -> Self { [INFO] [stderr] 132 | Self::new() [INFO] [stderr] 133 | } [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pane`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2b0cef7b30c6cc8583d05676cf4c2a4ebabc9a7ba60821d8c8a6f391047b4989"` [INFO] running `"docker" "rm" "-f" "2b0cef7b30c6cc8583d05676cf4c2a4ebabc9a7ba60821d8c8a6f391047b4989"` [INFO] [stdout] 2b0cef7b30c6cc8583d05676cf4c2a4ebabc9a7ba60821d8c8a6f391047b4989