[INFO] crate palette_derive 0.4.1 is already in cache [INFO] extracting crate palette_derive 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/palette_derive/0.4.1 [INFO] extracting crate palette_derive 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/palette_derive/0.4.1 [INFO] validating manifest of palette_derive-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of palette_derive-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing palette_derive-0.4.1 [INFO] finished frobbing palette_derive-0.4.1 [INFO] frobbed toml for palette_derive-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/palette_derive/0.4.1/Cargo.toml [INFO] started frobbing palette_derive-0.4.1 [INFO] finished frobbing palette_derive-0.4.1 [INFO] frobbed toml for palette_derive-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/palette_derive/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting palette_derive-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/palette_derive/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dfa43b290c40b00b5397fee851ce1b7d7c32b9a30dd82d1813a70bb7924311ac [INFO] running `"docker" "start" "-a" "dfa43b290c40b00b5397fee851ce1b7d7c32b9a30dd82d1813a70bb7924311ac"` [INFO] [stderr] Checking syn v0.14.9 [INFO] [stderr] Checking palette_derive v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert/from_color.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | / return FromImplParameters { [INFO] [stderr] 377 | | generics, [INFO] [stderr] 378 | | alpha_path, [INFO] [stderr] 379 | | trait_path, [INFO] [stderr] ... | [INFO] [stderr] 382 | | method_call, [INFO] [stderr] 383 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 376 | FromImplParameters { [INFO] [stderr] 377 | generics, [INFO] [stderr] 378 | alpha_path, [INFO] [stderr] 379 | trait_path, [INFO] [stderr] 380 | color_ty, [INFO] [stderr] 381 | component, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert/from_color.rs:587:5 [INFO] [stderr] | [INFO] [stderr] 587 | / return FromColorTypeImplParameters { [INFO] [stderr] 588 | | generics, [INFO] [stderr] 589 | | alpha_path, [INFO] [stderr] 590 | | color_path, [INFO] [stderr] 591 | | color_ty, [INFO] [stderr] 592 | | component, [INFO] [stderr] 593 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 587 | FromColorTypeImplParameters { [INFO] [stderr] 588 | generics, [INFO] [stderr] 589 | alpha_path, [INFO] [stderr] 590 | color_path, [INFO] [stderr] 591 | color_ty, [INFO] [stderr] 592 | component, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert/from_color.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | / return FromImplParameters { [INFO] [stderr] 377 | | generics, [INFO] [stderr] 378 | | alpha_path, [INFO] [stderr] 379 | | trait_path, [INFO] [stderr] ... | [INFO] [stderr] 382 | | method_call, [INFO] [stderr] 383 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 376 | FromImplParameters { [INFO] [stderr] 377 | generics, [INFO] [stderr] 378 | alpha_path, [INFO] [stderr] 379 | trait_path, [INFO] [stderr] 380 | color_ty, [INFO] [stderr] 381 | component, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert/from_color.rs:587:5 [INFO] [stderr] | [INFO] [stderr] 587 | / return FromColorTypeImplParameters { [INFO] [stderr] 588 | | generics, [INFO] [stderr] 589 | | alpha_path, [INFO] [stderr] 590 | | color_path, [INFO] [stderr] 591 | | color_ty, [INFO] [stderr] 592 | | component, [INFO] [stderr] 593 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 587 | FromColorTypeImplParameters { [INFO] [stderr] 588 | generics, [INFO] [stderr] 589 | alpha_path, [INFO] [stderr] 590 | color_path, [INFO] [stderr] 591 | color_ty, [INFO] [stderr] 592 | component, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/util.rs:40:10 [INFO] [stderr] | [INFO] [stderr] 40 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/util.rs:52:10 [INFO] [stderr] | [INFO] [stderr] 52 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/meta.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | Err(_) => panic!( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/meta.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | Err(_) => panic!( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/convert/from_color.rs:69:10 [INFO] [stderr] | [INFO] [stderr] 69 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/convert/from_color.rs:411:34 [INFO] [stderr] | [INFO] [stderr] 411 | let match_arms = COLOR_TYPES.into_iter().map(|&color| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/convert/from_color.rs:661:9 [INFO] [stderr] | [INFO] [stderr] 661 | / match &*attribute_name.to_string() { [INFO] [stderr] 662 | | "palette_alpha" => { [INFO] [stderr] 663 | | meta::assert_empty_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 664 | | self.alpha_property = Some((field_name, ty)); [INFO] [stderr] 665 | | } [INFO] [stderr] 666 | | _ => {} [INFO] [stderr] 667 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 661 | if let "palette_alpha" = &*attribute_name.to_string() { [INFO] [stderr] 662 | meta::assert_empty_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 663 | self.alpha_property = Some((field_name, ty)); [INFO] [stderr] 664 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/convert/into_color.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | let into_impls = COLOR_TYPES.into_iter().map(|&color| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/convert/into_color.rs:450:9 [INFO] [stderr] | [INFO] [stderr] 450 | / match &*attribute_name.to_string() { [INFO] [stderr] 451 | | "palette_alpha" => { [INFO] [stderr] 452 | | meta::assert_empty_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 453 | | self.alpha_property = Some((field_name, ty)); [INFO] [stderr] 454 | | } [INFO] [stderr] 455 | | _ => {} [INFO] [stderr] 456 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 450 | if let "palette_alpha" = &*attribute_name.to_string() { [INFO] [stderr] 451 | meta::assert_empty_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 452 | self.alpha_property = Some((field_name, ty)); [INFO] [stderr] 453 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/convert/shared.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn generate_methods( [INFO] [stderr] 102 | | ident: &Ident, [INFO] [stderr] 103 | | convert_direction: ConvertDirection, [INFO] [stderr] 104 | | implementations: &[KeyValuePair], [INFO] [stderr] ... | [INFO] [stderr] 217 | | methods [INFO] [stderr] 218 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/convert/shared.rs:326:17 [INFO] [stderr] | [INFO] [stderr] 326 | fn get_best(&self, other: XyzConvert) -> XyzConvert { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/encoding/pixel.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / match &*attribute_name.to_string() { [INFO] [stderr] 111 | | "repr" => { [INFO] [stderr] 112 | | let items = meta::parse_tuple_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 113 | | let contains_c = items.into_iter().find(|item: &Ident| item == "C").is_some(); [INFO] [stderr] ... | [INFO] [stderr] 119 | | _ => {} [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 110 | if let "repr" = &*attribute_name.to_string() { [INFO] [stderr] 111 | let items = meta::parse_tuple_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 112 | let contains_c = items.into_iter().find(|item: &Ident| item == "C").is_some(); [INFO] [stderr] 113 | [INFO] [stderr] 114 | if contains_c { [INFO] [stderr] 115 | self.repr_c = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/encoding/pixel.rs:113:34 [INFO] [stderr] | [INFO] [stderr] 113 | let contains_c = items.into_iter().find(|item: &Ident| item == "C").is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|item: &Ident| item == "C").is_some()` with `any(|item: &Ident| item == "C")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/util.rs:40:10 [INFO] [stderr] | [INFO] [stderr] 40 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/util.rs:52:10 [INFO] [stderr] | [INFO] [stderr] 52 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/meta.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | Err(_) => panic!( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/meta.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | Err(_) => panic!( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/convert/from_color.rs:69:10 [INFO] [stderr] | [INFO] [stderr] 69 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/convert/from_color.rs:411:34 [INFO] [stderr] | [INFO] [stderr] 411 | let match_arms = COLOR_TYPES.into_iter().map(|&color| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/convert/from_color.rs:661:9 [INFO] [stderr] | [INFO] [stderr] 661 | / match &*attribute_name.to_string() { [INFO] [stderr] 662 | | "palette_alpha" => { [INFO] [stderr] 663 | | meta::assert_empty_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 664 | | self.alpha_property = Some((field_name, ty)); [INFO] [stderr] 665 | | } [INFO] [stderr] 666 | | _ => {} [INFO] [stderr] 667 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 661 | if let "palette_alpha" = &*attribute_name.to_string() { [INFO] [stderr] 662 | meta::assert_empty_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 663 | self.alpha_property = Some((field_name, ty)); [INFO] [stderr] 664 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/convert/into_color.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | let into_impls = COLOR_TYPES.into_iter().map(|&color| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/convert/into_color.rs:450:9 [INFO] [stderr] | [INFO] [stderr] 450 | / match &*attribute_name.to_string() { [INFO] [stderr] 451 | | "palette_alpha" => { [INFO] [stderr] 452 | | meta::assert_empty_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 453 | | self.alpha_property = Some((field_name, ty)); [INFO] [stderr] 454 | | } [INFO] [stderr] 455 | | _ => {} [INFO] [stderr] 456 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 450 | if let "palette_alpha" = &*attribute_name.to_string() { [INFO] [stderr] 451 | meta::assert_empty_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 452 | self.alpha_property = Some((field_name, ty)); [INFO] [stderr] 453 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/convert/shared.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn generate_methods( [INFO] [stderr] 102 | | ident: &Ident, [INFO] [stderr] 103 | | convert_direction: ConvertDirection, [INFO] [stderr] 104 | | implementations: &[KeyValuePair], [INFO] [stderr] ... | [INFO] [stderr] 217 | | methods [INFO] [stderr] 218 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/convert/shared.rs:326:17 [INFO] [stderr] | [INFO] [stderr] 326 | fn get_best(&self, other: XyzConvert) -> XyzConvert { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/encoding/pixel.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / match &*attribute_name.to_string() { [INFO] [stderr] 111 | | "repr" => { [INFO] [stderr] 112 | | let items = meta::parse_tuple_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 113 | | let contains_c = items.into_iter().find(|item: &Ident| item == "C").is_some(); [INFO] [stderr] ... | [INFO] [stderr] 119 | | _ => {} [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 110 | if let "repr" = &*attribute_name.to_string() { [INFO] [stderr] 111 | let items = meta::parse_tuple_attribute(&attribute_name, attribute_tts); [INFO] [stderr] 112 | let contains_c = items.into_iter().find(|item: &Ident| item == "C").is_some(); [INFO] [stderr] 113 | [INFO] [stderr] 114 | if contains_c { [INFO] [stderr] 115 | self.repr_c = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/encoding/pixel.rs:113:34 [INFO] [stderr] | [INFO] [stderr] 113 | let contains_c = items.into_iter().find(|item: &Ident| item == "C").is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|item: &Ident| item == "C").is_some()` with `any(|item: &Ident| item == "C")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.24s [INFO] running `"docker" "inspect" "dfa43b290c40b00b5397fee851ce1b7d7c32b9a30dd82d1813a70bb7924311ac"` [INFO] running `"docker" "rm" "-f" "dfa43b290c40b00b5397fee851ce1b7d7c32b9a30dd82d1813a70bb7924311ac"` [INFO] [stdout] dfa43b290c40b00b5397fee851ce1b7d7c32b9a30dd82d1813a70bb7924311ac