[INFO] crate paho-mqtt-redis 0.2.1 is already in cache
[INFO] extracting crate paho-mqtt-redis 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/paho-mqtt-redis/0.2.1
[INFO] extracting crate paho-mqtt-redis 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/paho-mqtt-redis/0.2.1
[INFO] validating manifest of paho-mqtt-redis-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of paho-mqtt-redis-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing paho-mqtt-redis-0.2.1
[INFO] finished frobbing paho-mqtt-redis-0.2.1
[INFO] frobbed toml for paho-mqtt-redis-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/paho-mqtt-redis/0.2.1/Cargo.toml
[INFO] started frobbing paho-mqtt-redis-0.2.1
[INFO] finished frobbing paho-mqtt-redis-0.2.1
[INFO] frobbed toml for paho-mqtt-redis-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/paho-mqtt-redis/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting paho-mqtt-redis-0.2.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/paho-mqtt-redis/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0b96ea11d8d177ed1641aeafd3753c12fe16545e0df69340f32a088c5d873c70
[INFO] running `"docker" "start" "-a" "0b96ea11d8d177ed1641aeafd3753c12fe16545e0df69340f32a088c5d873c70"`
[INFO] [stderr]    Compiling paho-mqtt-sys v0.2.0
[INFO] [stderr]     Checking paho-mqtt v0.4.0
[INFO] [stderr]     Checking paho-mqtt-redis v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:87:5
[INFO] [stderr]    |
[INFO] [stderr] 87 |                 return Err(mqtt::PERSISTENCE_ERROR)
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(mqtt::PERSISTENCE_ERROR)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `RedisPersistence`
[INFO] [stderr]   --> src/lib.rs:65:2
[INFO] [stderr]    |
[INFO] [stderr] 65 |       pub fn new() -> RedisPersistence {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 66 | |         RedisPersistence {
[INFO] [stderr] 67 | |             name: "".to_string(),
[INFO] [stderr] 68 | |             client: Client::open("redis://localhost/").unwrap(),
[INFO] [stderr] 69 | |             conn: None,
[INFO] [stderr] 70 | |         }
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 64 | impl Default for RedisPersistence {
[INFO] [stderr] 65 |     fn default() -> Self {
[INFO] [stderr] 66 |         Self::new()
[INFO] [stderr] 67 |     }
[INFO] [stderr] 68 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:87:5
[INFO] [stderr]    |
[INFO] [stderr] 87 |                 return Err(mqtt::PERSISTENCE_ERROR)
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(mqtt::PERSISTENCE_ERROR)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `RedisPersistence`
[INFO] [stderr]   --> src/lib.rs:65:2
[INFO] [stderr]    |
[INFO] [stderr] 65 |       pub fn new() -> RedisPersistence {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 66 | |         RedisPersistence {
[INFO] [stderr] 67 | |             name: "".to_string(),
[INFO] [stderr] 68 | |             client: Client::open("redis://localhost/").unwrap(),
[INFO] [stderr] 69 | |             conn: None,
[INFO] [stderr] 70 | |         }
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 64 | impl Default for RedisPersistence {
[INFO] [stderr] 65 |     fn default() -> Self {
[INFO] [stderr] 66 |         Self::new()
[INFO] [stderr] 67 |     }
[INFO] [stderr] 68 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 15.35s
[INFO] running `"docker" "inspect" "0b96ea11d8d177ed1641aeafd3753c12fe16545e0df69340f32a088c5d873c70"`
[INFO] running `"docker" "rm" "-f" "0b96ea11d8d177ed1641aeafd3753c12fe16545e0df69340f32a088c5d873c70"`
[INFO] [stdout] 0b96ea11d8d177ed1641aeafd3753c12fe16545e0df69340f32a088c5d873c70