[INFO] crate paho-mqtt 0.4.0 is already in cache
[INFO] extracting crate paho-mqtt 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/paho-mqtt/0.4.0
[INFO] extracting crate paho-mqtt 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/paho-mqtt/0.4.0
[INFO] validating manifest of paho-mqtt-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of paho-mqtt-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing paho-mqtt-0.4.0
[INFO] finished frobbing paho-mqtt-0.4.0
[INFO] frobbed toml for paho-mqtt-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/paho-mqtt/0.4.0/Cargo.toml
[INFO] started frobbing paho-mqtt-0.4.0
[INFO] finished frobbing paho-mqtt-0.4.0
[INFO] frobbed toml for paho-mqtt-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/paho-mqtt/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting paho-mqtt-0.4.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/paho-mqtt/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8a29bcbe5343174b39943006e79d98b6f62fd8791e0c80772e592195c252b051
[INFO] running `"docker" "start" "-a" "8a29bcbe5343174b39943006e79d98b6f62fd8791e0c80772e592195c252b051"`
[INFO] [stderr]    Compiling paho-mqtt-sys v0.2.0
[INFO] [stderr]     Checking paho-mqtt v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/async_client.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 |             cli: cli,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `cli`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/async_client.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 |             cli: cli,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `cli`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/async_client.rs:244:14
[INFO] [stderr]     |
[INFO] [stderr] 244 |           else {
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 245 | |             if let Some(ref mut cb) = self.on_failure {
[INFO] [stderr] 246 | |                 trace!("Invoking Token::on_failure callback");
[INFO] [stderr] 247 | |                 cb(cli, msgid, rc);
[INFO] [stderr] 248 | |             }
[INFO] [stderr] 249 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 244 |         else if let Some(ref mut cb) = self.on_failure {
[INFO] [stderr] 245 |     trace!("Invoking Token::on_failure callback");
[INFO] [stderr] 246 |     cb(cli, msgid, rc);
[INFO] [stderr] 247 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/async_client.rs:244:14
[INFO] [stderr]     |
[INFO] [stderr] 244 |           else {
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 245 | |             if let Some(ref mut cb) = self.on_failure {
[INFO] [stderr] 246 | |                 trace!("Invoking Token::on_failure callback");
[INFO] [stderr] 247 | |                 cb(cli, msgid, rc);
[INFO] [stderr] 248 | |             }
[INFO] [stderr] 249 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 244 |         else if let Some(ref mut cb) = self.on_failure {
[INFO] [stderr] 245 |     trace!("Invoking Token::on_failure callback");
[INFO] [stderr] 246 |     cb(cli, msgid, rc);
[INFO] [stderr] 247 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/create_options.rs:279:16
[INFO] [stderr]     |
[INFO] [stderr] 279 |         const HOST: &'static str = "localhost";
[INFO] [stderr]     |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/create_options.rs:296:16
[INFO] [stderr]     |
[INFO] [stderr] 296 |         const HOST: &'static str = "localhost";
[INFO] [stderr]     |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/create_options.rs:297:14
[INFO] [stderr]     |
[INFO] [stderr] 297 |         const ID: &'static str = "bubba";
[INFO] [stderr]     |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/create_options.rs:332:16
[INFO] [stderr]     |
[INFO] [stderr] 332 |         const HOST: &'static str = "localhost";
[INFO] [stderr]     |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/create_options.rs:333:14
[INFO] [stderr]     |
[INFO] [stderr] 333 |         const ID: &'static str = "bubba";
[INFO] [stderr]     |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/connect_options.rs:437:22
[INFO] [stderr]     |
[INFO] [stderr] 437 |         const NAME: &'static str = "some-random-name";
[INFO] [stderr]     |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/connect_options.rs:474:27
[INFO] [stderr]     |
[INFO] [stderr] 474 |         const USER_NAME: &'static str = "some-name";
[INFO] [stderr]     |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/connect_options.rs:475:26
[INFO] [stderr]     |
[INFO] [stderr] 475 |         const PASSWORD: &'static str = "some-password";
[INFO] [stderr]     |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/will_options.rs:212:19
[INFO] [stderr]     |
[INFO] [stderr] 212 |     const TOPIC: &'static str = "test";
[INFO] [stderr]     |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/will_options.rs:213:21
[INFO] [stderr]     |
[INFO] [stderr] 213 |     const PAYLOAD: &'static [u8] = b"Hello world";
[INFO] [stderr]     |                    -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/message.rs:301:19
[INFO] [stderr]     |
[INFO] [stderr] 301 |     const TOPIC: &'static str = "test";
[INFO] [stderr]     |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/message.rs:302:21
[INFO] [stderr]     |
[INFO] [stderr] 302 |     const PAYLOAD: &'static [u8] = b"Hello world";
[INFO] [stderr]     |                    -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/message.rs:373:23
[INFO] [stderr]     |
[INFO] [stderr] 373 |         const TOPIC: &'static str = "test";
[INFO] [stderr]     |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/message.rs:385:25
[INFO] [stderr]     |
[INFO] [stderr] 385 |         const PAYLOAD: &'static [u8] = b"Hello world";
[INFO] [stderr]     |                        -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/message.rs:450:23
[INFO] [stderr]     |
[INFO] [stderr] 450 |         const TOPIC: &'static str = "test";
[INFO] [stderr]     |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/message.rs:451:25
[INFO] [stderr]     |
[INFO] [stderr] 451 |         const PAYLOAD: &'static [u8] = b"Hello world";
[INFO] [stderr]     |                        -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `async_client::Token`
[INFO] [stderr]    --> src/async_client.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 | /     pub fn new() -> Token {
[INFO] [stderr] 110 | |         Token {
[INFO] [stderr] 111 | |             lock: Mutex::new(TokenData {
[INFO] [stderr] 112 | |                 complete: false,
[INFO] [stderr] ...   |
[INFO] [stderr] 122 | |         }
[INFO] [stderr] 123 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 107 | impl Default for async_client::Token {
[INFO] [stderr] 108 |     fn default() -> Self {
[INFO] [stderr] 109 |         Self::new()
[INFO] [stderr] 110 |     }
[INFO] [stderr] 111 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer to a pointer
[INFO] [stderr]    --> src/async_client.rs:820:42
[INFO] [stderr]     |
[INFO] [stderr] 820 |                                          mem::transmute(qos.as_ptr()),
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `qos.as_ptr() as *mut i32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `async_client::AsyncClientBuilder`
[INFO] [stderr]    --> src/async_client.rs:956:5
[INFO] [stderr]     |
[INFO] [stderr] 956 | /     pub fn new() -> AsyncClientBuilder {
[INFO] [stderr] 957 | |         AsyncClientBuilder {
[INFO] [stderr] 958 | |             copts: ffi::MQTTAsync_createOptions::default(),
[INFO] [stderr] 959 | |             server_uri: "".to_string(),
[INFO] [stderr] ...   |
[INFO] [stderr] 962 | |         }
[INFO] [stderr] 963 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 946 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/async_client.rs:1061:25
[INFO] [stderr]      |
[INFO] [stderr] 1061 |         let mut copts = self.copts.clone();
[INFO] [stderr]      |                         ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `create_options::CreateOptionsBuilder`
[INFO] [stderr]    --> src/create_options.rs:138:2
[INFO] [stderr]     |
[INFO] [stderr] 138 |       pub fn new() -> CreateOptionsBuilder {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 139 | |         CreateOptionsBuilder {
[INFO] [stderr] 140 | |             copts: ffi::MQTTAsync_createOptions::default(),
[INFO] [stderr] 141 | |             server_uri: "".to_string(),
[INFO] [stderr] ...   |
[INFO] [stderr] 144 | |         }
[INFO] [stderr] 145 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 136 | impl Default for create_options::CreateOptionsBuilder {
[INFO] [stderr] 137 |     fn default() -> Self {
[INFO] [stderr] 138 |         Self::new()
[INFO] [stderr] 139 |     }
[INFO] [stderr] 140 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/connect_options.rs:90:34
[INFO] [stderr]    |
[INFO] [stderr] 90 |         opts.copts.username = if opts.user_name.as_bytes().len() != 0 {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!opts.user_name.as_bytes().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/connect_options.rs:97:34
[INFO] [stderr]    |
[INFO] [stderr] 97 |         opts.copts.password = if opts.password.as_bytes().len() != 0 {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!opts.password.as_bytes().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/connect_options.rs:149:20
[INFO] [stderr]     |
[INFO] [stderr] 149 |             copts: self.copts.clone(),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connect_options::ConnectOptionsBuilder`
[INFO] [stderr]    --> src/connect_options.rs:176:5
[INFO] [stderr]     |
[INFO] [stderr] 176 | /     pub fn new() -> ConnectOptionsBuilder {
[INFO] [stderr] 177 | |         ConnectOptionsBuilder {
[INFO] [stderr] 178 | |             copts: ffi::MQTTAsync_connectOptions::default(),
[INFO] [stderr] 179 | |             will: None,
[INFO] [stderr] ...   |
[INFO] [stderr] 184 | |         }
[INFO] [stderr] 185 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 165 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/connect_options.rs:359:20
[INFO] [stderr]     |
[INFO] [stderr] 359 |             copts: self.copts.clone(),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/will_options.rs:112:35
[INFO] [stderr]     |
[INFO] [stderr] 112 |         opts.copts.topicName = if opts.topic.as_bytes().len() != 0 {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!opts.topic.as_bytes().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/will_options.rs:118:38
[INFO] [stderr]     |
[INFO] [stderr] 118 |         opts.copts.payload.data = if opts.payload.len() != 0 {
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!opts.payload.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/will_options.rs:173:20
[INFO] [stderr]     |
[INFO] [stderr] 173 |             copts: self.copts.clone(),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ssl_options::SslOptions`
[INFO] [stderr]   --> src/ssl_options.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     pub fn new() -> SslOptions {
[INFO] [stderr] 50 | |         let opts = SslOptions {
[INFO] [stderr] 51 | |             copts: ffi::MQTTAsync_SSLOptions::default(),
[INFO] [stderr] 52 | |             trust_store: CString::new("").unwrap(),
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |         SslOptions::fixup(opts)
[INFO] [stderr] 59 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 39 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/ssl_options.rs:64:12
[INFO] [stderr]    |
[INFO] [stderr] 64 |         if str.to_bytes().len() == 0 { ptr::null() } else { str.as_ptr() }
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `str.to_bytes().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/ssl_options.rs:105:20
[INFO] [stderr]     |
[INFO] [stderr] 105 |             copts: self.copts.clone(),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ssl_options::SslOptionsBuilder`
[INFO] [stderr]    --> src/ssl_options.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 | /     pub fn new() -> SslOptionsBuilder {
[INFO] [stderr] 129 | |         SslOptionsBuilder {
[INFO] [stderr] 130 | |             trust_store: "".to_string(),
[INFO] [stderr] 131 | |             key_store: "".to_string(),
[INFO] [stderr] ...   |
[INFO] [stderr] 136 | |         }
[INFO] [stderr] 137 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 118 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `disconnect_options::DisconnectOptionsBuilder`
[INFO] [stderr]   --> src/disconnect_options.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 | /     pub fn new() -> DisconnectOptionsBuilder {
[INFO] [stderr] 65 | |         DisconnectOptionsBuilder {
[INFO] [stderr] 66 | |             copts: ffi::MQTTAsync_disconnectOptions::default(),
[INFO] [stderr] 67 | |         }
[INFO] [stderr] 68 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 58 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/disconnect_options.rs:86:20
[INFO] [stderr]    |
[INFO] [stderr] 86 |             copts: self.copts.clone(),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/message.rs:100:19
[INFO] [stderr]     |
[INFO] [stderr] 100 |             cmsg: cmsg.clone(),
[INFO] [stderr]     |                   ^^^^^^^^^^^^ help: try dereferencing it: `*cmsg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/message.rs:162:19
[INFO] [stderr]     |
[INFO] [stderr] 162 |             cmsg: self.cmsg.clone(),
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cmsg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `message::MessageBuilder`
[INFO] [stderr]    --> src/message.rs:220:5
[INFO] [stderr]     |
[INFO] [stderr] 220 | /     pub fn new() -> MessageBuilder {
[INFO] [stderr] 221 | |         MessageBuilder {
[INFO] [stderr] 222 | |             topic: String::new(),
[INFO] [stderr] 223 | |             payload: Vec::new(),
[INFO] [stderr] ...   |
[INFO] [stderr] 226 | |         }
[INFO] [stderr] 227 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 210 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:111:26
[INFO] [stderr]     |
[INFO] [stderr] 111 |             let persist: &mut Box<ClientPersistence> = mem::transmute(context);
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:111:56
[INFO] [stderr]     |
[INFO] [stderr] 111 |             let persist: &mut Box<ClientPersistence> = mem::transmute(context);
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(context as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::transmute_ptr_to_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/client_persistence.rs:113:20
[INFO] [stderr]     |
[INFO] [stderr] 113 |               if let Ok(_) = persist.open(client_id, server_uri) {
[INFO] [stderr]     |  _____________-      ^^^^^
[INFO] [stderr] 114 | |                 *handle = context;
[INFO] [stderr] 115 | |                 return PERSISTENCE_SUCCESS;
[INFO] [stderr] 116 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if persist.open(client_id, server_uri).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:128:22
[INFO] [stderr]     |
[INFO] [stderr] 128 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:128:52
[INFO] [stderr]     |
[INFO] [stderr] 128 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:150:22
[INFO] [stderr]     |
[INFO] [stderr] 150 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:150:52
[INFO] [stderr]     |
[INFO] [stderr] 150 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:177:22
[INFO] [stderr]     |
[INFO] [stderr] 177 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:177:52
[INFO] [stderr]     |
[INFO] [stderr] 177 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:201:22
[INFO] [stderr]     |
[INFO] [stderr] 201 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:201:52
[INFO] [stderr]     |
[INFO] [stderr] 201 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:220:22
[INFO] [stderr]     |
[INFO] [stderr] 220 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:220:52
[INFO] [stderr]     |
[INFO] [stderr] 220 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `k`
[INFO] [stderr]    --> src/client_persistence.rs:231:30
[INFO] [stderr]     |
[INFO] [stderr] 231 |                     for i in 0..n {
[INFO] [stderr]     |                              ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 231 |                     for (i, <item>) in k.iter().enumerate().take(n) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/client_persistence.rs:238:26
[INFO] [stderr]     |
[INFO] [stderr] 238 |                         *ckeys.offset(i as isize) = cbuf;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ckeys.add(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:256:22
[INFO] [stderr]     |
[INFO] [stderr] 256 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:256:52
[INFO] [stderr]     |
[INFO] [stderr] 256 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:272:22
[INFO] [stderr]     |
[INFO] [stderr] 272 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:272:52
[INFO] [stderr]     |
[INFO] [stderr] 272 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: item `string_collection::StringCollection` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/string_collection.rs:47:1
[INFO] [stderr]     |
[INFO] [stderr] 47  | / impl StringCollection
[INFO] [stderr] 48  | | {
[INFO] [stderr] 49  | |     /// Creates a StringCollection from a vector of string references.
[INFO] [stderr] 50  | |     ///
[INFO] [stderr] ...   |
[INFO] [stderr] 127 | |     }
[INFO] [stderr] 128 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/string_collection.rs:67:22
[INFO] [stderr]    |
[INFO] [stderr] 67 |     fn to_cstring<T>(coll: &[T]) -> Vec<CString>
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/string_collection.rs:79:17
[INFO] [stderr]    |
[INFO] [stderr] 79 |     fn to_c_vec(sv: &[CString]) -> Vec<*const c_char> {
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/string_collection.rs:87:21
[INFO] [stderr]    |
[INFO] [stderr] 87 |     fn to_c_mut_vec(sv: &[CString]) -> Vec<*mut c_char> {
[INFO] [stderr]    |                     ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `async_client::Token`
[INFO] [stderr]    --> src/async_client.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 | /     pub fn new() -> Token {
[INFO] [stderr] 110 | |         Token {
[INFO] [stderr] 111 | |             lock: Mutex::new(TokenData {
[INFO] [stderr] 112 | |                 complete: false,
[INFO] [stderr] ...   |
[INFO] [stderr] 122 | |         }
[INFO] [stderr] 123 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 107 | impl Default for async_client::Token {
[INFO] [stderr] 108 |     fn default() -> Self {
[INFO] [stderr] 109 |         Self::new()
[INFO] [stderr] 110 |     }
[INFO] [stderr] 111 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer to a pointer
[INFO] [stderr]    --> src/async_client.rs:820:42
[INFO] [stderr]     |
[INFO] [stderr] 820 |                                          mem::transmute(qos.as_ptr()),
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `qos.as_ptr() as *mut i32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `async_client::AsyncClientBuilder`
[INFO] [stderr]    --> src/async_client.rs:956:5
[INFO] [stderr]     |
[INFO] [stderr] 956 | /     pub fn new() -> AsyncClientBuilder {
[INFO] [stderr] 957 | |         AsyncClientBuilder {
[INFO] [stderr] 958 | |             copts: ffi::MQTTAsync_createOptions::default(),
[INFO] [stderr] 959 | |             server_uri: "".to_string(),
[INFO] [stderr] ...   |
[INFO] [stderr] 962 | |         }
[INFO] [stderr] 963 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 946 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/async_client.rs:1061:25
[INFO] [stderr]      |
[INFO] [stderr] 1061 |         let mut copts = self.copts.clone();
[INFO] [stderr]      |                         ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `create_options::CreateOptionsBuilder`
[INFO] [stderr]    --> src/create_options.rs:138:2
[INFO] [stderr]     |
[INFO] [stderr] 138 |       pub fn new() -> CreateOptionsBuilder {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 139 | |         CreateOptionsBuilder {
[INFO] [stderr] 140 | |             copts: ffi::MQTTAsync_createOptions::default(),
[INFO] [stderr] 141 | |             server_uri: "".to_string(),
[INFO] [stderr] ...   |
[INFO] [stderr] 144 | |         }
[INFO] [stderr] 145 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 136 | impl Default for create_options::CreateOptionsBuilder {
[INFO] [stderr] 137 |     fn default() -> Self {
[INFO] [stderr] 138 |         Self::new()
[INFO] [stderr] 139 |     }
[INFO] [stderr] 140 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/connect_options.rs:90:34
[INFO] [stderr]    |
[INFO] [stderr] 90 |         opts.copts.username = if opts.user_name.as_bytes().len() != 0 {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!opts.user_name.as_bytes().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/connect_options.rs:97:34
[INFO] [stderr]    |
[INFO] [stderr] 97 |         opts.copts.password = if opts.password.as_bytes().len() != 0 {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!opts.password.as_bytes().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/connect_options.rs:149:20
[INFO] [stderr]     |
[INFO] [stderr] 149 |             copts: self.copts.clone(),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connect_options::ConnectOptionsBuilder`
[INFO] [stderr]    --> src/connect_options.rs:176:5
[INFO] [stderr]     |
[INFO] [stderr] 176 | /     pub fn new() -> ConnectOptionsBuilder {
[INFO] [stderr] 177 | |         ConnectOptionsBuilder {
[INFO] [stderr] 178 | |             copts: ffi::MQTTAsync_connectOptions::default(),
[INFO] [stderr] 179 | |             will: None,
[INFO] [stderr] ...   |
[INFO] [stderr] 184 | |         }
[INFO] [stderr] 185 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 165 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/connect_options.rs:359:20
[INFO] [stderr]     |
[INFO] [stderr] 359 |             copts: self.copts.clone(),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/connect_options.rs:457:46
[INFO] [stderr]     |
[INFO] [stderr] 457 |             let s = unsafe { CStr::from_ptr(*opts.copts.serverURIs.offset(i as isize)) };
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `opts.copts.serverURIs.add(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/will_options.rs:112:35
[INFO] [stderr]     |
[INFO] [stderr] 112 |         opts.copts.topicName = if opts.topic.as_bytes().len() != 0 {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!opts.topic.as_bytes().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/will_options.rs:118:38
[INFO] [stderr]     |
[INFO] [stderr] 118 |         opts.copts.payload.data = if opts.payload.len() != 0 {
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!opts.payload.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/will_options.rs:173:20
[INFO] [stderr]     |
[INFO] [stderr] 173 |             copts: self.copts.clone(),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ssl_options::SslOptions`
[INFO] [stderr]   --> src/ssl_options.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     pub fn new() -> SslOptions {
[INFO] [stderr] 50 | |         let opts = SslOptions {
[INFO] [stderr] 51 | |             copts: ffi::MQTTAsync_SSLOptions::default(),
[INFO] [stderr] 52 | |             trust_store: CString::new("").unwrap(),
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |         SslOptions::fixup(opts)
[INFO] [stderr] 59 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 39 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/ssl_options.rs:64:12
[INFO] [stderr]    |
[INFO] [stderr] 64 |         if str.to_bytes().len() == 0 { ptr::null() } else { str.as_ptr() }
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `str.to_bytes().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/ssl_options.rs:105:20
[INFO] [stderr]     |
[INFO] [stderr] 105 |             copts: self.copts.clone(),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ssl_options::SslOptionsBuilder`
[INFO] [stderr]    --> src/ssl_options.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 | /     pub fn new() -> SslOptionsBuilder {
[INFO] [stderr] 129 | |         SslOptionsBuilder {
[INFO] [stderr] 130 | |             trust_store: "".to_string(),
[INFO] [stderr] 131 | |             key_store: "".to_string(),
[INFO] [stderr] ...   |
[INFO] [stderr] 136 | |         }
[INFO] [stderr] 137 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 118 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `disconnect_options::DisconnectOptionsBuilder`
[INFO] [stderr]   --> src/disconnect_options.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 | /     pub fn new() -> DisconnectOptionsBuilder {
[INFO] [stderr] 65 | |         DisconnectOptionsBuilder {
[INFO] [stderr] 66 | |             copts: ffi::MQTTAsync_disconnectOptions::default(),
[INFO] [stderr] 67 | |         }
[INFO] [stderr] 68 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 58 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/disconnect_options.rs:86:20
[INFO] [stderr]    |
[INFO] [stderr] 86 |             copts: self.copts.clone(),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.copts`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/message.rs:100:19
[INFO] [stderr]     |
[INFO] [stderr] 100 |             cmsg: cmsg.clone(),
[INFO] [stderr]     |                   ^^^^^^^^^^^^ help: try dereferencing it: `*cmsg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/message.rs:162:19
[INFO] [stderr]     |
[INFO] [stderr] 162 |             cmsg: self.cmsg.clone(),
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cmsg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `message::MessageBuilder`
[INFO] [stderr]    --> src/message.rs:220:5
[INFO] [stderr]     |
[INFO] [stderr] 220 | /     pub fn new() -> MessageBuilder {
[INFO] [stderr] 221 | |         MessageBuilder {
[INFO] [stderr] 222 | |             topic: String::new(),
[INFO] [stderr] 223 | |             payload: Vec::new(),
[INFO] [stderr] ...   |
[INFO] [stderr] 226 | |         }
[INFO] [stderr] 227 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 210 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:111:26
[INFO] [stderr]     |
[INFO] [stderr] 111 |             let persist: &mut Box<ClientPersistence> = mem::transmute(context);
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:111:56
[INFO] [stderr]     |
[INFO] [stderr] 111 |             let persist: &mut Box<ClientPersistence> = mem::transmute(context);
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(context as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::transmute_ptr_to_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/client_persistence.rs:113:20
[INFO] [stderr]     |
[INFO] [stderr] 113 |               if let Ok(_) = persist.open(client_id, server_uri) {
[INFO] [stderr]     |  _____________-      ^^^^^
[INFO] [stderr] 114 | |                 *handle = context;
[INFO] [stderr] 115 | |                 return PERSISTENCE_SUCCESS;
[INFO] [stderr] 116 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if persist.open(client_id, server_uri).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:128:22
[INFO] [stderr]     |
[INFO] [stderr] 128 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:128:52
[INFO] [stderr]     |
[INFO] [stderr] 128 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:150:22
[INFO] [stderr]     |
[INFO] [stderr] 150 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:150:52
[INFO] [stderr]     |
[INFO] [stderr] 150 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:177:22
[INFO] [stderr]     |
[INFO] [stderr] 177 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:177:52
[INFO] [stderr]     |
[INFO] [stderr] 177 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:201:22
[INFO] [stderr]     |
[INFO] [stderr] 201 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:201:52
[INFO] [stderr]     |
[INFO] [stderr] 201 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:220:22
[INFO] [stderr]     |
[INFO] [stderr] 220 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:220:52
[INFO] [stderr]     |
[INFO] [stderr] 220 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `k`
[INFO] [stderr]    --> src/client_persistence.rs:231:30
[INFO] [stderr]     |
[INFO] [stderr] 231 |                     for i in 0..n {
[INFO] [stderr]     |                              ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 231 |                     for (i, <item>) in k.iter().enumerate().take(n) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/client_persistence.rs:238:26
[INFO] [stderr]     |
[INFO] [stderr] 238 |                         *ckeys.offset(i as isize) = cbuf;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ckeys.add(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:256:22
[INFO] [stderr]     |
[INFO] [stderr] 256 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:256:52
[INFO] [stderr]     |
[INFO] [stderr] 256 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/client_persistence.rs:272:22
[INFO] [stderr]     |
[INFO] [stderr] 272 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ClientPersistence`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer type (`*mut client_persistence::libc::c_void`) to a reference type (`&mut std::boxed::Box<dyn client_persistence::ClientPersistence>`)
[INFO] [stderr]    --> src/client_persistence.rs:272:52
[INFO] [stderr]     |
[INFO] [stderr] 272 |         let persist: &mut Box<ClientPersistence> = mem::transmute(handle);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(handle as *mut std::boxed::Box<dyn client_persistence::ClientPersistence>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref
[INFO] [stderr] 
[INFO] [stderr] warning: item `string_collection::StringCollection` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/string_collection.rs:47:1
[INFO] [stderr]     |
[INFO] [stderr] 47  | / impl StringCollection
[INFO] [stderr] 48  | | {
[INFO] [stderr] 49  | |     /// Creates a StringCollection from a vector of string references.
[INFO] [stderr] 50  | |     ///
[INFO] [stderr] ...   |
[INFO] [stderr] 127 | |     }
[INFO] [stderr] 128 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/string_collection.rs:67:22
[INFO] [stderr]    |
[INFO] [stderr] 67 |     fn to_cstring<T>(coll: &[T]) -> Vec<CString>
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/string_collection.rs:79:17
[INFO] [stderr]    |
[INFO] [stderr] 79 |     fn to_c_vec(sv: &[CString]) -> Vec<*const c_char> {
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/string_collection.rs:87:21
[INFO] [stderr]    |
[INFO] [stderr] 87 |     fn to_c_mut_vec(sv: &[CString]) -> Vec<*mut c_char> {
[INFO] [stderr]    |                     ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 14.53s
[INFO] running `"docker" "inspect" "8a29bcbe5343174b39943006e79d98b6f62fd8791e0c80772e592195c252b051"`
[INFO] running `"docker" "rm" "-f" "8a29bcbe5343174b39943006e79d98b6f62fd8791e0c80772e592195c252b051"`
[INFO] [stdout] 8a29bcbe5343174b39943006e79d98b6f62fd8791e0c80772e592195c252b051