[INFO] crate pafi 0.1.0 is already in cache [INFO] extracting crate pafi 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/pafi/0.1.0 [INFO] extracting crate pafi 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pafi/0.1.0 [INFO] validating manifest of pafi-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pafi-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pafi-0.1.0 [INFO] finished frobbing pafi-0.1.0 [INFO] frobbed toml for pafi-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/pafi/0.1.0/Cargo.toml [INFO] started frobbing pafi-0.1.0 [INFO] finished frobbing pafi-0.1.0 [INFO] frobbed toml for pafi-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pafi/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pafi-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pafi/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c88690a73545e24dc1477b21b4951d242b02c397e0ad0411ee689dcf4fc1cfe [INFO] running `"docker" "start" "-a" "7c88690a73545e24dc1477b21b4951d242b02c397e0ad0411ee689dcf4fc1cfe"` [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking pafi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 54 | | if let Some(res_get) = get_file(&url) { [INFO] [stderr] 55 | | if let Some(ou) = args.out_path { [INFO] [stderr] 56 | | if let Some(valid_out_path) = check_path_file(ou) { [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | } else if let Some(res_get) = get_file(&url) { [INFO] [stderr] 54 | if let Some(ou) = args.out_path { [INFO] [stderr] 55 | if let Some(valid_out_path) = check_path_file(ou) { [INFO] [stderr] 56 | write_file(valid_out_path, &res_get); [INFO] [stderr] 57 | } [INFO] [stderr] 58 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | if path.is_dir() { [INFO] [stderr] 85 | | let random: u16 = rand::random(); [INFO] [stderr] 86 | | let path_join = path.join(PathBuf::from(format!("pafi-file-{}.txt", random))); [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | } else if path.is_dir() { [INFO] [stderr] 84 | let random: u16 = rand::random(); [INFO] [stderr] 85 | let path_join = path.join(PathBuf::from(format!("pafi-file-{}.txt", random))); [INFO] [stderr] 86 | Some(path_join) [INFO] [stderr] 87 | } else if path.parent().unwrap().is_dir() { [INFO] [stderr] 88 | Some(path) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 54 | | if let Some(res_get) = get_file(&url) { [INFO] [stderr] 55 | | if let Some(ou) = args.out_path { [INFO] [stderr] 56 | | if let Some(valid_out_path) = check_path_file(ou) { [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | } else if let Some(res_get) = get_file(&url) { [INFO] [stderr] 54 | if let Some(ou) = args.out_path { [INFO] [stderr] 55 | if let Some(valid_out_path) = check_path_file(ou) { [INFO] [stderr] 56 | write_file(valid_out_path, &res_get); [INFO] [stderr] 57 | } [INFO] [stderr] 58 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | if path.is_dir() { [INFO] [stderr] 85 | | let random: u16 = rand::random(); [INFO] [stderr] 86 | | let path_join = path.join(PathBuf::from(format!("pafi-file-{}.txt", random))); [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | } else if path.is_dir() { [INFO] [stderr] 84 | let random: u16 = rand::random(); [INFO] [stderr] 85 | let path_join = path.join(PathBuf::from(format!("pafi-file-{}.txt", random))); [INFO] [stderr] 86 | Some(path_join) [INFO] [stderr] 87 | } else if path.parent().unwrap().is_dir() { [INFO] [stderr] 88 | Some(path) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if args.delete == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `args.delete` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | if let Some(_) = path.extension() { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 77 | | if path.parent().unwrap().is_dir() { [INFO] [stderr] 78 | | Some(path) [INFO] [stderr] 79 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____- help: try this: `if path.extension().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | file.write(data.as_bytes()).expect("can't write to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pafi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if args.delete == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `args.delete` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | if let Some(_) = path.extension() { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 77 | | if path.parent().unwrap().is_dir() { [INFO] [stderr] 78 | | Some(path) [INFO] [stderr] 79 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____- help: try this: `if path.extension().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | file.write(data.as_bytes()).expect("can't write to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pafi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7c88690a73545e24dc1477b21b4951d242b02c397e0ad0411ee689dcf4fc1cfe"` [INFO] running `"docker" "rm" "-f" "7c88690a73545e24dc1477b21b4951d242b02c397e0ad0411ee689dcf4fc1cfe"` [INFO] [stdout] 7c88690a73545e24dc1477b21b4951d242b02c397e0ad0411ee689dcf4fc1cfe