[INFO] crate pact_verifier_cli 0.4.0 is already in cache [INFO] extracting crate pact_verifier_cli 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/pact_verifier_cli/0.4.0 [INFO] extracting crate pact_verifier_cli 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pact_verifier_cli/0.4.0 [INFO] validating manifest of pact_verifier_cli-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pact_verifier_cli-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pact_verifier_cli-0.4.0 [INFO] finished frobbing pact_verifier_cli-0.4.0 [INFO] frobbed toml for pact_verifier_cli-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/pact_verifier_cli/0.4.0/Cargo.toml [INFO] started frobbing pact_verifier_cli-0.4.0 [INFO] finished frobbing pact_verifier_cli-0.4.0 [INFO] frobbed toml for pact_verifier_cli-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pact_verifier_cli/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pact_verifier_cli-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pact_verifier_cli/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 807ceec2c93f10266a788f78a598349a4f47089d3c68511465f5f19f8fffb0c9 [INFO] running `"docker" "start" "-a" "807ceec2c93f10266a788f78a598349a4f47089d3c68511465f5f19f8fffb0c9"` [INFO] [stderr] Checking maplit v0.1.6 [INFO] [stderr] Checking p-macro v0.2.0 [INFO] [stderr] Checking indextree v1.3.0 [INFO] [stderr] Checking sxd-document v0.2.6 [INFO] [stderr] Checking difference v0.4.1 [INFO] [stderr] Checking simplelog v0.1.0 [INFO] [stderr] Compiling skeptic v0.4.0 [INFO] [stderr] Checking cookie v0.2.5 [INFO] [stderr] Checking quickcheck v0.2.27 [INFO] [stderr] Compiling expectest v0.5.1 [INFO] [stderr] Checking hyper v0.9.18 [INFO] [stderr] Checking pact_matching v0.4.5 [INFO] [stderr] Checking pact_mock_server v0.4.0 [INFO] [stderr] Checking pact_consumer v0.4.0 [INFO] [stderr] Checking pact_verifier v0.4.0 [INFO] [stderr] Checking pact_verifier_cli v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | / match matches.values_of("file") { [INFO] [stderr] 241 | | Some(values) => sources.extend(values.map(|v| PactSource::File(s!(v))).collect::>()), [INFO] [stderr] 242 | | None => () [INFO] [stderr] 243 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(values) = matches.values_of("file") { sources.extend(values.map(|v| PactSource::File(s!(v))).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | / match matches.values_of("dir") { [INFO] [stderr] 245 | | Some(values) => sources.extend(values.map(|v| PactSource::Dir(s!(v))).collect::>()), [INFO] [stderr] 246 | | None => () [INFO] [stderr] 247 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(values) = matches.values_of("dir") { sources.extend(values.map(|v| PactSource::Dir(s!(v))).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:248:5 [INFO] [stderr] | [INFO] [stderr] 248 | / match matches.values_of("url") { [INFO] [stderr] 249 | | Some(values) => sources.extend(values.map(|v| PactSource::URL(s!(v))).collect::>()), [INFO] [stderr] 250 | | None => () [INFO] [stderr] 251 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(values) = matches.values_of("url") { sources.extend(values.map(|v| PactSource::URL(s!(v))).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | / match matches.values_of("broker-url") { [INFO] [stderr] 253 | | Some(values) => sources.extend(values.map(|v| PactSource::BrokerUrl(s!(matches.value_of("provider-name").unwrap()), [INFO] [stderr] 254 | | s!(v))).collect::>()), [INFO] [stderr] 255 | | None => () [INFO] [stderr] 256 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 252 | if let Some(values) = matches.values_of("broker-url") { sources.extend(values.map(|v| PactSource::BrokerUrl(s!(matches.value_of("provider-name").unwrap()), [INFO] [stderr] 253 | s!(v))).collect::>()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:420:104 [INFO] [stderr] | [INFO] [stderr] 420 | if verify_provider(&provider, source, &filter, &matches.values_of_lossy("filter-consumer").unwrap_or(vec![])) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | / match matches.values_of("file") { [INFO] [stderr] 241 | | Some(values) => sources.extend(values.map(|v| PactSource::File(s!(v))).collect::>()), [INFO] [stderr] 242 | | None => () [INFO] [stderr] 243 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(values) = matches.values_of("file") { sources.extend(values.map(|v| PactSource::File(s!(v))).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | / match matches.values_of("dir") { [INFO] [stderr] 245 | | Some(values) => sources.extend(values.map(|v| PactSource::Dir(s!(v))).collect::>()), [INFO] [stderr] 246 | | None => () [INFO] [stderr] 247 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(values) = matches.values_of("dir") { sources.extend(values.map(|v| PactSource::Dir(s!(v))).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:248:5 [INFO] [stderr] | [INFO] [stderr] 248 | / match matches.values_of("url") { [INFO] [stderr] 249 | | Some(values) => sources.extend(values.map(|v| PactSource::URL(s!(v))).collect::>()), [INFO] [stderr] 250 | | None => () [INFO] [stderr] 251 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(values) = matches.values_of("url") { sources.extend(values.map(|v| PactSource::URL(s!(v))).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | / match matches.values_of("broker-url") { [INFO] [stderr] 253 | | Some(values) => sources.extend(values.map(|v| PactSource::BrokerUrl(s!(matches.value_of("provider-name").unwrap()), [INFO] [stderr] 254 | | s!(v))).collect::>()), [INFO] [stderr] 255 | | None => () [INFO] [stderr] 256 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 252 | if let Some(values) = matches.values_of("broker-url") { sources.extend(values.map(|v| PactSource::BrokerUrl(s!(matches.value_of("provider-name").unwrap()), [INFO] [stderr] 253 | s!(v))).collect::>()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:420:104 [INFO] [stderr] | [INFO] [stderr] 420 | if verify_provider(&provider, source, &filter, &matches.values_of_lossy("filter-consumer").unwrap_or(vec![])) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:464:69 [INFO] [stderr] | [INFO] [stderr] 464 | Err(_) => TestResult::from_bool(s.is_empty() || s.chars().find(|ch| !ch.is_numeric() ).is_some()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|ch| !ch.is_numeric()).is_some()` with `any(|ch| !ch.is_numeric())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.33s [INFO] running `"docker" "inspect" "807ceec2c93f10266a788f78a598349a4f47089d3c68511465f5f19f8fffb0c9"` [INFO] running `"docker" "rm" "-f" "807ceec2c93f10266a788f78a598349a4f47089d3c68511465f5f19f8fffb0c9"` [INFO] [stdout] 807ceec2c93f10266a788f78a598349a4f47089d3c68511465f5f19f8fffb0c9